Skip to contentSkip to conversation

Patch "hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead" has been added to the 3.10-stable tree

PATCH [email protected] 3 participants 6 messages Jul 31, 2015

Subsystems (2)
Stable branch Hpfs filesystem
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead

to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
hpfs-hpfs_error-remove-static-buffer-use-vsprintf-extension-pv-instead.patch
and it can be found in the queue-3.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From a28e4b2b18ccb90df402da3f21e1a83c9d4f8ec1 Mon Sep 17 00:00:00 2001

From: Joe Perches <[email protected]>
Date: Thu, 26 Mar 2015 20:47:10 -0700
Subject: hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead

From: Joe Perches <[email protected]>

commit a28e4b2b18ccb90df402da3f21e1a83c9d4f8ec1 upstream.

Removing unnecessary static buffers is good.
Use the vsprintf %pV extension instead.

Signed-off-by Joe Perches <[email protected]>
Signed-off-by Mikulas Patocka <[email protected]>
Signed-off-by Linus Torvalds <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
 fs/hpfs/super.c |   11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)
fs/hpfs/super.c +7 -4
@@ -52,17 +52,20 @@ static void unmark_dirty(struct super_bl
 }
 
 /* Filesystem error... */
-static char err_buf[1024];
-
 void hpfs_error(struct super_block *s, const char *fmt, ...)
 {
+	struct va_format vaf;
 	va_list args;
 
 	va_start(args, fmt);
-	vsnprintf(err_buf, sizeof(err_buf), fmt, args);
+
+	vaf.fmt = fmt;
+	vaf.va = &args;
+
+	pr_err("filesystem error: %pV", &vaf);
+
 	va_end(args);
 
-	printk("HPFS: filesystem error: %s", err_buf);
 	if (!hpfs_sb(s)->sb_was_error) {
 		if (hpfs_sb(s)->sb_err == 2) {
 			printk("; crashing the system because you wanted it\n");

Patches currently in stable-queue which might be from [email protected] are

queue-3.10/hpfs-hpfs_error-remove-static-buffer-use-vsprintf-extension-pv-instead.patch

#1 lore raw
Quoted 6 lines · On Fri, 2015-07-31 at 12:37 -0700, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead

to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

While I know this patch reduces some code and text, it's not correcting any defect in the code, it's only a minor optimization.

Is it really appropriate for stable?

author maintainer
#2 lore raw
Quoted 5 lines · Joe Perches
Quoted 4 lines · On Fri, 2015-07-31 at 12:37 -0700, [email protected] wrote:

This is a note to let you know that I've just added the patch titled

hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead

Quoted 8 lines
Quoted 2 lines

to the 3.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

While I know this patch reduces some code and text, it's not correcting any defect in the code, it's only a minor optimization.

Is it really appropriate for stable?

I agree, why was it marked that way? I assumed it was due to the patch after it needed it, but maybe not. Any objection to me just dropping it?

thanks,

greg k-h

#3 lore raw
Quoted 16 lines · Greg KH
Quoted 15 lines · Joe Perches
Quoted 9 lines · On Fri, 2015-07-31 at 12:37 -0700, [email protected]:

This is a note to let you know that I've just added the patch titled

hpfs: hpfs_error: Remove static buffer, use vsprintf
extension %pV instead

to the 3.10-stable tree which can be found at:

http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

While I know this patch reduces some code and text, it's not correcting any defect in the code, it's only a minor optimization.

Quoted 6 lines
Quoted 1 line

Is it really appropriate for stable?

I agree, why was it marked that way? I assumed it was due to the patch
after it needed it, but maybe not. Any objection to me just dropping it?

Not from me.

I think Mikulas marked it for stable.

Mikulas?

#4 lore raw
Quoted 24 lines · Joe Perches
Quoted 16 lines · Greg KH
Quoted 15 lines · Joe Perches
Quoted 9 lines · On Fri, 2015-07-31 at 12:37 -0700, [email protected]:

This is a note to let you know that I've just added the patch titled

hpfs: hpfs_error: Remove static buffer, use vsprintf
extension %pV instead

to the 3.10-stable tree which can be found at:

http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

While I know this patch reduces some code and text, it's not correcting any defect in the code, it's only a minor optimization.

Quoted 6 lines
Quoted 1 line

Is it really appropriate for stable?

I agree, why was it marked that way? I assumed it was due to the patch
after it needed it, but maybe not. Any objection to me just dropping it?

Quoted 5 lines

Not from me.

I think Mikulas marked it for stable.

Mikulas?

The bug corrected by the patch is - if hpfs_error is called concurrently on multiple filesystems, it could corrupt the string because the text buffer is shared. That's why I marked the patch for stable.

Mikulas

#5 lore raw
Quoted 35 lines · Mikulas Patocka
Quoted 3 lines · Joe Perches
Quoted 2 lines · Greg KH
Quoted 1 line · Joe Perches

On Fri, 2015-07-31 at 12:37 -0700,

Quoted 1 line · [email protected]:
Quoted 1 line
Quoted 1 line
Quoted 1 line

This is a note to let you know that I've just added the

patch

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

titled

hpfs: hpfs_error: Remove static buffer, use vsprintf
extension %pV instead

to the 3.10-stable tree which can be found at:

http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 8 lines
Quoted 8 lines
Quoted 6 lines

While I know this patch reduces some code and text, it's not correcting any defect in the code, it's only a minor optimization.

Is it really appropriate for stable?

I agree, why was it marked that way? I assumed it was due to

the

Quoted 2 lines
Quoted 2 lines

patch
after it needed it, but maybe not. Any objection to me just

dropping

Quoted 6 lines
Quoted 1 line

it?

Not from me.

I think Mikulas marked it for stable.

Quoted 7 lines
Quoted 1 line

Mikulas?

The bug corrected by the patch is - if hpfs_error is called concurrently
on multiple filesystems, it could corrupt the string because the text
buffer is shared. That's why I marked the patch for stable.

OK then. If you noticed that when you marked it for stable, it would have been nicer to update the commit message to show a bug fix too.

cheers, Joe