patch "thermal: exynos: Disable the regulator on probe failure" added to thermal-soc tree
Subsystems (4)
This is a simple automated notification to let you know that I've just added the patch titled
thermal: exynos: Disable the regulator on probe failure
to my thermal-soc git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal.git
in the fixes branch.
The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)
The patch will hopefully also be merged in Linus's tree for the next -rc kernel release.
If you have any questions about this process, please let me know.
All the best,
Eduardo Valentin
----------
Quoted 1 line
From
a1e569c9a3206c17365c0d0cf7d6e15b9e9b6dbdMon Sep 17 00:00:00 2001
From: Krzysztof Kozlowski <[email protected]>
Date: Mon, 8 Jun 2015 10:35:49 +0900
Subject: thermal: exynos: Disable the regulator on probe failure
During probe the regulator (if present) was enabled but not disabled in case of failure. So an unsuccessful probe lead to enabling the regulator which was actually not needed because the device was not enabled.
Additionally each deferred probe lead to increase of regulator enable count so it would not be effectively disabled during removal of the device.
Test HW: Exynos4412 - Trats2 board
--- drivers/thermal/samsung/exynos_tmu.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/thermal/samsung/exynos_tmu.c +2 -0
@@ -1392,6 +1392,8 @@ err_clk_sec:if (!IS_ERR (data->clk_sec))clk_unprepare (data->clk_sec); err_sensor: +if (!IS_ERR_OR_NULL (data->regulator)) +regulator_disable (data->regulator);thermal_zone_of_sensor_unregister (&pdev->dev, data->tzd);return ret;
Signature · 1 line
2.5.0