sgi-gru: Correct misuse of %0x<decimal>
PATCH 1/1 sgi-gru: Correct misuse of %0x<decimal>
Correct misuse of 0x%d in logging message.
Signed-off-by Joe Perches <[email protected]>
--- drivers/misc/sgi-gru/grumain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/sgi-gru/grumain.c +1 -1
@@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,spin_lock (&gru->gs_asid_lock);BUG_ON ((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap); asids->mt_ctxbitmap ^= ctxbitmap; -gru_dbg (grudev,"gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n" , +gru_dbg (grudev,"gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n" , gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0 ]);spin_unlock (&gru->gs_asid_lock);spin_unlock (&gms->ms_asid_lock);
This should be %d, not 0x%x.
Nacked-by Dimitri Sivanich <[email protected]>
Quoted 20 lines · Joe Perches
Correct misuse of 0x%d in logging message.
Signed-off-by Joe Perches <[email protected]>--- drivers/misc/sgi-gru/grumain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/misc/sgi-gru/grumain.c +1
-1@@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,spin_lock (&gru->gs_asid_lock);BUG_ON ((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap); asids->mt_ctxbitmap ^= ctxbitmap; -gru_dbg (grudev,"gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n" , +gru_dbg (grudev,"gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n" , gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0 ]);spin_unlock (&gru->gs_asid_lock);spin_unlock (&gms->ms_asid_lock);
Quoted 1 line · Dimitri Sivanich
This should be %d, not 0x%x.
I don't care one way or the other, but
please fix it so it matches.
Quoted 13 lines
Quoted 13 lines
drivers/misc/sgi-gru/grumain.c +1
-1@@ -283,7 +283,7 @@ static void gru_unload_mm_tracker(struct gru_state *gru,spin_lock (&gru->gs_asid_lock);BUG_ON ((asids->mt_ctxbitmap & ctxbitmap) != ctxbitmap); asids->mt_ctxbitmap ^= ctxbitmap; -gru_dbg (grudev,"gid %d, gts %p, gms %p, ctxnum 0x%d, asidmap 0x%lx\n" , +gru_dbg (grudev,"gid %d, gts %p, gms %p, ctxnum 0x%x, asidmap 0x%lx\n" , gru->gs_gid, gts, gms, gts->ts_ctxnum, gms->ms_asidmap[0 ]);spin_unlock (&gru->gs_asid_lock);spin_unlock (&gms->ms_asid_lock);