Skip to contentSkip to conversation

Lustre: remove cfs_daemonize from comments

PATCH New [email protected] 1 participant 3 messages Aug 4, 2015 Staging

lore
Share & tools
lore
#0 lore raw

cover Lustre: remove cfs_daemonize from comments

From: Oleg Drokin <[email protected]>

cfs_daemonize was removed long ago, but I just stumbled upon a couple of instances where it was still referenced in the comments, so here are the patches to clean it up and not cause any unnecessary confusion.

Oleg Drokin (2):
staging/lustre/ptlrpc: Remove stray daemonize comment staging/lustre: Properly reference kthread_run instead of
cfs_daemonize

 drivers/staging/lustre/lustre/include/lustre_net.h | 2 +-
 drivers/staging/lustre/lustre/ptlrpc/pinger.c      | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/2 staging/lustre/ptlrpc: Remove stray cfs_daemonize comment

From: Oleg Drokin <[email protected]>

Ever since daemonize was removed in 3.18, there are no longer any flags passed to kthread_run.
Most of the comments were deleted, but this one lingered on until now.

---
 drivers/staging/lustre/lustre/ptlrpc/pinger.c | 2 --
 1 file changed, 2 deletions(-)
drivers/staging/lustre/lustre/ptlrpc/pinger.c +0 -2
index d05c37c..f8edb79 100644
@@ -318,8 +318,6 @@ int ptlrpc_start_pinger(void)
 
 	strcpy(pinger_thread.t_name, "ll_ping");
 
-	/* CLONE_VM and CLONE_FILES just avoid a needless copy, because we
-	 * just drop the VM and FILES in cfs_daemonize_ctxt() right away. */
 	rc = PTR_ERR(kthread_run(ptlrpc_pinger_main, &pinger_thread,
 				 "%s", pinger_thread.t_name));
 	if (IS_ERR_VALUE(rc)) {
Signature · 1 line
2.1.0
#2 lore raw

PATCH 2/2 staging/lustre: Properly reference kthread_run instead of cfs_daemonize

In reply to [email protected]

From: Oleg Drokin <[email protected]>

cfs_daemonize is long gone and replaced by a proper call to kthread_run, so update the comment to reflect that fact.

---
 drivers/staging/lustre/lustre/include/lustre_net.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/include/lustre_net.h +1 -1
index 77a7de9..3bb2f8b 100644
@@ -2183,7 +2183,7 @@ struct ptlrpcd_ctl {
 	 */
 	struct ptlrpc_request_set  *pc_set;
 	/**
-	 * Thread name used in cfs_daemonize()
+	 * Thread name used in kthread_run()
 	 */
 	char			pc_name[16];
 	/**
Signature · 1 line
2.1.0