Skip to contentSkip to conversation

Staging: lustre: Replace comma with a semicolon

PATCH Superseded Shraddha Barke 2 participants 5 messages Aug 4, 2015 1 message not in the archive Staging

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/3 Staging: lustre: Replace comma with a semicolon

Replace comma between expression statements by a semicolon. The semantic patch used is as follows:

@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
---
Changes in v2:
-No changes made.

 drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/libcfs/libcfs_string.c +1 -1
index 4dde8e0..efe5e66 100644
@@ -400,7 +400,7 @@ cfs_expr_list_free(struct cfs_expr_list *expr_list)
 		struct cfs_range_expr *expr;
 
 		expr = list_entry(expr_list->el_exprs.next,
-				      struct cfs_range_expr, re_link),
+				      struct cfs_range_expr, re_link);
 		list_del(&expr->re_link);
 		LIBCFS_FREE(expr, sizeof(*expr));
 	}
Signature · 1 line
2.1.0
#1 lore raw

PATCH v2 2/3 Staging: lustre: Replace comma between expression statements by a semicolon.

Replace comma between expression statements by a semicolon. The semantic patch used is as follows:

@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
---
Changes in v2:
-Make subject more clearer.

 drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/mgc/mgc_request.c +1 -1
index 562bd95..019ee2f 100644
@@ -1232,7 +1232,7 @@ static int mgc_apply_recover_logs(struct obd_device *mgc,
 		pos += sprintf(obdname + pos, "-%s%04x",
 				  is_ost ? "OST" : "MDT", entry->mne_index);
 
-		cname = is_ost ? "osc" : "mdc",
+		cname = is_ost ? "osc" : "mdc";
 		pos += sprintf(obdname + pos, "-%s-%s", cname, inst);
 		lustre_cfg_bufs_reset(&bufs, obdname);
 
Signature · 1 line
2.1.0
#2 lore raw

Re: [PATCH v2 2/3] Staging: lustre: Replace comma between expression statements by a semicolon.

Sorry not to have been more clear. The original subject text was OK. Tehway to differentiate between the patches would be to put Staging:
lustre: mgc: in thi case, and Staging: lustre: libcfs: in the other one.

julia

Quoted 34 lines · Shraddha Barke

Replace comma between expression statements by a semicolon. The semantic patch used is as follows:

@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
---
Changes in v2:
-Make subject more clearer.

 drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/mgc/mgc_request.c +1 -2
index 562bd95..019ee2f 100644
@@ -1232,7 +1232,7 @@ static int mgc_apply_recover_logs(struct obd_device *mgc,
 		pos += sprintf(obdname + pos, "-%s%04x",
 				  is_ost ? "OST" : "MDT", entry->mne_index);
 
-		cname = is_ost ? "osc" : "mdc",
+		cname = is_ost ? "osc" : "mdc";
 		pos += sprintf(obdname + pos, "-%s-%s", cname, inst);
 		lustre_cfg_bufs_reset(&bufs, obdname);
 
--

2.1.0

A message that is not in the archive (sent off-list or not yet received): CAO393AAyJ-OTz+yfGsHdaKeyyXT3Y8EMoxgVJzoZCjXRB=UJGg@mail.gmail.com

#4 lore raw

Re: [PATCH v2 2/3] Staging: lustre: Replace comma between expression statements by a semicolon.

Quoted 2 lines · Shraddha Barke

Alright .
So now I should send a version 3 right ?

Yes.

Quoted 1 line

 Was there any other issue in the way I sent this version ?

I think it's ok.

julia

#5 lore raw

PATCH v2 3/3 Staging: netlogic: Replace comma with a semicolon

In reply to Shraddha Barke

Replace comma between expression statements by a semicolon. The semantic patch used is as follows:

@@
expression e1,e2;
@@
e1
- ,
+ ;
e2;
---
Changes in v2:
-No changes made.

 drivers/staging/netlogic/platform_net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/netlogic/platform_net.c +1 -1
index 77c3c35..e914147 100644
@@ -163,7 +163,7 @@ static void xls_gmac_init(void)
 	switch (nlm_prom_info.board_major_version) {
 	case 12:
 		/* first block RGMII or XAUI, use RGMII */
-		ndata0.phy_interface = PHY_INTERFACE_MODE_RGMII,
+		ndata0.phy_interface = PHY_INTERFACE_MODE_RGMII;
 		ndata0.tx_stnid[0] = FMN_STNID_GMAC0_TX0;
 		ndata0.phy_addr[0] = 0;
 
Signature · 1 line
2.1.0