Skip to contentSkip to conversation

ath10k: initialize features string in ath10k_print_driver_info() to prevent garbled dmesg output when fw_features == 0

PATCH In review Victor van Poppelen 2 participants 2 messages Aug 5, 2015 – Aug 13, 2015 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath10k: initialize features string in ath10k_print_driver_info() to prevent garbled dmesg output when fw_features == 0

---
 drivers/net/wireless/ath/ath10k/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/debug.c +1 -1
index 1a33bf0..5f32924 100644
@@ -124,7 +124,7 @@ EXPORT_SYMBOL(ath10k_info);
 
 void ath10k_print_driver_info(struct ath10k *ar)
 {
-	char fw_features[128];
+	char fw_features[128] = "";
 
 	ath10k_core_get_fw_features_str(ar, fw_features, sizeof(fw_features));
 
Signature · 7 lines
2.4.3


_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k
#1 lore raw
Quoted 9 lines · Victor van Poppelen
---
 drivers/net/wireless/ath/ath10k/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/debug.c +0 -0
index 1a33bf0..5f32924 100644

drivers/net/wireless/ath/ath10k/debug.c EXPORT_SYMBOL(ath10k_info); · line 127

Quoted 5 lines
drivers/net/wireless/ath/ath10k/debug.c +1 -1
@@ -124,7 +124,7 @@ EXPORT_SYMBOL(ath10k_info);
 
 void ath10k_print_driver_info(struct ath10k *ar)
 {
-	char fw_features[128];
+	char fw_features[128] = "";

Michal already sent a patch for this:

https://github.com/kvalo/ath/commit/84e3df60f0daba5b1e7874101502d0b030afb867

Also your patch was missing a Signed-off-by and commit log. Please read Documentation/SubmittingPatches for more info.

Signature · 6 lines
Kalle Valo

_______________________________________________
ath10k mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/ath10k