Skip to contentSkip to conversation

drm/i915/skl: Bypass debug message if scalers are not requested

PATCH In review Tvrtko Ursulin 2 participants 2 messages Aug 5, 2015 – Aug 12, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/skl: Bypass debug message if scalers are not requested

From: Tvrtko Ursulin <[email protected]>

The loop below does nothing if scaler_users has no bits set so it is safe to bail out early in order to avoid dmesg spam, on for example cursor updates.

v2: Commit message and rebase.

Cc Chandra Konduru <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 drivers/gpu/drm/i915/intel_atomic.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/intel_atomic.c +4 -0
index e2531cf59266..523afd21cf87 100644
@@ -148,6 +148,10 @@ int intel_atomic_setup_scalers(struct drm_device *dev,
 	int num_scalers_need;
 	int i, j;
 
+
+	if (scaler_state->scaler_users == 0)
+		return 0;
+
 	num_scalers_need = hweight32(scaler_state->scaler_users);
 	DRM_DEBUG_KMS("crtc_state = %p need = %d avail = %d scaler_users = 0x%x\n",
 		crtc_state, num_scalers_need, intel_crtc->num_scalers,
Signature · 6 lines
2.4.6

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tested-by on v1 1/1
#1 lore raw

Task id: 7070 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
ILK -1 302/302 301/302

SNB                                  315/315              315/315
IVB                                  336/336              336/336
BYT                                  283/283              283/283
HSW                                  378/378              378/378

-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
*ILK igt@kms_flip@rcs-wf_vblank-vs-dpms-interruptible PASS(1) DMESG_WARN(1)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx