Skip to contentSkip to conversation

patch "auxdisplay: ks0108: fix refcount" added to char-misc-testing

PATCH [email protected] 1 participant 1 message Aug 5, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

auxdisplay: ks0108: fix refcount

to my char-misc git tree which can be found at
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
in the char-misc-testing branch.

The patch will show up in the next release of the linux-next tree (usually sometime within the next 24 hours during the week.)

The patch will be merged to the char-misc-next branch sometime soon, after it passes testing, and the merge window is open.

If you have any questions about this process, please let me know.

Quoted 1 line

From bab383de3b84e584b0f09227151020b2a43dc34c Mon Sep 17 00:00:00 2001

From: Sudip Mukherjee <[email protected]>
Date: Mon, 20 Jul 2015 17:27:21 +0530
Subject: auxdisplay: ks0108: fix refcount

parport_find_base() will implicitly do parport_get_port() which increases the refcount. Then parport_register_device() will again increment the refcount. But while unloading the module we are only doing parport_unregister_device() decrementing the refcount only once. We add an parport_put_port() to neutralize the effect of parport_get_port().

---
 drivers/auxdisplay/ks0108.c | 1 +
 1 file changed, 1 insertion(+)
drivers/auxdisplay/ks0108.c +1 -0
index 5b93852392b8..0d752851a1ee 100644
@@ -139,6 +139,7 @@ static int __init ks0108_init(void)
 
 	ks0108_pardevice = parport_register_device(ks0108_parport, KS0108_NAME,
 		NULL, NULL, NULL, PARPORT_DEV_EXCL, NULL);
+	parport_put_port(ks0108_parport);
 	if (ks0108_pardevice == NULL) {
 		printk(KERN_ERR KS0108_NAME ": ERROR: "
 			"parport didn't register new device\n");
Signature · 1 line
2.5.0