mtd: brcmnand: Fix misuse of IS_ENABLED
Subsystems (2)
PATCH v2 1/1 mtd: brcmnand: Fix misuse of IS_ENABLED
While IS_ENABLED() is perfectly fine for CONFIG_* symbols, it is not for other symbols such as __BIG_ENDIAN that is provided directly by the compiler.
Switch to use CONFIG_CPU_BIG_ENDIAN instead of __BIG_ENDIAN.
Signed-off-by Axel Lin <[email protected]>
---
v2:
Based on Florian's comment:
Switch to use CONFIG_CPU_BIG_ENDIAN instead of __BIG_ENDIAN.
drivers/mtd/nand/brcmnand/brcmnand.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mtd/nand/brcmnand/brcmnand.h +2 -2
@@ -50,7 +50,7 @@ static inline u32 brcmnand_readl(void __iomem *addr)* Other architectures (e.g., ARM) either do not support big endian, or * else leave I/O in little endian mode. */ -if (IS_ENABLED (CONFIG_MIPS ) &&IS_ENABLED (__BIG_ENDIAN)) +if (IS_ENABLED (CONFIG_MIPS ) &&IS_ENABLED (CONFIG_CPU_BIG_ENDIAN ))return __raw_readl (addr);else return readl_relaxed (addr);
@@ -59,7 +59,7 @@ static inline u32 brcmnand_readl(void __iomem *addr)static inline void brcmnand_writel (u32 val,void __iomem *addr) {/* See brcmnand_readl() comments */ -if (IS_ENABLED (CONFIG_MIPS ) &&IS_ENABLED (__BIG_ENDIAN)) +if (IS_ENABLED (CONFIG_MIPS ) &&IS_ENABLED (CONFIG_CPU_BIG_ENDIAN ))__raw_writel (val, addr);else writel_relaxed (val, addr);
Signature · 1 line
2.1.0
Brian Norris
AppliedQuoted 11 lines · Axel Lin
While
IS_ENABLED()is perfectly fine for CONFIG_* symbols, it is not for other symbols such as__BIG_ENDIANthat is provided directly by the compiler.Switch to use
CONFIG_CPU_BIG_ENDIANinstead of__BIG_ENDIAN.Signed-off-by Axel Lin <[email protected]>---
v2:
Based on Florian's comment:
Switch to useCONFIG_CPU_BIG_ENDIANinstead of__BIG_ENDIAN.
Applied to l2-mtd.git with:
Fixes 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller")
Thanks,
Brian
Quoted 30 lines
drivers/mtd/nand/brcmnand/brcmnand.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/mtd/nand/brcmnand/brcmnand.h +2
-2@@ -50,7 +50,7 @@ static inline u32 brcmnand_readl(void __iomem *addr)* Other architectures (e.g., ARM) either do not support big endian, or * else leave I/O in little endian mode. */ -if (IS_ENABLED (CONFIG_MIPS ) &&IS_ENABLED (__BIG_ENDIAN)) +if (IS_ENABLED (CONFIG_MIPS ) &&IS_ENABLED (CONFIG_CPU_BIG_ENDIAN ))return __raw_readl (addr);else return readl_relaxed (addr);@@ -59,7 +59,7 @@ static inline u32 brcmnand_readl(void __iomem *addr)static inline void brcmnand_writel (u32 val,void __iomem *addr) {/* See brcmnand_readl() comments */ -if (IS_ENABLED (CONFIG_MIPS ) &&IS_ENABLED (__BIG_ENDIAN)) +if (IS_ENABLED (CONFIG_MIPS ) &&IS_ENABLED (CONFIG_CPU_BIG_ENDIAN ))__raw_writel (val, addr);else writel_relaxed (val, addr);Signature · 1 line
2.1.0