drm/i915: Add audio set_ncts callback
Subsystems (3)
PATCH 1/4 drm/i915: Add audio set_ncts callback
From: Libin Yang <[email protected]>
Add the set_ncts callback.
With the callback, audio driver can trigger
i915 driver to set the proper N/CTS
based on different sample rates.
--- include/drm/i915_component.h | 2 ++ 1 file changed, 2 insertions(+)
include/drm/i915_component.h +2 -0
@@ -33,6 +33,8 @@ struct i915_audio_component {void (*put_power)(struct device *);void (*codec_wake_override)(struct device *,bool enable);int (*get_cdclk_freq)(struct device *); +int (*set_ncts)(struct device *,int port,int dev_entry, +int rate); } *ops; };
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/4 drm/i915: implement set_ncts callback
From: Libin Yang <[email protected]>
Display audio may not work at some frequencies with the HW provided N/CTS.
This patch sets the proper N value for the given audio sample rate at the impacted frequencies. At other frequencies, it will use the N/CTS value which HW provides.
--- drivers/gpu/drm/i915/i915_reg.h | 2 + drivers/gpu/drm/i915/intel_audio.c | 93 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 95 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +2 -0
@@ -7010,6 +7010,8 @@ enum skl_disp_power_wells { _HSW_AUD_MISC_CTRL_A, \ _HSW_AUD_MISC_CTRL_B) +#define HSW_AUD_PIPE_CONN_SEL_CTRL 0x650ac +#define _HSW_AUD_DIP_ELD_CTRL_ST_A 0x650b4#define _HSW_AUD_DIP_ELD_CTRL_ST_B 0x651b4#define HSW_AUD_DIP_ELD_CTRL (pipe) _PIPE(pipe, \
drivers/gpu/drm/i915/intel_audio.c +93 -0
111 lines not on this page · raw message
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [alsa-devel] [PATCH 2/4] drm/i915: implement set_ncts callback
Quoted 36 lines · On Thu, 06 Aug 2015 08:52:55 +0200, [email protected] wrote:
From: Libin Yang <[email protected]>
Display audio may not work at some frequencies with the HW provided N/CTS.
This patch sets the proper N value for the given audio sample rate at the impacted frequencies. At other frequencies, it will use the N/CTS value which HW provides.
Signed-off-by Libin Yang <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 2 + drivers/gpu/drm/i915/intel_audio.c | 93 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 95 insertions(+)drivers/gpu/drm/i915/i915_reg.h +2
-0@@ -7010,6 +7010,8 @@ enum skl_disp_power_wells { _HSW_AUD_MISC_CTRL_A, \ _HSW_AUD_MISC_CTRL_B) +#define HSW_AUD_PIPE_CONN_SEL_CTRL 0x650ac +#define _HSW_AUD_DIP_ELD_CTRL_ST_A 0x650b4#define _HSW_AUD_DIP_ELD_CTRL_ST_B 0x651b4#define HSW_AUD_DIP_ELD_CTRL (pipe) _PIPE(pipe, \drivers/gpu/drm/i915/intel_audio.c +0
-0@@ -68,6 +68,28 @@ static const struct { { 148500, AUD_CONFIG_PIXEL_CLOCK_HDMI_148500 },
drivers/gpu/drm/i915/intel_audio.c static const struct { · line 78
Quoted 10 lines
drivers/gpu/drm/i915/intel_audio.c +8
-0}; +static const struct { +int sample_rate; +int clock; +int n; +int cts; +} aud_ncts[] = { + {44100 ,DIV_ROUND_UP (297000 *1000 ,1001 ),4459 ,234375 }, + {44100 ,297000 ,4704 ,247500 },
As these two clock values are referred repeatedly in other places, it'd be better to define constants.
Takashi
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [alsa-devel] [PATCH 2/4] drm/i915: implement set_ncts callback
Hi Takashi,
Quoted 52 lines
-----Original Message-----
From: Takashi Iwai [mailto:[email protected]]
Sent: Thursday, August 06, 2015 5:21 PM
To: Yang, Libin
Cc: [email protected]; [email protected]; Lin, Mengdong
Subject: Re: [alsa-devel] [PATCH 2/4] drm/i915: implementset_nctscallbackQuoted 11 lines · On Thu, 06 Aug 2015 08:52:55 +0200, [email protected] wrote:
From: Libin Yang <[email protected]>
Display audio may not work at some frequencies with the HW provided N/CTS.
This patch sets the proper N value for the given audio sample rate at the impacted frequencies. At other frequencies, it will use the N/CTS value which HW provides.
Quoted 4 lines
Signed-off-by Libin Yang <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 2 + drivers/gpu/drm/i915/intel_audio.c | 93++++++++++++++++++++++++++++++++++++++
Review
Quoted 3 lines
2 files changed, 95 insertions(+)(quoted diff) +0
-0
b/drivers/gpu/drm/i915/i915_reg.hReview
Quoted 13 lines
index 3a77678..0b1cd72 100644
drivers/gpu/drm/i915/i915_reg.h +2
-0@@ -7010,6 +7010,8 @@ enum skl_disp_power_wells { _HSW_AUD_MISC_CTRL_A, \ _HSW_AUD_MISC_CTRL_B) +#define HSW_AUD_PIPE_CONN_SEL_CTRL 0x650ac +#define _HSW_AUD_DIP_ELD_CTRL_ST_A 0x650b4#define _HSW_AUD_DIP_ELD_CTRL_ST_B 0x651b4#define HSW_AUD_DIP_ELD_CTRL (pipe) _PIPE(pipe, \(quoted diff) +0
-0
b/drivers/gpu/drm/i915/intel_audio.cQuoted 7 lines
index dc32cf4..f1148cd 100644
drivers/gpu/drm/i915/intel_audio.c +0
-0@@ -68,6 +68,28 @@ static const struct { { 148500, AUD_CONFIG_PIXEL_CLOCK_HDMI_148500 }, };
Quoted 11 lines
drivers/gpu/drm/i915/intel_audio.c static const struct { · line 78
Quoted 8 lines
drivers/gpu/drm/i915/intel_audio.c +8
-0+static const struct { +int sample_rate; +int clock; +int n; +int cts; +} aud_ncts[] = { + {44100 ,DIV_ROUND_UP (297000 *1000 ,1001 ),4459 ,234375 }, + {44100 ,297000 ,4704 ,247500 },As these two clock values are referred repeatedly in other places, it'd be better to define constants.
Do you mean use Macro such as:
#define 297MHZ 297000
#define 296MHZ DIV_ROUND_UP(297000 * 1000, 1001)
Quoted 3 lines
Takashi
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/4 ALSA: hda - display audio call ncts callback
In reply to [email protected]From: Libin Yang <[email protected]>
On some Intel platforms, display audio need set N/CTS manually at some TMDS frequencies.
--- sound/pci/hda/patch_hdmi.c | 7 +++++++ 1 file changed, 7 insertions(+)
sound/pci/hda/patch_hdmi.c +7 -0
@@ -1786,6 +1786,8 @@ static int generic_hdmi_playback_pcm_prepare(struct hda_pcm_stream *hinfo,int pin_idx =hinfo_to_pin_index (codec, hinfo);struct hdmi_spec_per_pin *per_pin =get_pin (spec, pin_idx);hda_nid_t pin_nid = per_pin->pin_nid; +struct snd_pcm_runtime *runtime = substream->runtime; +struct i915_audio_component *acomp = codec->bus->core.audio_component;bool non_pcm;int pinctl;
@@ -1802,6 +1804,11 @@ static int generic_hdmi_playback_pcm_prepare(struct hda_pcm_stream *hinfo,intel_not_share_assigned_cvt (codec, pin_nid, per_pin->mux_idx); } +if (is_haswell_plus (codec)) { +if (acomp && acomp->ops && acomp->ops->set_ncts) + acomp->ops->set_ncts (acomp->dev, per_pin->pin_nid -4 , +0 , runtime->rate); + } non_pcm =check_non_pcm_per_cvt (codec, cvt_nid);mutex_lock (&per_pin->lock); per_pin->channels = substream->runtime->channels;
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 3/4] ALSA: hda - display audio call ncts callback
Quoted 25 lines · On Thu, 06 Aug 2015 08:52:56 +0200, [email protected] wrote:
From: Libin Yang <[email protected]>
On some Intel platforms, display audio need set N/CTS manually at some TMDS frequencies.
Signed-off-by Libin Yang <[email protected]>--- sound/pci/hda/patch_hdmi.c | 7 +++++++ 1 file changed, 7 insertions(+)sound/pci/hda/patch_hdmi.c +2
-0@@ -1786,6 +1786,8 @@ static int generic_hdmi_playback_pcm_prepare(struct hda_pcm_stream *hinfo,int pin_idx =hinfo_to_pin_index (codec, hinfo);struct hdmi_spec_per_pin *per_pin =get_pin (spec, pin_idx);hda_nid_t pin_nid = per_pin->pin_nid; +struct snd_pcm_runtime *runtime = substream->runtime; +struct i915_audio_component *acomp = codec->bus->core.audio_component;bool non_pcm;int pinctl;
sound/pci/hda/patch_hdmi.c static int generic_hdmi_playback_pcm_prepare(struct hda_pcm_stream *hinfo, · line 1809
Quoted 6 lines
sound/pci/hda/patch_hdmi.c +3
-0@@ -1802,6 +1804,11 @@ static int generic_hdmi_playback_pcm_prepare(struct hda_pcm_stream *hinfo,intel_not_share_assigned_cvt (codec, pin_nid, per_pin->mux_idx); } +if (is_haswell_plus (codec)) { +if (acomp && acomp->ops && acomp->ops->set_ncts) + acomp->ops->set_ncts(acomp->dev, per_pin->pin_nid - 4,
Please describe more how "pin_nid - 4" is supposed to work. Also...
sound/pci/hda/patch_hdmi.c static int generic_hdmi_playback_pcm_prepare(struct hda_pcm_stream *hinfo, · line 1810
Quoted 1 line
sound/pci/hda/patch_hdmi.c +1
-0+ 0, runtime->rate);
... this implies that no MST support included?
Overall, it'd be appreciated if you put more information text in changelog or comment. it series looks like a black magic to me unless clearly explained.
thanks,
Takashi
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 3/4] ALSA: hda - display audio call ncts callback
Hi Takashi,
Quoted 43 lines
-----Original Message-----
From: Takashi Iwai [mailto:[email protected]]
Sent: Thursday, August 06, 2015 6:03 PM
To: Yang, Libin
Cc: [email protected]; [email protected]; Lin, Mengdong
Subject: Re: [PATCH 3/4] ALSA: hda - display audio call ncts callbackQuoted 6 lines · On Thu, 06 Aug 2015 08:52:56 +0200, [email protected] wrote:
From: Libin Yang <[email protected]>
On some Intel platforms, display audio need set N/CTS manually at some TMDS frequencies.
Review
Quoted 6 lines
Signed-off-by Libin Yang <[email protected]>--- sound/pci/hda/patch_hdmi.c | 7 +++++++ 1 file changed, 7 insertions(+)(quoted diff) +0
-0
b/sound/pci/hda/patch_hdmi.csound/pci/hda/patch_hdmi.c static int
Quoted 4 lines
index a97db5f..4bd11ff 100644
sound/pci/hda/patch_hdmi.c +0
-0@@ -1786,6 +1786,8 @@ static intgeneric_hdmi_playback_pcm_prepare(struct
hda_pcm_stream*hinfo,sound/pci/hda/patch_hdmi.c static int
Quoted 10 lines
sound/pci/hda/patch_hdmi.c +2
-0int pin_idx =hinfo_to_pin_index (codec, hinfo);struct hdmi_spec_per_pin *per_pin =get_pin (spec, pin_idx);hda_nid_t pin_nid = per_pin->pin_nid; +struct snd_pcm_runtime *runtime = substream->runtime; +struct i915_audio_component *acomp = codec->bus- core.audio_component;bool non_pcm;int pinctl;@@ -1802,6 +1804,11 @@ static intgeneric_hdmi_playback_pcm_prepare(struct
hda_pcm_stream*hinfo,Quoted 4 lines
sound/pci/hda/patch_hdmi.c +0
-0intel_not_share_assigned_cvt (codec, pin_nid, per_pin- mux_idx); }
Quoted 6 lines
sound/pci/hda/patch_hdmi.c static int generic_hdmi_playback_pcm_prepare(struct hda_pcm_stream *hinfo,
Quoted 4 lines
sound/pci/hda/patch_hdmi.c +3
-0+if (is_haswell_plus (codec)) { +if (acomp && acomp->ops && acomp->ops->set_ncts) + acomp->ops->set_ncts(acomp->dev, per_pin- pin_nid - 4,Please describe more how "
pin_nid- 4" is supposed to work. Also...
OK, I see.
Quoted 4 lines
sound/pci/hda/patch_hdmi.c static int generic_hdmi_playback_pcm_prepare(struct hda_pcm_stream *hinfo, · line 1810
Quoted 2 lines
sound/pci/hda/patch_hdmi.c +1
-0+ 0, runtime->rate);... this implies that no MST support included?
We will support MST later. Currently I just add the interface to support MST, but not implementing it.
After we enabled MST, I will submit another patch to support MST. Currently, it seems the display audio driver need do some change to support MST.
Quoted 4 lines
Overall, it'd be appreciated if you put more information text in changelog or comment. it series looks like a black magic to me unless clearly explained.
OK, I will add the comments about the details.
Quoted 5 lines
thanks,
Takashi
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [alsa-devel] [PATCH 3/4] ALSA: hda - display audio call ncts callback
Quoted 54 lines
Quoted 44 lines
-----Original Message-----
From: Takashi Iwai [mailto:[email protected]]
Sent: Thursday, August 06, 2015 6:03 PM
To: Yang, Libin
Cc: [email protected]; [email protected]; Lin, Mengdong
Subject: Re: [PATCH 3/4] ALSA: hda - display audio call ncts callbackQuoted 6 lines · On Thu, 06 Aug 2015 08:52:56 +0200, [email protected] wrote:
From: Libin Yang <[email protected]>
On some Intel platforms, display audio need set N/CTS manually at some TMDS frequencies.
Review
Quoted 6 lines
Signed-off-by Libin Yang <[email protected]>--- sound/pci/hda/patch_hdmi.c | 7 +++++++ 1 file changed, 7 insertions(+)(quoted diff) +0
-0
b/sound/pci/hda/patch_hdmi.csound/pci/hda/patch_hdmi.c static int
Quoted 4 lines
index a97db5f..4bd11ff 100644
sound/pci/hda/patch_hdmi.c +0
-0@@ -1786,6 +1786,8 @@ static intgeneric_hdmi_playback_pcm_prepare(struct
hda_pcm_stream*hinfo,sound/pci/hda/patch_hdmi.c static int
Quoted 10 lines
sound/pci/hda/patch_hdmi.c +2
-0int pin_idx =hinfo_to_pin_index (codec, hinfo);struct hdmi_spec_per_pin *per_pin =get_pin (spec, pin_idx);hda_nid_t pin_nid = per_pin->pin_nid; +struct snd_pcm_runtime *runtime = substream->runtime; +struct i915_audio_component *acomp = codec->bus- core.audio_component;bool non_pcm;int pinctl;@@ -1802,6 +1804,11 @@ static intgeneric_hdmi_playback_pcm_prepare(struct
hda_pcm_stream*hinfo,Quoted 4 lines
sound/pci/hda/patch_hdmi.c +0
-0intel_not_share_assigned_cvt (codec, pin_nid, per_pin- mux_idx); }Quoted 6 lines
sound/pci/hda/patch_hdmi.c static int generic_hdmi_playback_pcm_prepare(struct hda_pcm_stream *hinfo,
Quoted 4 lines
sound/pci/hda/patch_hdmi.c +3
-0+if (is_haswell_plus (codec)) { +if (acomp && acomp->ops && acomp->ops->set_ncts) + acomp->ops->set_ncts(acomp->dev, per_pin- pin_nid - 4,Please describe more how "
pin_nid- 4" is supposed to work. Also...OK, I see.
Quoted 1 line
Quoted 6 lines
Quoted 3 lines
sound/pci/hda/patch_hdmi.c static int generic_hdmi_playback_pcm_prepare(struct hda_pcm_stream *hinfo, · line 1810
Quoted 1 line
sound/pci/hda/patch_hdmi.c +1
-0+ 0, runtime->rate);... this implies that no MST support included?
We will support MST later. Currently I just add the interface to support MST, but not implementing it.
Refer to DCN HDA040-A
Multi-stream over Single Display Port
Can the driver use subdevices for those display port support multi streaming ?
The specification allow up to 64 device entries
This mean the number of subdevices is equal to the device list length
More than one audio output /converters can be connected to the multi stream displayport pin widget but different device entry while only one audio output can be dynamically allocated to other HDMI pin widget
7.3.3.42 Device Select
For Digital Display Pin Widget that is multi stream capable, the Device Select control determines which Device Entry is currently selected and accessible by the Pin Widget verbs which are controlling the sink device operations. This control verb is only required if it is a Digital Display Pin Widget and multi stream capable.
The index is in relation to the Device List associated with the widget. The index is a zero-based offset into the Device List. Once the Device Entry is selected by the Set index, all subsequent Pin Widget verbs controlling the sink device operations will be directed to the selected Device Entry, until the Device Select verb get updated with a new value.
Device Entry: Indicate the index of Device Entry (0 63) which the UR bit of is generated for a multi stream capable Digital Display Pin Widget. Not valid for non Digital Display Pin Widget or Digital Display Pin Widget that is not multi stream capable
Device List Length is a 0 based integer value indicating the number of sink device that a multi stream capable Digital Display Pin Widget can support. If Device List Length is value is 0, there is only one sink device connection possible indicating the Pin Widget is not multi stream capable, and there is no Device Select control (see Section 7.3.3.42). If the Device List Length value is 1 – 63, it indicates the Pin Widget is multi stream capable, and 2 – 64 Device Entries are supported in the Pin Widget.
Quoted 1 line
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [alsa-devel] [PATCH 3/4] ALSA: hda - display audio call ncts callback
Hi Raymond,
Quoted 13 lines
Quoted 9 lines
Quoted 7 lines
}
+ if (
is_haswell_plus(codec)) {
+ if (acomp &&acomp->ops&&acomp->ops->set_ncts) + acomp->ops->set_ncts(acomp->dev, per_pin-pin_nid- 4,Please describe more how "
pin_nid- 4" is supposed to work. Also...OK, I see.
Quoted 1 line
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
+ 0,
runtime->rate);... this implies that no MST support included?
We will support MST later. Currently I just add the interface to support MST, but not implementing it.
Refer to DCN HDA040-A
Multi-stream over Single Display Port
Can the driver use subdevices for those display port support multi streaming ?
[Libin] What do you mean subdevice here,
using a struct device to represent a dev_entry or an int type?
The specification allow up to 64 device entries
This mean the number of subdevices is equal to the device list length
More than one audio output /converters can be connected to the multi stream displayport pin widget but different device entry while only one audio output can be dynamically allocated to other HDMI pin widget
[Libin] Yes, Pin widget can have multiple device entry and connecting different converters. The audio output will be based on device entry.
7.3.3.42 Device Select
For Digital Display Pin Widget that is multi stream capable, the Device Select control determines which Device Entry is currently selected and accessible by the Pin Widget verbs which are controlling the sink device operations. This control verb is only required if it is a Digital Display Pin Widget and multi stream capable.
The index is in relation to the Device List associated with the widget. The index is a zero-based offset into the Device List. Once the Device Entry is selected by the Set index, all subsequent Pin Widget verbs controlling the sink device operations will be directed to the selected Device Entry, until the Device Select verb get updated with a new value.
Device Entry: Indicate the index of Device Entry (0 63) which the UR bit of is generated for a multi stream capable Digital Display Pin Widget. Not valid for non Digital Display Pin Widget or Digital Display Pin Widget that is not multi stream capable
Device List Length is a 0 based integer value indicating the number of sink device that a multi stream capable Digital Display Pin Widget can support. If Device List Length is value is 0, there is only one sink device connection possible indicating the Pin Widget is not multi stream capable, and there is no Device Select control (see Section 7.3.3.42). If the Device List Length value is 1 – 63, it indicates the Pin Widget is multi stream capable, and 2 – 64 Device Entries are supported in the Pin Widget.
Quoted 1 line
Regards,
Libin
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [alsa-devel] [PATCH 3/4] ALSA: hda - display audio call ncts callback
2015-8-10 上午11:15於 "Yang, Libin" <[email protected]>寫道:
Quoted 18 lines
Hi Raymond,
Quoted 15 lines
Quoted 9 lines
Quoted 7 lines
}sound/pci/hda/patch_hdmi.c +3
-0+if (is_haswell_plus (codec)) { +if (acomp && acomp->ops && acomp->ops->set_ncts) + acomp->ops->set_ncts(acomp->dev, per_pin-
pin_nid- 4,Please describe more how "
pin_nid- 4" is supposed to work. Also...OK, I see.
Quoted 3 lines
Quoted 2 lines
+ 0,
runtime->rate);
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
... this implies that no MST support included?
We will support MST later. Currently I just add the interface to support MST, but not implementing it.
Refer to DCN HDA040-A
Multi-stream over Single Display Port
Can the driver use subdevices for those display port support multi
streaming ?
Quoted 3 lines
[Libin] What do you mean subdevice here,
using a struct device to represent adev_entryor an int type?
When HDA codecs have three Audio Input widgets, the driver create three subdevices for those desktop which have three or more input sources in the past
ARECORD
**** List of CAPTURE Hardware Devices ****
card 0: Intel [HDA Intel], device 0: STAC92xx Analog [STAC92xx Analog]
Subdevices: 3/3
Subdevice #0: subdevice #0
Subdevice #1: subdevice #1
Subdevice #2: subdevice #2
With the auto generic parser , the driver create one subdevice for Analog two subdevices for Alt Analog
**** List of CAPTURE Hardware Devices ****
card 0: Intel [HDA Intel], device 0: STAC92xx Analog [STAC92xx Analog]
Subdevices: 1/1
Subdevice #0: subdevice #0
card 0: Intel [HDA Intel], device 2: STAC92xx Alt Analog [STAC92xx Alt Analog]
Subdevices: 2/2
Subdevice #0: subdevice #0
Subdevice #1: subdevice #1
Quoted 4 lines
The specification allow up to 64 device entries
This mean the number of subdevices is equal to the device list length More than one audio output /converters can be connected to the multi
stream displayport pin widget but different device entry while only one audio output can be dynamically allocated to other HDMI pin widget
Quoted 2 lines
[Libin] Yes, Pin widget can have multiple device entry and connecting
different converters. The audio output will be based on device entry.
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [alsa-devel] [PATCH 3/4] ALSA: hda - display audio call ncts callback
Hi Raymond,
From: Raymond Yau [mailto:[email protected]]
Sent: Monday, August 10, 2015 12:23 PM
To: Yang, Libin
Cc: [email protected]; Takashi Iwai; Lin, Mengdong; [email protected]
Subject: RE: [alsa-devel] [PATCH 3/4] ALSA: hda - display audio call ncts callback
2015-8-10 上午11:15於 "Yang, Libin" <[email protected]<mailto:[email protected]>>寫道:
Quoted 20 lines
Hi Raymond,
Quoted 17 lines
Quoted 9 lines
Quoted 7 lines
}sound/pci/hda/patch_hdmi.c +3
-0+if (is_haswell_plus (codec)) { +if (acomp && acomp->ops && acomp->ops->set_ncts) + acomp->ops->set_ncts(acomp->dev, per_pin-
pin_nid- 4,Please describe more how "
pin_nid- 4" is supposed to work. Also...OK, I see.
Quoted 4 lines
Quoted 2 lines
+ 0,
runtime->rate);... this implies that no MST support included?
Quoted 8 lines
Quoted 2 lines
We will support MST later. Currently I just add the interface to support MST, but not implementing it.
Refer to DCN HDA040-A
Multi-stream over Single Display Port
Can the driver use subdevices for those display port support multi streaming ?[Libin] What do you mean subdevice here,
using a struct device to represent adev_entryor an int type?
When HDA codecs have three Audio Input widgets, the driver create three subdevices for those desktop which have three or more input sources in the past
This is what we are thinking currently. Different companies
have different implementation. On currently Intel platforms,
it may show several pin widgets and each pin widget has
several device entry. But it actually only support 3 streams.
Mengdong is thinking to use dynamic PCM to implement it,
and so we don’t need each subdevice for each device entry.
I’m not sure we will use what solution. It seems it is a
good open question to discuss.
Regards,
Libin
ARECORD
**** List of CAPTURE Hardware Devices ****
card 0: Intel [HDA Intel], device 0: STAC92xx Analog [STAC92xx Analog]
Subdevices: 3/3
Subdevice #0: subdevice #0
Subdevice #1: subdevice #1
Subdevice #2: subdevice #2
With the auto generic parser , the driver create one subdevice for Analog two subdevices for Alt Analog
**** List of CAPTURE Hardware Devices ****
card 0: Intel [HDA Intel], device 0: STAC92xx Analog [STAC92xx Analog]
Subdevices: 1/1
Subdevice #0: subdevice #0
card 0: Intel [HDA Intel], device 2: STAC92xx Alt Analog [STAC92xx Alt Analog]
Subdevices: 2/2
Subdevice #0: subdevice #0
Subdevice #1: subdevice #1
Quoted 6 lines
The specification allow up to 64 device entries
This mean the number of subdevices is equal to the device list length
More than one audio output /converters can be connected to the multi stream displayport pin widget but different device entry while only one audio output can be dynamically allocated to other HDMI pin widget[Libin] Yes, Pin widget can have multiple device entry and connecting different converters. The audio output will be based on device entry.
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/4 drm/i915: set proper N/CTS in modeset
In reply to [email protected]From: Libin Yang <[email protected]>
When modeset occurs and the TMDS frequency is set to some speical value, the N/CTS need to be set manually if audio is playing.
--- drivers/gpu/drm/i915/i915_reg.h | 6 ++++++ drivers/gpu/drm/i915/intel_audio.c | 42 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +6 -0
@@ -7026,6 +7026,12 @@ enum skl_disp_power_wells { _HSW_AUD_DIG_CNVT_2)#define DIP_PORT_SEL_MASK 0x3 +#define _HSW_AUD_STR_DESC_1 0x65084 +#define _HSW_AUD_STR_DESC_2 0x65184 +#define AUD_STR_DESC (pipe) _PIPE(pipe, \ + _HSW_AUD_STR_DESC_1, \ + _HSW_AUD_STR_DESC_2) +#define _HSW_AUD_EDID_DATA_A 0x65050#define _HSW_AUD_EDID_DATA_B 0x65150#define HSW_AUD_EDID_DATA (pipe) _PIPE(pipe, \
drivers/gpu/drm/i915/intel_audio.c +42 -0
60 lines not on this page · raw message
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx