Staging: lustre: obdclass: Use kasprintf instead of kzalloc and sprintf
PATCH 1/1 Staging: lustre: obdclass: Use kasprintf instead of kzalloc and sprintf
This patch uses kasprintf which combines kzalloc and sprintf.
kasprintf also takes care of the size calculation.
Semantic patch used is as follows:
@@
expression a,flag;
expression list args;
statement S;
@@
a =
- \(kmalloc\|kzalloc\)(...,flag)
+ kasprintf (flag,args)
<... when != a
if (a == NULL || ...) S
...>
- sprintf(a,args);
Signed-off-by Shraddha Barke <[email protected]>
--- drivers/staging/lustre/lustre/obdclass/obd_config.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/staging/lustre/lustre/obdclass/obd_config.c +3 -4
@@ -1455,14 +1455,13 @@ int class_config_llog_handler(const struct lu_env *env, inst =1 ; inst_len =LUSTRE_CFG_BUFLEN (lcfg,0 ) +sizeof (clli->cfg_instance) *2 +4 ; - inst_name =kzalloc (inst_len,GFP_NOFS ); + inst_name =kasprintf (GFP_NOFS ,"%s-%p" , +lustre_cfg_string (lcfg,0 ), + clli->cfg_instance);if (!inst_name) { rc = -ENOMEM ; goto out; } -sprintf (inst_name,"%s-%p" , -lustre_cfg_string (lcfg,0 ), - clli->cfg_instance);lustre_cfg_bufs_set_string (&bufs,0 , inst_name);CDEBUG (D_CONFIG ,"cmd %x, instance name: %s\n" , lcfg->lcfg_command, inst_name);
Signature · 1 line
2.1.0