Patch "cxl: Check if afu is not null in cxl_slbia" has been added to the 4.1-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
cxl: Check if afu is not null in cxl_slbia
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
cxl-check-if-afu-is-not-null-in-cxl_slbia.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
2c069a118fe1d80c47dca84e1561045fc7f3cc9eMon Sep 17 00:00:00 2001
From: Daniel Axtens <[email protected]>
Date: Fri, 10 Jul 2015 09:04:25 +1000
Subject: cxl: Check if afu is not null in cxl_slbia
From: Daniel Axtens <[email protected]>
commit 2c069a118fe1d80c47dca84e1561045fc7f3cc9e upstream.
The pointer to an AFU in the adapter's list of AFUs can be null if we're in the process of removing AFUs. The afu_list_lock doesn't guard against this.
Say we have 2 slices, and we're in the process of removing cxl.
- We remove the AFUs in order (see cxl_remove). In cxl_remove_afu for AFU 0, we take the lock, set adapter->afu[0] = NULL, and release the lock.
- Then we get an slbia. In cxl_slbia we take the lock, and set afu = adapter->afu[0], which is NULL.
- Therefore our attempt to check afu->enabled will blow up.
Therefore, check if afu is a null pointer before dereferencing it.
--- drivers/misc/cxl/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/cxl/main.c +1 -1
@@ -73,7 +73,7 @@ static inline void cxl_slbia_core(structspin_lock (&adapter->afu_list_lock);for (slice =0 ; slice < adapter->slices; slice++) { afu = adapter->afu[slice]; -if (!afu->enabled) +if (!afu || !afu->enabled)continue ;rcu_read_lock ();idr_for_each_entry (&afu->contexts_idr, ctx, id)
Patches currently in stable-queue which might be from [email protected] are
queue-4.1/cxl-check-if-afu-is-not-null-in-cxl_slbia.patch