Skip to contentSkip to conversation

regulator: core: Drop regulator_list_mutex when we're done with it on remove

PATCH New Mark Brown 1 participant 1 message Aug 7, 2015 Voltage and current regulator framework

lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

PATCH 1/1 regulator: core: Drop regulator_list_mutex when we're done with it on remove

When removing a regulator we hold regulator_list_mutex in order to ensure the regualtor doesn't become removed again. However we only need to protect the list until we remove the regulator from the list so move the unlock earlier to reduce the locked region.

---
 drivers/regulator/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/regulator/core.c +1 -1
index 6130346..b127373 100644
@@ -3847,11 +3847,11 @@ void regulator_unregister(struct regulator_dev *rdev)
 	WARN_ON(rdev->open_count);
 	unset_regulator_supplies(rdev);
 	list_del(&rdev->list);
+	mutex_unlock(&regulator_list_mutex);
 	kfree(rdev->constraints);
 	regulator_ena_gpio_free(rdev);
 	of_node_put(rdev->dev.of_node);
 	device_unregister(&rdev->dev);
-	mutex_unlock(&regulator_list_mutex);
 }
 EXPORT_SYMBOL_GPL(regulator_unregister);
 
Signature · 1 line
2.5.0