Skip to contentSkip to conversation

Patch "IB/ipoib: Fix CONFIG_INFINIBAND_IPOIB_CM" has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Aug 8, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

IB/ipoib: Fix CONFIG_INFINIBAND_IPOIB_CM

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ib-ipoib-fix-config_infiniband_ipoib_cm.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From efc1eedbf63a194b3b576fc25776f3f1fa55a4d4 Mon Sep 17 00:00:00 2001

From: Jason Gunthorpe <[email protected]>
Date: Wed, 22 Jul 2015 14:30:03 -0600
Subject: IB/ipoib: Fix CONFIG_INFINIBAND_IPOIB_CM

From: Jason Gunthorpe <[email protected]>

commit efc1eedbf63a194b3b576fc25776f3f1fa55a4d4 upstream.

If the above is turned off then ipoib_cm_dev_init unconditionally returns ENOSYS, and the newly added error handling in 0b3957 prevents ipoib from coming up at all:

kernel: mlx4_0: ipoib_transport_dev_init failed
kernel: mlx4_0: failed to initialize port 1 (ret = -12)

Fixes 0b39578bcde4 (IB/ipoib: Use dedicated workqueues per interface)
---
 drivers/infiniband/ulp/ipoib/ipoib_verbs.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/infiniband/ulp/ipoib/ipoib_verbs.c +2 -1
@@ -176,7 +176,8 @@ int ipoib_transport_dev_init(struct net_
 		else
 			size += ipoib_recvq_size * ipoib_max_conn_qp;
 	} else
-		goto out_free_wq;
+		if (ret != -ENOSYS)
+			goto out_free_wq;
 
 	priv->recv_cq = ib_create_cq(priv->ca, ipoib_ib_completion, NULL, dev, size, 0);
 	if (IS_ERR(priv->recv_cq)) {

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/ib-ipoib-fix-config_infiniband_ipoib_cm.patch