Skip to contentSkip to conversation

Patch "NFSv4: We must set NFS_OPEN_STATE flag in nfs_resync_open_stateid_locked" has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Aug 8, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

NFSv4: We must set NFS_OPEN_STATE flag in nfs_resync_open_stateid_locked

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
nfsv4-we-must-set-nfs_open_state-flag-in-nfs_resync_open_stateid_locked.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 3c38cbe2ade88240fabb585b408f779ad3b9a31b Mon Sep 17 00:00:00 2001

From: Trond Myklebust <[email protected]>
Date: Wed, 22 Jul 2015 13:46:13 -0400
Subject: NFSv4: We must set NFS_OPEN_STATE flag in nfs_resync_open_stateid_locked

From: Trond Myklebust <[email protected]>

commit 3c38cbe2ade88240fabb585b408f779ad3b9a31b upstream.

Otherwise, nfs4_select_rw_stateid() will always return the zero stateid instead of the correct open stateid.

Fixes f95549cf24660 ("NFSv4: More CLOSE/OPEN races")
---
 fs/nfs/nfs4proc.c |    3 +++
 1 file changed, 3 insertions(+)
fs/nfs/nfs4proc.c +3 -0
@@ -1204,12 +1204,15 @@ static bool nfs_need_update_open_stateid
 
 static void nfs_resync_open_stateid_locked(struct nfs4_state *state)
 {
+	if (!(state->n_wronly || state->n_rdonly || state->n_rdwr))
+		return;
 	if (state->n_wronly)
 		set_bit(NFS_O_WRONLY_STATE, &state->flags);
 	if (state->n_rdonly)
 		set_bit(NFS_O_RDONLY_STATE, &state->flags);
 	if (state->n_rdwr)
 		set_bit(NFS_O_RDWR_STATE, &state->flags);
+	set_bit(NFS_OPEN_STATE, &state->flags);
 }
 
 static void nfs_clear_open_stateid_locked(struct nfs4_state *state,

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/nfsv4-we-must-set-nfs_open_state-flag-in-nfs_resync_open_stateid_locked.patch queue-4.1/nfs-fix-a-memory-leak-in-nfs_do_recoalesce.patch queue-4.1/nfs-don-t-revalidate-the-mapping-if-both-size-and-change-attr-are-up-to-date.patch