Patch "qla2xxx: Remove msleep in qlt_send_term_exchange" has been added to the 4.1-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
qla2xxx: Remove msleep in qlt_send_term_exchange
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
qla2xxx-remove-msleep-in-qlt_send_term_exchange.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
6bc85dd595a5438b50ec085668e53ef26058bb90Mon Sep 17 00:00:00 2001
From: Himanshu Madhani <[email protected]>
Date: Wed, 10 Jun 2015 11:05:22 -0400
Subject: qla2xxx: Remove msleep in qlt_send_term_exchange
From: Himanshu Madhani <[email protected]>
commit 6bc85dd595a5438b50ec085668e53ef26058bb90 upstream.
Remove unnecessary msleep from qlt_send_term_exchange as it adds latency of 250 msec while sending terminate exchange to an aborted task.
--- drivers/scsi/qla2xxx/qla_target.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-)
drivers/scsi/qla2xxx/qla_target.c +7 -6
@@ -2715,7 +2715,7 @@ static int __qlt_send_term_exchange(strustatic void qlt_send_term_exchange (struct scsi_qla_host *vha,struct qla_tgt_cmd *cmd,struct atio_from_isp *atio,int ha_locked) { -unsigned long flags; +unsigned long flags =0 ;int rc;if (qlt_issue_marker (vha, ha_locked) <0 )
@@ -2731,17 +2731,18 @@ static void qlt_send_term_exchange(struc rc =__qlt_send_term_exchange (vha, cmd, atio);if (rc == -ENOMEM )qlt_alloc_qfull_cmd (vha, atio,0 ,0 ); -spin_unlock_irqrestore (&vha->hw->hardware_lock, flags); done:if (cmd && ((cmd->state !=QLA_TGT_STATE_ABORTED ) || !cmd->cmd_sent_to_fw)) { -if (!ha_locked && !in_interrupt ()) -msleep (250 );/* just in case */ - -qlt_unmap_sg (vha, cmd); +if (cmd->sg_mapped) +qlt_unmap_sg (vha, cmd); vha->hw->tgt.tgt_ops->free_cmd (cmd); } + +if (!ha_locked) +spin_unlock_irqrestore (&vha->hw->hardware_lock, flags); +return ; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.1/qla2xxx-release-request-queue-reservation.patch queue-4.1/qla2xxx-fix-command-initialization-in-target-mode.patch queue-4.1/qla2xxx-fix-hardware-lock-unlock-issue-causing-kernel-panic.patch queue-4.1/qla2xxx-remove-msleep-in-qlt_send_term_exchange.patch queue-4.1/qla2xxx-kill-sessions-log-out-initiator-on-rscn-and-port-down-events.patch