runqemu: Add error handling for unexpected tap devices

In theory the code reduces the tap device number to an integer. This patch adds error checking to ensure that does happen and that the script exits if something unexpected happens.

index 03b40d8..0ace485 100755
@@ -253,6 +253,14 @@ else
 
 
         n0=$(echo $TAP | sed 's/tap//')
+
+        case $n0 in
+            ''|*[!0-9]*)
+                echo "Error Couldn't turn $TAP into an interface number?"
+                exit 1
+                ;;
+        esac
+
         n1=$(($n0 * 2 + 1))
         n2=$(($n1 + 1))
 

I see these patches are already on master. Are you sending them again by mistake for review or something else ?

Sorry, I've hit the wrong commands. The plan was to queue them for a fast turnaround into master once the current build completed and they'd spent some time on the list for review. It looks like I pushed them early :/.

The good news is that with these patches, one of the "random" issues we've been seeing is fixed and we might be able to start trusting the autobuilder a bit more again. There are still other issues but this is perhaps the one with the most visible impact.

It does look like we're going to need an M2 rc2 once we figure out the libpam issues so I'm going to hold off the various queued upgrades until we figure out a good rc2 build combination of changes.

Cheers,

Richard