Skip to contentSkip to conversation

f2fs:Fix error handling in the function recover_inline_data

PATCH Superseded Nicholas Krause 1 participant 1 message Aug 9, 2015 F2FS file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 f2fs:Fix error handling in the function recover_inline_data

This fixes error handling in the function recover_inline_data to check if the function call to truncate_inline_inode has failed by returning false and if so return immediately to the caller of recover_inline_data by returning false to signal a internal failure had occurred when calling this particular function.

---
 fs/f2fs/inline.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
fs/f2fs/inline.c +2 -1
index a13ffcc..e237c44 100644
@@ -274,7 +274,8 @@ process_inline:
 	if (f2fs_has_inline_data(inode)) {
 		ipage = get_node_page(sbi, inode->i_ino);
 		f2fs_bug_on(sbi, IS_ERR(ipage));
-		truncate_inline_inode(ipage, 0);
+		if (!truncate_inline_inode(ipage, 0))
+			return false;
 		f2fs_clear_inline_inode(inode);
 		update_inode(inode, ipage);
 		f2fs_put_page(ipage, 1);
Signature · 4 lines
2.1.4


------------------------------------------------------------------------------