extcon: add index increment in find_cable_index_by_name
PATCH 1/1 extcon: add index increment in find_cable_index_by_name
This fixes a bug introduced by commit 73b6ecdb93e8 ("extcon: Redefine the unique id of supported external connectors without 'enum extcon' type") which introduced an infinite loop in find_cable_index_by_name. That commit converted the scan from a for loop to a while, but did not increment 'i' anywhere in the loop. If the loop index is not incremented, the function never exits.
This function can never work correctly without this fix.
--- drivers/extcon/extcon.c | 1 + 1 file changed, 1 insertion(+)
drivers/extcon/extcon.c +1 -0
@@ -138,6 +138,7 @@ static int find_cable_index_by_name(struct extcon_dev *edev, const char *name) id = i;break ; } + i++; }if (id ==EXTCON_NONE )
Signature · 1 line
1.8.2.2
Never mind...
This is already fixed by commit be052cc8 in mainline.
Sorry for the noise.
-- Tim
Quoted 27 lines · Tim Bird
This fixes a bug introduced by commit
73b6ecdb93e8("extcon: Redefine the unique id of supported external connectors without 'enum extcon' type") which introduced an infinite loop infind_cable_index_by_name. That commit converted the scan from a for loop to a while, but did not increment 'i' anywhere in the loop. If the loop index is not incremented, the function never exits.This function can never work correctly without this fix.
Signed-off-by Tim Bird <[email protected]>--- drivers/extcon/extcon.c | 1 + 1 file changed, 1 insertion(+)drivers/extcon/extcon.c +1
-0@@ -138,6 +138,7 @@ static int find_cable_index_by_name(struct extcon_dev *edev, const char *name) id = i;break ; } + i++; }if (id ==EXTCON_NONE )