extcon: fix signedness issues
PATCH 1/1 extcon: fix signedness issues
commit be052cc87745 ("extcon: Fix hang and extcon_get/set_cable_state().") introduced several signedness issues. sparse reports them:
drivers/extcon/extcon.c: In function ‘find_cable_index_by_name’:
drivers/extcon/extcon.c:153:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] drivers/extcon/extcon.c: In function ‘extcon_get_cable_state’:
drivers/extcon/extcon.c:384:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] drivers/extcon/extcon.c: In function ‘extcon_set_cable_state’:
drivers/extcon/extcon.c:432:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
---
This is *only* compile-tested
drivers/extcon/extcon.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/extcon/extcon.c +4 -4
@@ -126,7 +126,7 @@ static int find_cable_index_by_id(struct extcon_dev *edev, const unsigned int idstatic int find_cable_id_by_name (struct extcon_dev *edev,const char *name) { -unsigned int id = -EINVAL ; +int id = -EINVAL ;int i =0 ;/* Find the id of extcon cable */
@@ -143,7 +143,7 @@ static int find_cable_id_by_name(struct extcon_dev *edev, const char *name)static int find_cable_index_by_name (struct extcon_dev *edev,const char *name) { -unsigned int id; +int id;if (edev->max_supported ==0 )return -EINVAL ;
@@ -378,7 +378,7 @@ EXPORT_SYMBOL_GPL(extcon_get_cable_state_);*/ int extcon_get_cable_state (struct extcon_dev *edev,const char *cable_name) { -unsigned int id; +int id; id =find_cable_id_by_name (edev, cable_name);if (id <0 )
@@ -426,7 +426,7 @@ EXPORT_SYMBOL_GPL(extcon_set_cable_state_);int extcon_set_cable_state (struct extcon_dev *edev,const char *cable_name,bool cable_state) { -unsigned int id; +int id; id =find_cable_id_by_name (edev, cable_name);if (id <0 )
Signature · 1 line
2.5.0.rc2.392.g76e840b
Chanwoo Choi
maintainerHi Brian,
I knew this issue. So patch[1] fixed it already.
I sent the extcon pull request[2] including patch[1] for Linux 4.3.
[1] http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=a598af7f0279195abffbfb9bf2070457e9c89ff3
[2] https://lkml.org/lkml/2015/8/11/5
Thanks,
Chanwoo Choi
Quoted 60 lines · Brian Norris
commit
be052cc87745("extcon: Fix hang and extcon_get/set_cable_state().") introduced several signedness issues. sparse reports them:
drivers/extcon/extcon.c: In function ‘find_cable_index_by_name’:
drivers/extcon/extcon.c:153:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]drivers/extcon/extcon.c: In function ‘extcon_get_cable_state’:
drivers/extcon/extcon.c:384:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]drivers/extcon/extcon.c: In function ‘extcon_set_cable_state’:
drivers/extcon/extcon.c:432:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]Fixes be052cc87745 ("extcon: Fix hang and extcon_get/set_cable_state().")Signed-off-by Brian Norris <[email protected]>---
This is *only* compile-testeddrivers/extcon/extcon.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/extcon/extcon.c +4
-4@@ -126,7 +126,7 @@ static int find_cable_index_by_id(struct extcon_dev *edev, const unsigned int idstatic int find_cable_id_by_name (struct extcon_dev *edev,const char *name) { -unsigned int id = -EINVAL ; +int id = -EINVAL ;int i =0 ;/* Find the id of extcon cable */ @@ -143,7 +143,7 @@ static int find_cable_id_by_name(struct extcon_dev *edev, const char *name)static int find_cable_index_by_name (struct extcon_dev *edev,const char *name) { -unsigned int id; +int id;if (edev->max_supported ==0 )return -EINVAL ;@@ -378,7 +378,7 @@ EXPORT_SYMBOL_GPL(extcon_get_cable_state_);*/ int extcon_get_cable_state (struct extcon_dev *edev,const char *cable_name) { -unsigned int id; +int id; id =find_cable_id_by_name (edev, cable_name);if (id <0 )@@ -426,7 +426,7 @@ EXPORT_SYMBOL_GPL(extcon_set_cable_state_);int extcon_set_cable_state (struct extcon_dev *edev,const char *cable_name,bool cable_state) { -unsigned int id; +int id; id =find_cable_id_by_name (edev, cable_name);if (id <0 )
Quoted 1 line · Chanwoo Choi
I knew this issue. So patch[1] fixed it already.
Awesome.
FWIW, my Google-fu fails to find this patch on any mail archive; just your pull request.
Quoted 4 lines
I sent the extcon pull request[2] including patch[1] for Linux 4.3.
[1] http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=a598af7f0279195abffbfb9bf2070457e9c89ff3
[2] https://lkml.org/lkml/2015/8/11/5
Regards,
Brian
Chanwoo Choi
maintainerHi Brian,
Quoted 7 lines · Brian Norris
Quoted 1 line · Chanwoo Choi
I knew this issue. So patch[1] fixed it already.
Awesome.
FWIW, my Google-fu fails to find this patch on any mail archive; just your pull request.
You can check it on patch[3]. As I add commit message of patch[1], I modified the patch title.
[3] https://lkml.org/lkml/2015/8/4/89
Thanks,
Chanwoo Choi
Quoted 9 lines
Quoted 5 lines
I sent the extcon pull request[2] including patch[1] for Linux 4.3.
[1] http://git.kernel.org/cgit/linux/kernel/git/chanwoo/extcon.git/commit/?h=extcon-next&id=a598af7f0279195abffbfb9bf2070457e9c89ff3
[2] https://lkml.org/lkml/2015/8/11/5Regards,
Brian