Skip to contentSkip to conversation

minidlna: fix static linking

PATCH New Waldemar Brodkorb 3 participants 4 messages Aug 12, 2015

lore
Share & tools
lore

Waldemar Brodkorb

author
#0 lore raw

PATCH 1/1 minidlna: fix static linking

As libid3tag uses compress, -lz must be linked in, as no pkconfig file exist. The name of the vorbis pkgconfig file is vorbis.pc.
We also need to add sqlite in pkgconfig call.

This fixes following autobuilder compile error:
http://autobuild.buildroot.net/results/f538ad6673b711492acd727d623d0cc2de626f16/

Signed-off-by Waldemar Brodkorb <[email protected]>
---
 package/minidlna/minidlna.mk |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/minidlna/minidlna.mk +2 -1
index ab93484..385c8df 100644
@@ -17,8 +17,9 @@ MINIDLNA_DEPENDENCIES = \
 ifeq ($(BR2_STATIC_LIBS),y)
 # the configure script / Makefile forgets to link with some of the dependent
 # libraries breaking static linking, so help it along
-MINIDLNA_STATIC_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libavcodec libexif libvorbis`
+MINIDLNA_STATIC_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libavcodec libexif vorbis sqlite3`
 MINIDLNA_STATIC_LIBS += $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),-lintl)
+MINIDLNA_STATIC_LIBS += -lz
 MINIDLNA_CONF_ENV += LIBS="$(MINIDLNA_STATIC_LIBS)"
 else
 MINIDLNA_CONF_OPTS = \
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 minidlna: fix static linking

Dear Waldemar,

Quoted 23 lines · Waldemar Brodkorb

As libid3tag uses compress, -lz must be linked in, as no pkconfig file exist.
The name of the vorbis pkgconfig file is vorbis.pc.
We also need to add sqlite in pkgconfig call.

This fixes following autobuilder compile error:
http://autobuild.buildroot.net/results/f538ad6673b711492acd727d623d0c
c2de626f16/

Signed-off-by Waldemar Brodkorb <[email protected]>
---
 package/minidlna/minidlna.mk |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/minidlna/minidlna.mk +0 -0
index ab93484..385c8df 100644
@@ -17,8 +17,9 @@ MINIDLNA_DEPENDENCIES = \
 ifeq ($(BR2_STATIC_LIBS),y)
 # the configure script / Makefile forgets to link with some of the

dependent

Quoted 10 lines
 # libraries breaking static linking, so help it along
-MINIDLNA_STATIC_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libavcodec
libexif libvorbis`
+MINIDLNA_STATIC_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libavcodec
libexif vorbis sqlite3`
 MINIDLNA_STATIC_LIBS += $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),-lintl)
+MINIDLNA_STATIC_LIBS += -lz
 MINIDLNA_CONF_ENV += LIBS="$(MINIDLNA_STATIC_LIBS)"
 else
 MINIDLNA_CONF_OPTS = \

This is an almost identical patch to what Bernd Kuhls sent two weeks ago [1]. Are there any updates for this patch?

Best regards
J?rg Krause

[1] http://patchwork.ozlabs.org/patch/501844/

author
#2 lore raw

PATCH 1/1 minidlna: fix static linking

Hi,
Joerg Krause wrote,

Quoted 3 lines

This is an almost identical patch to what Bernd Kuhls sent two weeks ago [1]. Are there any updates for this patch?

Sorry for the noise. I need to take a look @pachwork next time I try to fix any autobuilder issues :)

best regards
Waldemar

#3 lore raw

PATCH 1/1 minidlna: fix static linking

In reply to Jörg Krause

Dear J?rg Krause,

Quoted 7 lines · J?rg Krause

This is an almost identical patch to what Bernd Kuhls sent two weeks ago [1]. Are there any updates for this patch?

Best regards
J?rg Krause

[1] http://patchwork.ozlabs.org/patch/501844/

If you read this link, I said:

"""
Would it be possible to stop hacking this to death? What about instead taking the saner approach of switching minidlna configure.ac to use PKG_CHECK_MODULES(), which will remove a lot of crap from it, and make it work properly for cross-compilation.
"""

and I've got no further comment. So my comment still stands.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com