Skip to contentSkip to conversation

rnndb/dsi: Add more bits for DSI PHY

PATCH In review Hai Li 4 participants 6 messages Aug 13, 2015 – Aug 24, 2015 Arm Qualcomm mailing list

lore
Share & tools
lore

Hai Li

author
#0 lore raw

PATCH 1/1 rnndb/dsi: Add more bits for DSI PHY

More registers and bit fields are added for PHY timings and bitclk source selection.

---
 rnndb/dsi/dsi.xml | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
rnndb/dsi/dsi.xml +9 -2
index 02cfa3b..956f3ff 100644
@@ -217,6 +217,9 @@ xsi:schemaLocation="http://nouveau.freedesktop.org/ rules-ng.xsd">
 	<reg32 offset="0x00128" name="PHY_RESET">
 		<bitfield name="RESET" pos="0" type="boolean"/>
 	</reg32>
+	<reg32 offset="0x0017c" name="T_CLK_PRE_EXTEND">
+		<bitfield name="INC_BY_2_BYTECLK" pos="0" type="boolean"/>
+	</reg32>
 	<reg32 offset="0x001d0" name="RDBK_DATA_CTRL">
 		<bitfield name="COUNT" low="16" high="23" type="uint"/>
 		<bitfield name="CLR" pos="0" type="boolean"/>
@@ -437,7 +440,9 @@ xsi:schemaLocation="http://nouveau.freedesktop.org/ rules-ng.xsd">
 	<reg32 offset="0x001c4" name="BIST_CTRL_4"/>
 	<reg32 offset="0x001c8" name="BIST_CTRL_5"/>
 
-	<reg32 offset="0x001d4" name="GLBL_TEST_CTRL"/>
+	<reg32 offset="0x001d4" name="GLBL_TEST_CTRL">
+		<bitfield name="BITCLK_HS_SEL" pos="0" type="boolean"/>
+	</reg32>
 	<reg32 offset="0x001dc" name="LDO_CNTRL"/>
 </domain>
 
@@ -608,7 +613,9 @@ xsi:schemaLocation="http://nouveau.freedesktop.org/ rules-ng.xsd">
 	<reg32 offset="0x001c4" name="BIST_CTRL_4"/>
 	<reg32 offset="0x001c8" name="BIST_CTRL_5"/>
 
-	<reg32 offset="0x001d4" name="GLBL_TEST_CTRL"/>
+	<reg32 offset="0x001d4" name="GLBL_TEST_CTRL">
+		<bitfield name="BITCLK_HS_SEL" pos="0" type="boolean"/>
+	</reg32>
 	<reg32 offset="0x001dc" name="LDO_CNTRL"/>
 </domain>
 
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
#1 lore raw

Hi Hai,

I don't know what those bits are used for, but I'm a bit curious about how did you find them?

Also, the next time don't forget to send patches related to envytools to [email protected] (or better send a pull request from github).

Thanks.

Quoted 34 lines · Hai Li

More registers and bit fields are added for PHY timings and bitclk source selection.

---
  rnndb/dsi/dsi.xml | 11 +++++++++--
  1 file changed, 9 insertions(+), 2 deletions(-)
rnndb/dsi/dsi.xml +6 -1
index 02cfa3b..956f3ff 100644
@@ -217,6 +217,9 @@ xsi:schemaLocation="http://nouveau.freedesktop.org/ rules-ng.xsd">
  	<reg32 offset="0x00128" name="PHY_RESET">
  		<bitfield name="RESET" pos="0" type="boolean"/>
  	</reg32>
+	<reg32 offset="0x0017c" name="T_CLK_PRE_EXTEND">
+		<bitfield name="INC_BY_2_BYTECLK" pos="0" type="boolean"/>
+	</reg32>
  	<reg32 offset="0x001d0" name="RDBK_DATA_CTRL">
  		<bitfield name="COUNT" low="16" high="23" type="uint"/>
  		<bitfield name="CLR" pos="0" type="boolean"/>
@@ -437,7 +440,9 @@ xsi:schemaLocation="http://nouveau.freedesktop.org/ rules-ng.xsd">
  	<reg32 offset="0x001c4" name="BIST_CTRL_4"/>
  	<reg32 offset="0x001c8" name="BIST_CTRL_5"/>
 
-	<reg32 offset="0x001d4" name="GLBL_TEST_CTRL"/>
+	<reg32 offset="0x001d4" name="GLBL_TEST_CTRL">
+		<bitfield name="BITCLK_HS_SEL" pos="0" type="boolean"/>
+	</reg32>
  	<reg32 offset="0x001dc" name="LDO_CNTRL"/>
  </domain>
 

rnndb/dsi/dsi.xml xsi:schemaLocation="http://nouveau.freedesktop.org/ rules-ng.xsd"> · line 621

Quoted 10 lines
rnndb/dsi/dsi.xml +3 -1
@@ -608,7 +613,9 @@ xsi:schemaLocation="http://nouveau.freedesktop.org/ rules-ng.xsd">
  	<reg32 offset="0x001c4" name="BIST_CTRL_4"/>
  	<reg32 offset="0x001c8" name="BIST_CTRL_5"/>
 
-	<reg32 offset="0x001d4" name="GLBL_TEST_CTRL"/>
+	<reg32 offset="0x001d4" name="GLBL_TEST_CTRL">
+		<bitfield name="BITCLK_HS_SEL" pos="0" type="boolean"/>
+	</reg32>
  	<reg32 offset="0x001dc" name="LDO_CNTRL"/>
  </domain>
 

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw
Quoted 8 lines · Samuel Pitoiset

Hi Hai,

I don't know what those bits are used for, but I'm a bit curious about how did you find them?

Also, the next time don't forget to send patches related to envytools to [email protected]
(or better send a pull request from github).

fwiw, those are actually for freedreno envytools ;-)

(although I suppose at some point we should maybe try to get it all back into a single repo..)

BR,
-R

Quoted 47 lines

Thanks.

Quoted 43 lines · Hai Li

More registers and bit fields are added for PHY timings and bitclk source selection.

---
  rnndb/dsi/dsi.xml | 11 +++++++++--
  1 file changed, 9 insertions(+), 2 deletions(-)
rnndb/dsi/dsi.xml +0 -0
index 02cfa3b..956f3ff 100644
@@ -217,6 +217,9 @@ xsi:schemaLocation="http://nouveau.freedesktop.org/

rules-ng.xsd">

        <reg32 offset="0x00128" name="PHY_RESET">
                <bitfield name="RESET" pos="0" type="boolean"/>
        </reg32>
rnndb/dsi/dsi.xml +3 -0
+       <reg32 offset="0x0017c" name="T_CLK_PRE_EXTEND">
+               <bitfield name="INC_BY_2_BYTECLK" pos="0" type="boolean"/>
+       </reg32>
        <reg32 offset="0x001d0" name="RDBK_DATA_CTRL">
                <bitfield name="COUNT" low="16" high="23" type="uint"/>
                <bitfield name="CLR" pos="0" type="boolean"/>
@@ -437,7 +440,9 @@ xsi:schemaLocation="http://nouveau.freedesktop.org/

rules-ng.xsd">

        <reg32 offset="0x001c4" name="BIST_CTRL_4"/>
        <reg32 offset="0x001c8" name="BIST_CTRL_5"/>

- <reg32 offset="0x001d4" name="GLBL_TEST_CTRL"/>

rnndb/dsi/dsi.xml +3 -0
+       <reg32 offset="0x001d4" name="GLBL_TEST_CTRL">
+               <bitfield name="BITCLK_HS_SEL" pos="0" type="boolean"/>
+       </reg32>
        <reg32 offset="0x001dc" name="LDO_CNTRL"/>
  </domain>
  @@ -608,7 +613,9 @@ xsi:schemaLocation="http://nouveau.freedesktop.org/

rules-ng.xsd">

        <reg32 offset="0x001c4" name="BIST_CTRL_4"/>
        <reg32 offset="0x001c8" name="BIST_CTRL_5"/>

- <reg32 offset="0x001d4" name="GLBL_TEST_CTRL"/>

rnndb/dsi/dsi.xml +3 -0
+       <reg32 offset="0x001d4" name="GLBL_TEST_CTRL">
+               <bitfield name="BITCLK_HS_SEL" pos="0" type="boolean"/>
+       </reg32>
        <reg32 offset="0x001dc" name="LDO_CNTRL"/>
Quoted 8 lines
Quoted 2 lines

</domain>

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#3 lore raw
Quoted 11 lines · Rob Clark
Quoted 8 lines · Samuel Pitoiset

Hi Hai,

I don't know what those bits are used for, but I'm a bit curious about how did you find them?

Also, the next time don't forget to send patches related to envytools to [email protected]
(or better send a pull request from github).

fwiw, those are actually for freedreno envytools ;-)

Oh really? I have never heard about an envytools for freedreno! :)

Quoted 60 lines

(although I suppose at some point we should maybe try to get it all back into a single repo..)

BR,
-R

Quoted 53 lines

Thanks.

Quoted 39 lines · Hai Li

More registers and bit fields are added for PHY timings and bitclk source selection.

---
   rnndb/dsi/dsi.xml | 11 +++++++++--
   1 file changed, 9 insertions(+), 2 deletions(-)
rnndb/dsi/dsi.xml +0 -0
index 02cfa3b..956f3ff 100644
@@ -217,6 +217,9 @@ xsi:schemaLocation="http://nouveau.freedesktop.org/

rules-ng.xsd">

         <reg32 offset="0x00128" name="PHY_RESET">
                 <bitfield name="RESET" pos="0" type="boolean"/>
         </reg32>
rnndb/dsi/dsi.xml +3 -0
+       <reg32 offset="0x0017c" name="T_CLK_PRE_EXTEND">
+               <bitfield name="INC_BY_2_BYTECLK" pos="0" type="boolean"/>
+       </reg32>
         <reg32 offset="0x001d0" name="RDBK_DATA_CTRL">
                 <bitfield name="COUNT" low="16" high="23" type="uint"/>
                 <bitfield name="CLR" pos="0" type="boolean"/>
@@ -437,7 +440,9 @@ xsi:schemaLocation="http://nouveau.freedesktop.org/

rules-ng.xsd">

         <reg32 offset="0x001c4" name="BIST_CTRL_4"/>
         <reg32 offset="0x001c8" name="BIST_CTRL_5"/>

- <reg32 offset="0x001d4" name="GLBL_TEST_CTRL"/>

rnndb/dsi/dsi.xml +3 -0
+       <reg32 offset="0x001d4" name="GLBL_TEST_CTRL">
+               <bitfield name="BITCLK_HS_SEL" pos="0" type="boolean"/>
+       </reg32>
         <reg32 offset="0x001dc" name="LDO_CNTRL"/>
   </domain>
   @@ -608,7 +613,9 @@ xsi:schemaLocation="http://nouveau.freedesktop.org/

rules-ng.xsd">

         <reg32 offset="0x001c4" name="BIST_CTRL_4"/>
         <reg32 offset="0x001c8" name="BIST_CTRL_5"/>

- <reg32 offset="0x001d4" name="GLBL_TEST_CTRL"/>

rnndb/dsi/dsi.xml xsi:schemaLocation="http://nouveau.freedesktop.org/ rules-ng.xsd"> · line 447

Quoted 5 lines
rnndb/dsi/dsi.xml +3 -0
+       <reg32 offset="0x001d4" name="GLBL_TEST_CTRL">
+               <bitfield name="BITCLK_HS_SEL" pos="0" type="boolean"/>
+       </reg32>
         <reg32 offset="0x001dc" name="LDO_CNTRL"/>
   </domain>

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw
Quoted 10 lines · Samuel Pitoiset
Quoted 9 lines · Rob Clark
Quoted 7 lines · Samuel Pitoiset

Hi Hai,

I don't know what those bits are used for, but I'm a bit curious about how
did you find them?

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

Also, the next time don't forget to send patches related to envytools to [email protected]
(or better send a pull request from github).

fwiw, those are actually for freedreno envytools ;-)

Oh really? I have never heard about an envytools for freedreno! :)

Should be cueseetools or something :)

-ilia
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#5 lore raw
In reply to Samuel Pitoiset
Quoted 13 lines · Samuel Pitoiset
Quoted 10 lines · Rob Clark
Quoted 7 lines · Samuel Pitoiset

Hi Hai,

I don't know what those bits are used for, but I'm a bit curious about how
did you find them?

Quoted 9 lines
Quoted 5 lines
Quoted 3 lines

Also, the next time don't forget to send patches related to envytools to [email protected]
(or better send a pull request from github).

fwiw, those are actually for freedreno envytools ;-)

Oh really? I have never heard about an envytools for freedreno! :)

yup... fwiw, etnaviv and I think ilo also use envytools

BR,
-R

Quoted 56 lines
Quoted 56 lines

(although I suppose at some point we should maybe try to get it all back into a single repo..)

BR,
-R

Quoted 48 lines

Thanks.

Quoted 44 lines · Hai Li

More registers and bit fields are added for PHY timings and bitclk source selection.

---
   rnndb/dsi/dsi.xml | 11 +++++++++--
   1 file changed, 9 insertions(+), 2 deletions(-)
rnndb/dsi/dsi.xml +0 -0
index 02cfa3b..956f3ff 100644
@@ -217,6 +217,9 @@ xsi:schemaLocation="http://nouveau.freedesktop.org/

rules-ng.xsd">

         <reg32 offset="0x00128" name="PHY_RESET">
                 <bitfield name="RESET" pos="0" type="boolean"/>
         </reg32>
rnndb/dsi/dsi.xml +2 -0
+       <reg32 offset="0x0017c" name="T_CLK_PRE_EXTEND">
+               <bitfield name="INC_BY_2_BYTECLK" pos="0"

type="boolean"/>

rnndb/dsi/dsi.xml +1 -0
+       </reg32>
         <reg32 offset="0x001d0" name="RDBK_DATA_CTRL">
                 <bitfield name="COUNT" low="16" high="23" type="uint"/>
                 <bitfield name="CLR" pos="0" type="boolean"/>
@@ -437,7 +440,9 @@ xsi:schemaLocation="http://nouveau.freedesktop.org/

rules-ng.xsd">

         <reg32 offset="0x001c4" name="BIST_CTRL_4"/>
         <reg32 offset="0x001c8" name="BIST_CTRL_5"/>

- <reg32 offset="0x001d4" name="GLBL_TEST_CTRL"/>

rnndb/dsi/dsi.xml +3 -0
+       <reg32 offset="0x001d4" name="GLBL_TEST_CTRL">
+               <bitfield name="BITCLK_HS_SEL" pos="0" type="boolean"/>
+       </reg32>
         <reg32 offset="0x001dc" name="LDO_CNTRL"/>
   </domain>
   @@ -608,7 +613,9 @@

xsi:schemaLocation="http://nouveau.freedesktop.org/ rules-ng.xsd">

         <reg32 offset="0x001c4" name="BIST_CTRL_4"/>
         <reg32 offset="0x001c8" name="BIST_CTRL_5"/>

- <reg32 offset="0x001d4" name="GLBL_TEST_CTRL"/>

rnndb/dsi/dsi.xml +3 -0
+       <reg32 offset="0x001d4" name="GLBL_TEST_CTRL">
+               <bitfield name="BITCLK_HS_SEL" pos="0" type="boolean"/>
+       </reg32>
Quoted 10 lines
Quoted 8 lines
Quoted 8 lines
Quoted 3 lines
         <reg32 offset="0x001dc" name="LDO_CNTRL"/>

</domain>

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel