Patch "hwrng: core - correct error check of kthread_run call" has been added to the 4.1-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
hwrng: core - correct error check of kthread_run call
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
hwrng-core-correct-error-check-of-kthread_run-call.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
17fb874dee093139923af8ed36061faa92cc8e79Mon Sep 17 00:00:00 2001
From: Martin Schwidefsky <[email protected]>
Date: Fri, 24 Jul 2015 13:13:30 +0200
Subject: hwrng: core - correct error check of kthread_run call
From: Martin Schwidefsky <[email protected]>
commit 17fb874dee093139923af8ed36061faa92cc8e79 upstream.
The kthread_run() function can return two different error values but the hwrng core only checks for -ENOMEM. If the other error value -EINTR is returned it is assigned to hwrng_fill and later used on a kthread_stop() call which naturally crashes.
--- drivers/char/hw_random/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/hw_random/core.c +1 -1
@@ -429,7 +429,7 @@ static int hwrng_fillfn(void *unused)static void start_khwrngd (void ) { hwrng_fill =kthread_run (hwrng_fillfn,NULL ,"hwrng" ); -if (hwrng_fill ==ERR_PTR (-ENOMEM )) { +if (IS_ERR (hwrng_fill)) {pr_err ("hwrng_fill thread creation failed" ); hwrng_fill =NULL ; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.1/hwrng-core-correct-error-check-of-kthread_run-call.patch