Skip to contentSkip to conversation

Patch "ALSA: hda - fix cs4210_spdif_automute()" has been added to the 3.14-stable tree

PATCH [email protected] 1 participant 1 message Aug 14, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

    ALSA: hda - fix cs4210_spdif_automute()

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
alsa-hda-fix-cs4210_spdif_automute.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 44008f0896ae205b02b0882dbf807f0de149efc4 Mon Sep 17 00:00:00 2001

From: Dan Carpenter <[email protected]>
Date: Sat, 25 Jul 2015 03:03:38 +0300
Subject: ALSA: hda - fix cs4210_spdif_automute()

From: Dan Carpenter <[email protected]>

commit 44008f0896ae205b02b0882dbf807f0de149efc4 upstream.

Smatch complains that we have nested checks for "spdif_present". It turns out the current behavior isn't correct, we should remove the first check and keep the second.

Fixes 1077a024812d ('ALSA: hda - Use generic parser for Cirrus codec driver')
---
 sound/pci/hda/patch_cirrus.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
sound/pci/hda/patch_cirrus.c +1 -3
@@ -1002,9 +1002,7 @@ static void cs4210_spdif_automute(struct
 
 	spec->spdif_present = spdif_present;
 	/* SPDIF TX on/off */
-	if (spdif_present)
-		snd_hda_set_pin_ctl(codec, spdif_pin,
-				    spdif_present ? PIN_OUT : 0);
+	snd_hda_set_pin_ctl(codec, spdif_pin, spdif_present ? PIN_OUT : 0);
 
 	cs_automute(codec);
 }

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/alsa-hda-fix-cs4210_spdif_automute.patch