Skip to contentSkip to conversation

Patch "thermal: exynos: Disable the regulator on probe failure" has been added to the 4.1-stable tree

PATCH [email protected] 1 participant 1 message Aug 14, 2015

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

thermal: exynos: Disable the regulator on probe failure

to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
thermal-exynos-disable-the-regulator-on-probe-failure.patch
and it can be found in the queue-4.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 5f09a5cbd14ae16e93866040fa44d930ff885650 Mon Sep 17 00:00:00 2001

From: Krzysztof Kozlowski <[email protected]>
Date: Mon, 8 Jun 2015 10:35:49 +0900
Subject: thermal: exynos: Disable the regulator on probe failure

From: Krzysztof Kozlowski <[email protected]>

commit 5f09a5cbd14ae16e93866040fa44d930ff885650 upstream.

During probe the regulator (if present) was enabled but not disabled in case of failure. So an unsuccessful probe lead to enabling the regulator which was actually not needed because the device was not enabled.

Additionally each deferred probe lead to increase of regulator enable count so it would not be effectively disabled during removal of the device.

Test HW: Exynos4412 - Trats2 board

Fixes 498d22f616f6 ("thermal: exynos: Support for TMU regulator defined at device tree")
---
 drivers/thermal/samsung/exynos_tmu.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/thermal/samsung/exynos_tmu.c +2 -0
@@ -1209,6 +1209,8 @@ err_clk_sec:
 	if (!IS_ERR(data->clk_sec))
 		clk_unprepare(data->clk_sec);
 err_sensor:
+	if (!IS_ERR_OR_NULL(data->regulator))
+		regulator_disable(data->regulator);
 	thermal_zone_of_sensor_unregister(&pdev->dev, data->tzd);
 
 	return ret;

Patches currently in stable-queue which might be from [email protected] are

queue-4.1/thermal-exynos-disable-the-regulator-on-probe-failure.patch queue-4.1/dmaengine-pl330-fix-overflow-when-reporting-residue-in-memcpy.patch