Skip to contentSkip to conversation

power: align wakeup_sources format

PATCH In review [email protected] 3 participants 3 messages Aug 13, 2015 – Aug 14, 2015

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 power: align wakeup_sources format

From: yangdongdong <[email protected]>

This aligns every column of elements in wakeup_sources to conveniently check any specific column for suspicious power consumption wakeup source or for other easily readable purpose.

---
 drivers/base/power/wakeup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/base/power/wakeup.c +2 -2
index 51f15bc..b6fe9e6 100644
@@ -998,7 +998,7 @@ static int print_wakeup_source_stats(struct seq_file *m,
 		active_time = ktime_set(0, 0);
 	}
 
-	seq_printf(m, "%-12s\t%lu\t\t%lu\t\t%lu\t\t%lu\t\t%lld\t\t%lld\t\t%lld\t\t%lld\t\t%lld\n",
+	seq_printf(m, "%-32s\t%lu\t\t%lu\t\t%lu\t\t%lu\t\t%lld\t\t%lld\t\t%lld\t\t%lld\t\t%lld\n",
 		   ws->name, active_count, ws->event_count,
 		   ws->wakeup_count, ws->expire_count,
 		   ktime_to_ms(active_time), ktime_to_ms(total_time),
@@ -1018,7 +1018,7 @@ static int wakeup_sources_stats_show(struct seq_file *m, void *unused)
 {
 	struct wakeup_source *ws;
 
-	seq_puts(m, "name\t\tactive_count\tevent_count\twakeup_count\t"
+	seq_puts(m, "name\t\t\t\t\tactive_count\tevent_count\twakeup_count\t"
 		"expire_count\tactive_since\ttotal_time\tmax_time\t"
 		"last_change\tprevent_suspend_time\n");
 
Signature · 6 lines
2.5.0

The signed name has been updated.

Thanks,
yangdongdong
Quoted 1 line · On Wed, Aug 12, 2015 at 02:12:38PM +0800, [email protected] wrote:

From: yangdongdong <[email protected]>

As mentioned before, please fix this.

The signed name is updated from "Andy Yang" to yangdongdong.

Best Regards,
Andy

Quoted 1 line · On Wed, Aug 12, 2015 at 12:31:14PM +0800, [email protected] wrote:

From: yangdongdong <[email protected]>

Use the same name here as you used for the signed-off-by: line please.

Please fix and resend.

thanks,

greg k-h

#1 lore raw
Quoted 7 lines · On Thursday, August 13, 2015 10:24:49 AM [email protected] wrote:

From: yangdongdong <[email protected]>

This aligns every column of elements in wakeup_sources to conveniently check any specific column for suspicious power consumption wakeup source or for other easily readable purpose.

Is yangdongdong your real name, ie. one you would use when checking in at a hotel etc.? If not, it is not appropriate for signing off a patch.

Thanks,
Rafael

#2 lore raw

That is her full name:)
________________________________________
From: Rafael J. Wysocki <[email protected]>
Sent: Friday, August 14, 2015 16:59
To: [email protected]
Cc: Greg Kroah-Hartman; Len Brown; Pavel Machek; 杜慧; 顾凌华; [email protected]; [email protected]; 杨冬东
Subject: Re: [PATCH] power: align wakeup_sources format

Quoted 7 lines · On Thursday, August 13, 2015 10:24:49 AM [email protected] wrote:

From: yangdongdong <[email protected]>

This aligns every column of elements in wakeup_sources to conveniently check any specific column for suspicious power consumption wakeup source or for other easily readable purpose.

Is yangdongdong your real name, ie. one you would use when checking in at a hotel etc.? If not, it is not appropriate for signing off a patch.

Thanks,
Rafael