Skip to contentSkip to conversation

power: align wakeup_sources format

PATCH In review [email protected] 2 participants 2 messages Aug 14, 2015 – Sep 15, 2015

Subsystems (4)
Driver core Suspend to RAM Hibernation Power management core
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 power: align wakeup_sources format

From: yangdongdong <[email protected]>

This aligns every column of elements in wakeup_sources to conveniently check any specific column for suspicious power consumption wakeup source or for other easily readable purpose.

Signed-off-by Dongdong Yang <[email protected]>
Signed-off-by Linghua Gu <[email protected]>
---
 drivers/base/power/wakeup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/base/power/wakeup.c +2 -2
index 51f15bc..b6fe9e6 100644
@@ -998,7 +998,7 @@ static int print_wakeup_source_stats(struct seq_file *m,
 		active_time = ktime_set(0, 0);
 	}
 
-	seq_printf(m, "%-12s\t%lu\t\t%lu\t\t%lu\t\t%lu\t\t%lld\t\t%lld\t\t%lld\t\t%lld\t\t%lld\n",
+	seq_printf(m, "%-32s\t%lu\t\t%lu\t\t%lu\t\t%lu\t\t%lld\t\t%lld\t\t%lld\t\t%lld\t\t%lld\n",
 		   ws->name, active_count, ws->event_count,
 		   ws->wakeup_count, ws->expire_count,
 		   ktime_to_ms(active_time), ktime_to_ms(total_time),

@@ -1018,7 +1018,7 @@ static int wakeup_sources_stats_show(struct seq_file *m, void *unused)
 {
 	struct wakeup_source *ws;
 
-	seq_puts(m, "name\t\tactive_count\tevent_count\twakeup_count\t"
+	seq_puts(m, "name\t\t\t\t\tactive_count\tevent_count\twakeup_count\t"
 		"expire_count\tactive_since\ttotal_time\tmax_time\t"
 		"last_change\tprevent_suspend_time\n");
Signature · 1 line
2.5.0
Quoted 7 lines · On Thursday, August 13, 2015 10:24:49 AM [email protected] wrote:

From: yangdongdong <[email protected]>

This aligns every column of elements in wakeup_sources to conveniently check any specific column for suspicious power consumption wakeup source or for other easily readable purpose.

Signed-off-by yangdongdong <[email protected]>

Is yangdongdong your real name, ie. one you would use when checking in at a hotel etc.? If not, it is not appropriate for signing off a patch.

Thanks,
Rafael

That is her full name:)
________________________________________
From: Rafael J. Wysocki <[email protected]>
Sent: Friday, August 14, 2015 16:59
To: [email protected]
Subject: Re: [PATCH] power: align wakeup_sources format

________________________________________

My surname is Yang, and given name is Dongdong. It is my real name and be printed at my passport. Thanks for your prudence to confirm it with me. BTW, Andy Yang is my English name when I worked for foreign company.

Best Regards,
Dongdong Yang

Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · On Fri 2015-08-14 16:59:27, [email protected] wrote:

From: yangdongdong <[email protected]>

This aligns every column of elements in wakeup_sources to conveniently check any specific column for suspicious power consumption wakeup source or for other easily readable purpose.

Signed-off-by Dongdong Yang <[email protected]>
Signed-off-by Linghua Gu <[email protected]>
---
 drivers/base/power/wakeup.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Its debugfs, so format update should be ok.

Acked-by Pavel Machek <[email protected]>
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html