Patch "path_openat(): fix double fput()" has been added to the 3.14-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
path_openat(): fix double fput()
to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
path_openat-fix-double-fput.patch
and it can be found in the queue-3.14 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
f15133df088ecadd141ea1907f2c96df67c729f0Mon Sep 17 00:00:00 2001
From: Al Viro <[email protected]>
Date: Fri, 8 May 2015 22:53:15 -0400
Subject: path_openat(): fix double fput()
From: Al Viro <[email protected]>
commit f15133df088ecadd141ea1907f2c96df67c729f0 upstream.
path_openat() jumps to the wrong place after do_tmpfile() - it has already done path_cleanup() (as part of path_lookupat() called by do_tmpfile()), so doing that again can lead to double fput().
--- fs/namei.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
fs/namei.c +2 -1
@@ -3171,7 +3171,7 @@ static struct file *path_openat(int dfd,if (unlikely (file->f_flags & __O_TMPFILE)) { error =do_tmpfile (dfd, pathname, nd, flags, op, file, &opened); - goto out; + goto out2; } error =path_init (dfd, pathname->name, flags |LOOKUP_PARENT , nd, &base);
@@ -3209,6 +3209,7 @@ out:path_put (&nd->root);if (base)fput (base); +out2:if (!(opened &FILE_OPENED )) {BUG_ON (!error);put_filp (file);
Patches currently in stable-queue which might be from [email protected] are
queue-3.14/new-helper-dentry_free.patch queue-3.14/don-t-remove-from-shrink-list-in-select_collect.patch queue-3.14/fold-try_prune_one_dentry.patch queue-3.14/more-graceful-recovery-in-umount_collect.patch queue-3.14/expand-the-call-of-dentry_lru_del-in-dentry_kill.patch queue-3.14/dcache-don-t-need-rcu-in-shrink_dentry_list.patch queue-3.14/path_openat-fix-double-fput.patchqueue-3.14/fold-d_kill-and-d_free.patch queue-3.14/ipc-modify-message-queue-accounting-to-not-take-kernel-data-structures-into-account.patch queue-3.14/dentry_kill-don-t-try-to-remove-from-shrink-list.patch queue-3.14/sg_start_req-make-sure-that-there-s-not-too-many-elements-in-iovec.patch