Skip to contentSkip to conversation

:r8169: Add and modify some parameters

PATCH In review Corcodel Marian 2 participants 2 messages Aug 17, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 :r8169: Add and modify some parameters

Set InterFrame Gap time as largest posible for comp. Add
InterFrameGap2 bit set on start.

drivers/net/ethernet/realtek/r8169.c +11 -3
index eb2d2a4..ea0f327 100644
@@ -86,7 +86,8 @@ static const int multicast_filter_limit = 32;
 
 #define MAX_READ_REQUEST_SHIFT	12
 #define TX_DMA_BURST	7	/* Maximum PCI burst, '7' is unlimited */
-#define InterFrameGap	0x03	/* 3 means InterFrameGap = the shortest one */
+#define InterFrameGap	0x02	/* 2 means InterFrameGap = the largest one */
+#define InterFrameGap2	0x80000
 
 #define R8169_REGS_SIZE		256
 #define R8169_NAPI_WEIGHT	64
@@ -5180,7 +5181,7 @@ static void rtl_set_rx_tx_config_registers(struct rtl8169_private *tp)
 
 	/* Set DMA burst size and Interframe Gap Time */
 	RTL_W32(TxConfig, (TX_DMA_BURST << TxDMAShift) |
-		(InterFrameGap << TxInterFrameGapShift));
+		(InterFrameGap << TxInterFrameGapShift) | InterFrameGap2);
 }
 
 static void rtl_hw_start(struct net_device *dev)
@@ -7470,15 +7471,22 @@ static int rtl8169_poll(struct napi_struct *napi, int budget)
 	u16 enable_mask = RTL_EVENT_NAPI | tp->event_slow;
 	int work_done= 0;
 	u16 status;
+        int tx_force = 1;
 
 	status = rtl_get_events(tp);
 	rtl_ack_events(tp, status & ~tp->event_slow);
-
+       if (netif_running(dev)) {
 	if (status & RTL_EVENT_NAPI_RX)
 		work_done = rtl_rx(dev, tp, (u32) budget);
+                
 
 	if (status & RTL_EVENT_NAPI_TX)
 		rtl_tx(dev, tp);
+         else if (tx_force == 1) {
+                mdelay(10);
+                rtl_tx(dev, tp);
+         }
+        }
 
 	if (status & tp->event_slow) {
 		enable_mask &= ~tp->event_slow;
Signature · 1 line
2.1.4
#1 lore raw
Quoted 2 lines · Corcodel Marian

Set InterFrame Gap time as largest posible for comp. Add
InterFrameGap2 bit set on start.

Why?

Quoted 41 lines
drivers/net/ethernet/realtek/r8169.c +6 -3
index eb2d2a4..ea0f327 100644
@@ -86,7 +86,8 @@ static const int multicast_filter_limit = 32;
 
  #define MAX_READ_REQUEST_SHIFT	12
  #define TX_DMA_BURST	7	/* Maximum PCI burst, '7' is unlimited */
-#define InterFrameGap	0x03	/* 3 means InterFrameGap = the shortest one */
+#define InterFrameGap	0x02	/* 2 means InterFrameGap = the largest one */
+#define InterFrameGap2	0x80000
 
  #define R8169_REGS_SIZE		256
  #define R8169_NAPI_WEIGHT	64
@@ -5180,7 +5181,7 @@ static void rtl_set_rx_tx_config_registers(struct rtl8169_private *tp)
 
  	/* Set DMA burst size and Interframe Gap Time */
  	RTL_W32(TxConfig, (TX_DMA_BURST << TxDMAShift) |
-		(InterFrameGap << TxInterFrameGapShift));
+		(InterFrameGap << TxInterFrameGapShift) | InterFrameGap2);
  }
 
  static void rtl_hw_start(struct net_device *dev)
@@ -7470,15 +7471,22 @@ static int rtl8169_poll(struct napi_struct *napi, int budget)
  	u16 enable_mask = RTL_EVENT_NAPI | tp->event_slow;
  	int work_done= 0;
  	u16 status;
+        int tx_force = 1;
 
  	status = rtl_get_events(tp);
  	rtl_ack_events(tp, status & ~tp->event_slow);
-
+       if (netif_running(dev)) {
  	if (status & RTL_EVENT_NAPI_RX)
  		work_done = rtl_rx(dev, tp, (u32) budget);
+
 

drivers/net/ethernet/realtek/r8169.c static int rtl8169_poll(struct napi_struct *napi, int budget) · line 7492

Quoted 10 lines
drivers/net/ethernet/realtek/r8169.c +5 -0
  	if (status & RTL_EVENT_NAPI_TX)
  		rtl_tx(dev, tp);
+         else if (tx_force == 1) {
+                mdelay(10);
+                rtl_tx(dev, tp);
+         }
+        }
 
  	if (status & tp->event_slow) {
  		enable_mask &= ~tp->event_slow;

Why this piece of code??? This was already rejected.