Skip to contentSkip to conversation

regulator: qcom_smd: Set n_voltages for pm8941_lnldo

PATCH In review Axel Lin 2 participants 2 messages Aug 19, 2015

Subsystems (2)
Arm Qualcomm mailing list Voltage and current regulator framework
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: qcom_smd: Set n_voltages for pm8941_lnldo

Just setting fixed_uV is not enough, the regulator core will also check n_voltages setting. The fixed_uV only works when n_voltages is 1.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/qcom_smd-regulator.c | 1 +
 1 file changed, 1 insertion(+)
drivers/regulator/qcom_smd-regulator.c +1 -0
index 9d093ae..9c6167d 100644
@@ -203,6 +203,7 @@ static const struct regulator_desc pm8941_nldo = {
 
 static const struct regulator_desc pm8941_lnldo = {
 	.fixed_uV = 1740000,
+	.n_voltages = 1,
 	.ops = &rpm_smps_ldo_ops,
 };
Signature · 1 line
2.1.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Axel Lin

Just setting fixed_uV is not enough, the regulator core will also check n_voltages setting. The fixed_uV only works when n_voltages is 1.

Thanks, I missed that.

Reviewed-by Bjorn Andersson <[email protected]>
Quoted 22 lines
Signed-off-by Axel Lin <[email protected]>
---
 drivers/regulator/qcom_smd-regulator.c | 1 +
 1 file changed, 1 insertion(+)
drivers/regulator/qcom_smd-regulator.c +1 -0
index 9d093ae..9c6167d 100644
@@ -203,6 +203,7 @@ static const struct regulator_desc pm8941_nldo = {
 
 static const struct regulator_desc pm8941_lnldo = {
 	.fixed_uV = 1740000,
+	.n_voltages = 1,
 	.ops = &rpm_smps_ldo_ops,
 };
Signature · 1 line
2.1.0