Skip to contentSkip to conversation

pstore: pmsg: return -ENOMEM on vmalloc failure

PATCH Mark Salyzyn 2 participants 2 messages Aug 20, 2015 Pstore filesystem

lore
Share & tools
lore
#0 lore raw
---
 fs/pstore/pmsg.c | 2 ++
 1 file changed, 2 insertions(+)
fs/pstore/pmsg.c +2 -0
index feb5dd2..5a2f05a 100644
@@ -37,6 +37,8 @@ static ssize_t write_pmsg(struct file *file, const char __user *buf,
 	if (buffer_size > PMSG_MAX_BOUNCE_BUFFER_SIZE)
 		buffer_size = PMSG_MAX_BOUNCE_BUFFER_SIZE;
 	buffer = vmalloc(buffer_size);
+	if (!buffer)
+		return -ENOMEM;
 
 	mutex_lock(&pmsg_lock);
 	for (i = 0; i < count; ) {
Signature · 1 line
2.5.0.276.gf5e568e
#1 lore raw
Quoted 1 line · Mark Salyzyn

Eek, yes please.

Thanks!

-Kees

Quoted 20 lines
---
 fs/pstore/pmsg.c | 2 ++
 1 file changed, 2 insertions(+)
fs/pstore/pmsg.c +2 -1
index feb5dd2..5a2f05a 100644
@@ -37,6 +37,8 @@ static ssize_t write_pmsg(struct file *file, const char __user *buf,
        if (buffer_size > PMSG_MAX_BOUNCE_BUFFER_SIZE)
                buffer_size = PMSG_MAX_BOUNCE_BUFFER_SIZE;
        buffer = vmalloc(buffer_size);
+       if (!buffer)
+               return -ENOMEM;
 
        mutex_lock(&pmsg_lock);
        for (i = 0; i < count; ) {
--

2.5.0.276.gf5e568e

Signature · 2 lines
Kees Cook
Chrome OS Security