Skip to contentSkip to conversation

staging: fbtft: Removed a space

PATCH In review Aparna Karuthodi 5 participants 10 messages Aug 20, 2015 – Sep 3, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: fbtft: Removed a space

Removed a space before parenthesis to remove a coding style error detected by checkpatch.
The error is given below:
drivers/staging/fbtft/fb_bd663474.c:118: ERROR: space prohibited before that close parenthesis ')'

---
 drivers/staging/fbtft/fb_bd663474.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fb_bd663474.c +1 -1
index 7e00c60..8619426 100644
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0x100, 0x7120 );
 	write_reg(par, 0x007, 0x0103 );
 	mdelay( 10 );
-	write_reg(par, 0x007, 0x0113 );
+	write_reg(par, 0x007, 0x0113);
 
 	return 0;
 }
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 16 lines · Aparna Karuthodi

Removed a space before parenthesis to remove a coding style error detected by checkpatch.
The error is given below:
drivers/staging/fbtft/fb_bd663474.c:118: ERROR: space prohibited before that close parenthesis ')'

---
 drivers/staging/fbtft/fb_bd663474.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fb_bd663474.c +0 -0
index 7e00c60..8619426 100644

drivers/staging/fbtft/fb_bd663474.c static int init_display(struct fbtft_par *par) · line 118

Quoted 5 lines
drivers/staging/fbtft/fb_bd663474.c +1 -1
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0x100, 0x7120 );
 	write_reg(par, 0x007, 0x0103 );
 	mdelay( 10 );
-	write_reg(par, 0x007, 0x0113 );
+	write_reg(par, 0x007, 0x0113);

Every other line in the surrounding context has the same issue. Please don't just change one line at a time like this... It is a waste of our time.

regards,
dan carpenter

#2 lore raw

PATCH 1/1 staging: fbtft: Removed a space

In reply to Aparna Karuthodi

Okay. I will make the necessary changes and send it again. If I am making changes in each of the lines, should I send it as a patchset?

---
 drivers/staging/fbtft/fb_bd663474.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fb_bd663474.c +1 -1
index 7e00c60..8619426 100644
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0x100, 0x7120 );
 	write_reg(par, 0x007, 0x0103 );
 	mdelay( 10 );
-	write_reg(par, 0x007, 0x0113 );
+	write_reg(par, 0x007, 0x0113);
 
 	return 0;
 }
Signature · 1 line
1.7.9.5
#3 lore raw
Quoted 3 lines · Aparna Karuthodi

Okay. I will make the necessary changes and send it again. If I am making changes in each of the lines, should I send it as a patchset?

It seems that these checkpatch errors were already fixed in commit that was already merged:

commit 171c44fcbbf243a327cd2667a74b59b871489b91

Author: Aya Mahfouz <[email protected]>
Date:   Tue Feb 17 19:48:51 2015 +0200

staging: fbtft: fix spacing errors

Are you sure you have the recent kernel tree?

Quoted 20 lines
---
 drivers/staging/fbtft/fb_bd663474.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fb_bd663474.c +1 -1
index 7e00c60..8619426 100644
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0x100, 0x7120 );
 	write_reg(par, 0x007, 0x0103 );
 	mdelay( 10 );
-	write_reg(par, 0x007, 0x0113 );
+	write_reg(par, 0x007, 0x0113);
 
 	return 0;
 }
Signature · 1 line
1.7.9.5

--
Sincerely yours,
Mike.

#4 lore raw

PATCH 1/1 staging: fbtft: Removed a space

In reply to Aparna Karuthodi

I fetched it yesterday using git fetch origin master. So, I thought I am in the recent kernel tree.

---
 drivers/staging/fbtft/fb_bd663474.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fb_bd663474.c +1 -1
index 7e00c60..8619426 100644
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0x100, 0x7120 );
 	write_reg(par, 0x007, 0x0103 );
 	mdelay( 10 );
-	write_reg(par, 0x007, 0x0113 );
+	write_reg(par, 0x007, 0x0113);
 
 	return 0;
 }
Signature · 1 line
1.7.9.5
#5 lore raw
Quoted 1 line · Aparna Karuthodi

I fetched it yesterday using git fetch origin master. So, I thought I am in the recent kernel tree.

In current Linus' tree the fb_bd663474 driver does not have these style errors.
Either your 'origin' is pointing to some tree that was not updated for a long time, or you've only fetched the latest changes from the remote and haven't merged them into your working tree.

Quoted 26 lines
---
 drivers/staging/fbtft/fb_bd663474.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fb_bd663474.c +1 -1
index 7e00c60..8619426 100644
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0x100, 0x7120 );
 	write_reg(par, 0x007, 0x0103 );
 	mdelay( 10 );
-	write_reg(par, 0x007, 0x0113 );
+	write_reg(par, 0x007, 0x0113);
 
 	return 0;
 }
Signature · 7 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
maintainer
#6 lore raw
In reply to Aparna Karuthodi
Quoted 1 line · Aparna Karuthodi

I fetched it yesterday using git fetch origin master. So, I thought I am in the recent kernel tree.

That's a horrible changelog text :(

#7 lore raw

PATCH 1/1 staging: fbtft: Removed a space

In reply to Aparna Karuthodi

Now I understood my mistake. I was calling git fetch or git pull not from master branch. Now when I ran that command from master branch it's working.

---
 drivers/staging/fbtft/fb_bd663474.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fb_bd663474.c +1 -1
index 7e00c60..8619426 100644
@@ -115,7 +115,7 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0x100, 0x7120 );
 	write_reg(par, 0x007, 0x0103 );
 	mdelay( 10 );
-	write_reg(par, 0x007, 0x0113 );
+	write_reg(par, 0x007, 0x0113);
 
 	return 0;
 }
Signature · 1 line
1.7.9.5
#8 lore raw

PATCH 1/1 staging: fbtft: Removed space before parenthesis

In reply to Aparna Karuthodi

Removed space before parenthesis in two different lines to remove coding style errors detected by checkpatch.
The errors are given below:
drivers/staging/fbtft/fbtft-bus.c:73: ERROR: space prohibited before that close parenthesis ')' drivers/staging/fbtft/fbtft-bus.c:75: ERROR: space prohibited before that close parenthesis ')'

---
 drivers/staging/fbtft/fbtft-bus.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-bus.c +2 -2
index b3cddb0..791fab3 100644
@@ -70,9 +70,9 @@ void func(struct fbtft_par *par, int len, ...)                                \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16)
 
 void fbtft_write_reg8_bus9(struct fbtft_par *par, int len, ...)
 {
Signature · 1 line
1.7.9.5
#9 lore raw

Re: [PATCH] staging: fbtft: Removed space before parenthesis

Quoted 18 lines · Aparna Karuthodi

Removed space before parenthesis in two different lines to remove coding style errors detected by checkpatch.
The errors are given below:
drivers/staging/fbtft/fbtft-bus.c:73: ERROR: space prohibited before that close parenthesis ')' drivers/staging/fbtft/fbtft-bus.c:75: ERROR: space prohibited before that close parenthesis ')'

---
 drivers/staging/fbtft/fbtft-bus.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-bus.c +0 -0
index b3cddb0..791fab3 100644

drivers/staging/fbtft/fbtft-bus.c void func(struct fbtft_par *par, int len, ...) \ · line 75

Quoted 8 lines
drivers/staging/fbtft/fbtft-bus.c +2 -2
@@ -70,9 +70,9 @@ void func(struct fbtft_par *par, int len, ...)                                \
 }                                                                             \
 EXPORT_SYMBOL(func);
 
-define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, )
+define_fbtft_write_reg(fbtft_write_reg8_bus8, u8)
 define_fbtft_write_reg(fbtft_write_reg16_bus8, u16, cpu_to_be16)
-define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, )
+define_fbtft_write_reg(fbtft_write_reg16_bus16, u16)

Did you build test it?
You have removed ',' while removing the space and that breaks the build.

regards
sudip