Skip to contentSkip to conversation

linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV

PATCH Superseded Jonathan Liu 2 participants 5 messages Aug 22, 2015 – Oct 4, 2015 Broadcom BCM2711/BCM2835 Arm architecture

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Jonathan Liu

author
#0 lore raw

PATCH v2 1/1 linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV

SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.

Signed-off-by Jonathan Liu <[email protected]>
---
 recipes-kernel/linux/linux-raspberrypi.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
recipes-kernel/linux/linux-raspberrypi.inc +2 -1
index d60a3e9..ef98421 100644
@@ -12,7 +12,8 @@ SRC_URI += " \
 
 COMPATIBLE_MACHINE = "raspberrypi"
 
-PV = "${LINUX_VERSION}+git${SRCREV}"
+PV = "${LINUX_VERSION}+git${SRCPV}"
+PR = "r1"
 
 # NOTE: For now we pull in the default config from the RPi kernel GIT tree.
 KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
Signature · 1 line
2.5.0
author
#1 lore raw
Quoted 12 lines · Jonathan Liu

SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.

Signed-off-by Jonathan Liu <[email protected]>
---
  recipes-kernel/linux/linux-raspberrypi.inc | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
recipes-kernel/linux/linux-raspberrypi.inc +0 -0
index d60a3e9..ef98421 100644

recipes-kernel/linux/linux-raspberrypi.inc SRC_URI += " \ · line 19

Quoted 9 lines
recipes-kernel/linux/linux-raspberrypi.inc +2 -1
@@ -12,7 +12,8 @@ SRC_URI += " \
 
  COMPATIBLE_MACHINE = "raspberrypi"
 
-PV = "${LINUX_VERSION}+git${SRCREV}"
+PV = "${LINUX_VERSION}+git${SRCPV}"
+PR = "r1"
 
  # NOTE: For now we pull in the default config from the RPi kernel GIT tree.
  KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"

Bump.

Regards,
Jonathan

#2 lore raw
Quoted 8 lines · Jonathan Liu
Quoted 7 lines · Jonathan Liu

SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.

Signed-off-by Jonathan Liu <[email protected]>
---
 recipes-kernel/linux/linux-raspberrypi.inc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 9 lines

recipes-kernel/linux/linux-raspberrypi.inc SRC_URI += " \ · line 14

Quoted 9 lines
recipes-kernel/linux/linux-raspberrypi.inc +2 -1
index d60a3e9..ef98421 100644
@@ -12,7 +12,8 @@ SRC_URI += " \
 COMPATIBLE_MACHINE = "raspberrypi"
-PV = "${LINUX_VERSION}+git${SRCREV}"
+PV = "${LINUX_VERSION}+git${SRCPV}"
+PR = "r1"

Why would you want to bump PR? It will eventually end up being the same value, right? The PV change makes sense and is a good idea. And even if it's not the same value will trigger a new build cause PV will change.

Quoted 6 lines

recipes-kernel/linux/linux-raspberrypi.inc SRC_URI += " \ · line 19

Quoted 2 lines
recipes-kernel/linux/linux-raspberrypi.inc +0 -0
 # NOTE: For now we pull in the default config from the RPi kernel GIT tree.
 KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"

Bump.

Regards,
Jonathan

--
Andrei Gherzan

author
#3 lore raw
Quoted 9 lines · Andrei Gherzan
Quoted 8 lines · Jonathan Liu
Quoted 7 lines · Jonathan Liu

SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.

Signed-off-by Jonathan Liu <[email protected]>
---
  recipes-kernel/linux/linux-raspberrypi.inc | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 12 lines
Quoted 9 lines

recipes-kernel/linux/linux-raspberrypi.inc SRC_URI += " \ · line 14

Quoted 9 lines
recipes-kernel/linux/linux-raspberrypi.inc +2 -1
index d60a3e9..ef98421 100644
@@ -12,7 +12,8 @@ SRC_URI += " \
  COMPATIBLE_MACHINE = "raspberrypi"
-PV = "${LINUX_VERSION}+git${SRCREV}"
+PV = "${LINUX_VERSION}+git${SRCPV}"
+PR = "r1"

Why would you want to bump PR? It will eventually end up being the same value, right? The PV change makes sense and is a good idea. And even if it's not the same value will trigger a new build cause PV will change.

Without bumping PR, the version went backwards for me.
The v1 patch posted earlier on the ML doesn't bump PR if you prefer that.

Regards,
Jonathan

author
#4 lore raw
Quoted 22 lines · Jonathan Liu
Quoted 9 lines · Andrei Gherzan
Quoted 8 lines · Jonathan Liu
Quoted 7 lines · Jonathan Liu

SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.

Signed-off-by Jonathan Liu <[email protected]>
---
  recipes-kernel/linux/linux-raspberrypi.inc | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 12 lines
Quoted 9 lines

recipes-kernel/linux/linux-raspberrypi.inc SRC_URI += " \ · line 14

Quoted 9 lines
recipes-kernel/linux/linux-raspberrypi.inc +2 -1
index d60a3e9..ef98421 100644
@@ -12,7 +12,8 @@ SRC_URI += " \
  COMPATIBLE_MACHINE = "raspberrypi"
-PV = "${LINUX_VERSION}+git${SRCREV}"
+PV = "${LINUX_VERSION}+git${SRCPV}"
+PR = "r1"

Why would you want to bump PR? It will eventually end up being the same value, right? The PV change makes sense and is a good idea. And even if it's not the same value will trigger a new build cause PV will change.

Quoted 2 lines

Without bumping PR, the version went backwards for me.
The v1 patch posted earlier on the ML doesn't bump PR if you prefer that.

Now that I think about, bumping PR doesn't make any sense at all as it is after the git revision. If anything, PE should be bumped to 1. Should I bump PE instead or just go with v1 patch?

Regards,
Jonathan