ASoC: tegra: Fix unused variable 'spdif' warning

PATCH In review Axel Lin 3 participants 3 messages Aug 23, 2015 – Aug 25, 2015

Subsystems (3)

Sound ASoC Tegra architecture support

lore

Share & tools

lore

Axel Lin

author

2015-08-23 02:07 UTC #0 lore raw

PATCH 1/1 ASoC: tegra: Fix unused variable 'spdif' warning

Fix below build warning:
CC [M] sound/soc/tegra/tegra20_spdif.o
sound/soc/tegra/tegra20_spdif.c: In function 'tegra20_spdif_platform_remove':
sound/soc/tegra/tegra20_spdif.c:361:24: warning: unused variable 'spdif' [-Wunused-variable]

Signed-off-by Axel Lin <[email protected]>

---
 sound/soc/tegra/tegra20_spdif.c | 2 --
 1 file changed, 2 deletions(-)

sound/soc/tegra/tegra20_spdif.c +0 -2

index 66237bc..0809b1e 100644
@@ -358,8 +358,6 @@ err_pm_disable:
 
 static int tegra20_spdif_platform_remove(struct platform_device *pdev)
 {
-	struct tegra20_spdif *spdif = dev_get_drvdata(&pdev->dev);
-
 	pm_runtime_disable(&pdev->dev);
 	if (!pm_runtime_status_suspended(&pdev->dev))
 		tegra20_spdif_runtime_suspend(&pdev->dev);

Signature · 1 line

2.1.0

Vaishali Thakkar

Reviewed-by on v1 1/1

2015-08-23 03:15 UTC #1 lore raw

Quoted 6 lines · Axel Lin

Fix below build warning:
CC [M] sound/soc/tegra/tegra20_spdif.o
sound/soc/tegra/tegra20_spdif.c: In function 'tegra20_spdif_platform_remove':
sound/soc/tegra/tegra20_spdif.c:361:24: warning: unused variable 'spdif' [-Wunused-variable]
Signed-off-by Axel Lin <[email protected]>

Reviewed-by Vaishali Thakkar <[email protected]>

Quoted 18 lines

---
 sound/soc/tegra/tegra20_spdif.c | 2 --
 1 file changed, 2 deletions(-)

sound/soc/tegra/tegra20_spdif.c +0 -3

index 66237bc..0809b1e 100644
@@ -358,8 +358,6 @@ err_pm_disable:
 
 static int tegra20_spdif_platform_remove(struct platform_device *pdev)
 {
-       struct tegra20_spdif *spdif = dev_get_drvdata(&pdev->dev);
-
        pm_runtime_disable(&pdev->dev);
        if (!pm_runtime_status_suspended(&pdev->dev))
                tegra20_spdif_runtime_suspend(&pdev->dev);
--

Quoted 2 lines

2.1.0

Thanks for sending this patch.

Quoted 1 line

Signature · 1 line

Vaishali

Mark Brown

maintainer

2015-08-25 09:36 UTC #2 lore raw

Applied "ASoC: tegra: Fix unused variable 'spdif' warning" to the asoc tree

In reply to Axel Lin

The patch

ASoC: tegra: Fix unused variable 'spdif' warning

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 5e9a3fcfa2ca10e3ff76938fe9a12515ffa41003 Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Sun, 23 Aug 2015 10:07:13 +0800
Subject: [PATCH] ASoC: tegra: Fix unused variable 'spdif' warning

Signed-off-by Axel Lin <[email protected]>

Reviewed-by Vaishali Thakkar <[email protected]>

Signed-off-by Mark Brown <[email protected]>

---
 sound/soc/tegra/tegra20_spdif.c | 2 --
 1 file changed, 2 deletions(-)

sound/soc/tegra/tegra20_spdif.c +0 -2

index 66237bc44033..0809b1ec1171 100644
@@ -358,8 +358,6 @@ err_pm_disable:
 
 static int tegra20_spdif_platform_remove(struct platform_device *pdev)
 {
-	struct tegra20_spdif *spdif = dev_get_drvdata(&pdev->dev);
-
 	pm_runtime_disable(&pdev->dev);
 	if (!pm_runtime_status_suspended(&pdev->dev))
 		tegra20_spdif_runtime_suspend(&pdev->dev);

Signature · 1 line

2.5.0