Skip to contentSkip to conversation

staging: fbtft: Made into two lines

PATCH In review Aparna Karuthodi 3 participants 6 messages Aug 21, 2015 – Aug 24, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: fbtft: Made into two lines

Made the comment into a new lineto remove a coding style error detected by checkpatch.
The warning is given below:
drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters

---
 drivers/staging/fbtft/fb_pcd8544.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/fbtft/fb_pcd8544.c +2 -1
index 8b9ebfb..cf87ce8 100644
@@ -34,7 +34,8 @@
 #define WIDTH          84
 #define HEIGHT         48
 #define TXBUFLEN       (84*6)
-#define DEFAULT_GAMMA  "40" /* gamma is used to control contrast in this driver */
+#define DEFAULT_GAMMA  "40"
+/* gamma is used to control contrast in this driver */
 
 static unsigned tc;
 module_param(tc, uint, 0);
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 15 lines · Aparna Karuthodi

Made the comment into a new lineto remove a coding style error detected by checkpatch.
The warning is given below:
drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters

---
 drivers/staging/fbtft/fb_pcd8544.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/fbtft/fb_pcd8544.c +0 -0
index 8b9ebfb..cf87ce8 100644

drivers/staging/fbtft/fb_pcd8544.c line 38

Quoted 6 lines
drivers/staging/fbtft/fb_pcd8544.c +2 -1
@@ -34,7 +34,8 @@
 #define WIDTH          84
 #define HEIGHT         48
 #define TXBUFLEN       (84*6)
-#define DEFAULT_GAMMA  "40" /* gamma is used to control contrast in this driver */
+#define DEFAULT_GAMMA  "40"
+/* gamma is used to control contrast in this driver */

I think the format is usually:
/* comment */
#define FOO BAR

Quoted 10 lines
drivers/staging/fbtft/fb_pcd8544.c +0 -0
 static unsigned tc;
 module_param(tc, uint, 0);
Signature · 6 lines
1.7.9.5

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
#2 lore raw

PATCH 1/1 staging: fbtft: Made into two lines

In reply to Aparna Karuthodi

Oh! Sorry! I made the changes to correct the faults you figured out. Is it okay now?

---
 drivers/staging/fbtft/fb_pcd8544.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fb_pcd8544.c +1 -1
index cf87ce8..925511f 100644
@@ -34,8 +34,8 @@
 #define WIDTH          84
 #define HEIGHT         48
 #define TXBUFLEN       (84*6)
-#define DEFAULT_GAMMA  "40"
 /* gamma is used to control contrast in this driver */
+#define DEFAULT_GAMMA  "40"
 
 static unsigned tc;
 module_param(tc, uint, 0);
Signature · 1 line
1.7.9.5
#3 lore raw
Quoted 2 lines · Aparna Karuthodi

Oh! Sorry! I made the changes to correct the faults you figured out. Is it okay now?

Resubmit it properly with "PATCH v2" in the title and a good commit message.

Quoted 11 lines
---
 drivers/staging/fbtft/fb_pcd8544.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fb_pcd8544.c +0 -0
index cf87ce8..925511f 100644

drivers/staging/fbtft/fb_pcd8544.c line 37

Quoted 5 lines
drivers/staging/fbtft/fb_pcd8544.c +0 -1
@@ -34,8 +34,8 @@
 #define WIDTH          84
 #define HEIGHT         48
 #define TXBUFLEN       (84*6)
-#define DEFAULT_GAMMA  "40"
 /* gamma is used to control contrast in this driver */

Isn't this comment supposed to be on the previous line (the removed line)? Check if you haven't messed this up

Quoted 11 lines
drivers/staging/fbtft/fb_pcd8544.c +1 -0
+#define DEFAULT_GAMMA  "40"
 
 static unsigned tc;
 module_param(tc, uint, 0);
Signature · 6 lines
1.7.9.5

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
#4 lore raw
In reply to Aparna Karuthodi
Quoted 2 lines · Aparna Karuthodi

Oh! Sorry! I made the changes to correct the faults you figured out. Is it okay now?

Better. Also, submit it again with proper commit message and put "PATCH v2" in the subject.

Quoted 11 lines
---
 drivers/staging/fbtft/fb_pcd8544.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fb_pcd8544.c +0 -0
index cf87ce8..925511f 100644

drivers/staging/fbtft/fb_pcd8544.c line 37

Quoted 5 lines
drivers/staging/fbtft/fb_pcd8544.c +0 -1
@@ -34,8 +34,8 @@
 #define WIDTH          84
 #define HEIGHT         48
 #define TXBUFLEN       (84*6)
-#define DEFAULT_GAMMA  "40"
 /* gamma is used to control contrast in this driver */

Aren't these two supposed to be on the same line? I think your patch is a bit messed up. Doublecheck this.

Quoted 11 lines
drivers/staging/fbtft/fb_pcd8544.c +1 -0
+#define DEFAULT_GAMMA  "40"
 
 static unsigned tc;
 module_param(tc, uint, 0);
Signature · 6 lines
1.7.9.5

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
#5 lore raw
In reply to Aparna Karuthodi
Quoted 7 lines · Aparna Karuthodi

Made the comment into a new lineto remove a coding style error detected by checkpatch.
The warning is given below:
drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters

---

Please update your tree. This will also not apply for:
4178549e4c47 ("Staging: fbtft: fb_pcd8544: Fix comments style")

regards
sudip