nfsd: don't WARN/backtrace for invalid container deployment.

PATCH In review Paul Gortmaker 2 participants 4 messages Aug 25, 2015 – Aug 26, 2015

Subsystems (2)

NFS client NFS server

lore

Share & tools

lore

Paul Gortmaker

author

2015-08-25 20:59 UTC #0 lore raw

PATCH 1/1 nfsd: don't WARN/backtrace for invalid container deployment.

These messages, combined with the backtrace they trigger, makes it seem like a serious problem, though a quick search shows distros marking it as a "won't fix" non-issue when the problem is reported by users.

The backtrace is overkill, and only really manages to show that if you follow the code path, you can't really avoid it with bootargs or configuration settings in the container.

Given that, lets tone it down a bit and get rid of the WARN severity, and the associated backtrace, so people aren't needlessly alarmed.

Also, lets drop the split printk line, since they are grep unfriendly.

Cc "J. Bruce Fields" <[email protected]>

Cc [email protected]

Signed-off-by Paul Gortmaker <[email protected]>

fs/nfsd/nfs4recover.c +2 -4

index 9c271f42604a..fe8a3da5eb63 100644
@@ -526,8 +526,7 @@ nfsd4_legacy_tracking_init(struct net *net)
 
 	/* XXX: The legacy code won't work in a container */
 	if (net != &init_net) {
-		WARN(1, KERN_ERR "NFSD: attempt to initialize legacy client "
-			"tracking in a container!\n");
+		pr_warn("NFSD: attempt to initialize legacy client tracking in a container ignored.\n");
 		return -EINVAL;
 	}

@@ -1191,8 +1190,7 @@ nfsd4_umh_cltrack_init(struct net __attribute__((unused)) *net)
 {
 	/* XXX: The usermode helper s not working in container yet. */
 	if (net != &init_net) {
-		WARN(1, KERN_ERR "NFSD: attempt to initialize umh client "
-			"tracking in a container!\n");
+		pr_warn("NFSD: attempt to initialize umh client tracking in a container ignored.\n");
 		return -EINVAL;
 	}
 	return nfsd4_umh_cltrack_upcall("init", NULL, NULL);

Signature · 1 line

2.1.0

Paul Gortmaker

author

2015-08-25 21:06 UTC #1 lore raw

Quoted 3 lines · [[PATCH] nfsd: don't WARN/backtrace for invalid container deployment.] On…

These messages, combined with the backtrace they trigger, makes it seem like a serious problem, though a quick search shows distros marking it as a "won't fix" non-issue when the problem is reported by users.

Ah crap, didn't notice I was on a slightly older kernel when generating this ; it still applies to master with minor fuzz. I can resend if need be, and if folks are OK with the general approach.

Paul.
--

Quoted 41 lines

The backtrace is overkill, and only really manages to show that if you follow the code path, you can't really avoid it with bootargs or configuration settings in the container.
Given that, lets tone it down a bit and get rid of the WARN severity, and the associated backtrace, so people aren't needlessly alarmed.
Also, lets drop the split printk line, since they are grep unfriendly.
Cc "J. Bruce Fields" <[email protected]>
Cc [email protected]
Signed-off-by Paul Gortmaker <[email protected]>
fs/nfsd/nfs4recover.c +2 -4
index 9c271f42604a..fe8a3da5eb63 100644
@@ -526,8 +526,7 @@ nfsd4_legacy_tracking_init(struct net *net)
 
 	/* XXX: The legacy code won't work in a container */
 	if (net != &init_net) {
-		WARN(1, KERN_ERR "NFSD: attempt to initialize legacy client "
-			"tracking in a container!\n");
+		pr_warn("NFSD: attempt to initialize legacy client tracking in a container ignored.\n");
 		return -EINVAL;
 	}
 
@@ -1191,8 +1190,7 @@ nfsd4_umh_cltrack_init(struct net __attribute__((unused)) *net)
 {
 	/* XXX: The usermode helper s not working in container yet. */
 	if (net != &init_net) {
-		WARN(1, KERN_ERR "NFSD: attempt to initialize umh client "
-			"tracking in a container!\n");
+		pr_warn("NFSD: attempt to initialize umh client tracking in a container ignored.\n");
 		return -EINVAL;
 	}
 	return nfsd4_umh_cltrack_upcall("init", NULL, NULL);
Signature · 1 line
2.1.0

J. Bruce Fields

2015-08-25 21:16 UTC #2 lore raw

Quoted 9 lines · Paul Gortmaker

Quoted 3 lines · [[PATCH] nfsd: don't WARN/backtrace for invalid container deployment.] On…
These messages, combined with the backtrace they trigger, makes it seem like a serious problem, though a quick search shows distros marking it as a "won't fix" non-issue when the problem is reported by users.
Ah crap, didn't notice I was on a slightly older kernel when generating this ; it still applies to master with minor fuzz. I can resend if need be, and if folks are OK with the general approach.

Well, this really is something we need to fix, but given that it's going to take a while, OK, maybe toning this down is best.

--b.

Quoted 45 lines

Paul.
--
Quoted 41 lines
The backtrace is overkill, and only really manages to show that if you follow the code path, you can't really avoid it with bootargs or configuration settings in the container.
Given that, lets tone it down a bit and get rid of the WARN severity, and the associated backtrace, so people aren't needlessly alarmed.
Also, lets drop the split printk line, since they are grep unfriendly.
Cc "J. Bruce Fields" <[email protected]>
Cc [email protected]
Signed-off-by Paul Gortmaker <[email protected]>
fs/nfsd/nfs4recover.c +2 -4
index 9c271f42604a..fe8a3da5eb63 100644
@@ -526,8 +526,7 @@ nfsd4_legacy_tracking_init(struct net *net)
 
 	/* XXX: The legacy code won't work in a container */
 	if (net != &init_net) {
-		WARN(1, KERN_ERR "NFSD: attempt to initialize legacy client "
-			"tracking in a container!\n");
+		pr_warn("NFSD: attempt to initialize legacy client tracking in a container ignored.\n");
 		return -EINVAL;
 	}
 
@@ -1191,8 +1190,7 @@ nfsd4_umh_cltrack_init(struct net __attribute__((unused)) *net)
 {
 	/* XXX: The usermode helper s not working in container yet. */
 	if (net != &init_net) {
-		WARN(1, KERN_ERR "NFSD: attempt to initialize umh client "
-			"tracking in a container!\n");
+		pr_warn("NFSD: attempt to initialize umh client tracking in a container ignored.\n");
 		return -EINVAL;
 	}
 	return nfsd4_umh_cltrack_upcall("init", NULL, NULL);
Signature · 1 line
2.1.0

J. Bruce Fields

2015-08-26 19:07 UTC #3 lore raw

In reply to Paul Gortmaker

Quoted 4 lines · Paul Gortmaker

These messages, combined with the backtrace they trigger, makes it seem like a serious problem, though a quick search shows distros marking it as a "won't fix" non-issue when the problem is reported by users.

Quoted 8 lines

The backtrace is overkill, and only really manages to show that if you follow the code path, you can't really avoid it with bootargs or configuration settings in the container.
Given that, lets tone it down a bit and get rid of the WARN severity, and the associated backtrace, so people aren't needlessly alarmed.
Also, lets drop the split printk line, since they are grep unfriendly.

OK, applying.--b.

Quoted 31 lines

Cc "J. Bruce Fields" <[email protected]>

Cc [email protected]

Signed-off-by Paul Gortmaker <[email protected]>

fs/nfsd/nfs4recover.c +2 -4

index 9c271f42604a..fe8a3da5eb63 100644
@@ -526,8 +526,7 @@ nfsd4_legacy_tracking_init(struct net *net)
 
 	/* XXX: The legacy code won't work in a container */
 	if (net != &init_net) {
-		WARN(1, KERN_ERR "NFSD: attempt to initialize legacy client "
-			"tracking in a container!\n");
+		pr_warn("NFSD: attempt to initialize legacy client tracking in a container ignored.\n");
 		return -EINVAL;
 	}

@@ -1191,8 +1190,7 @@ nfsd4_umh_cltrack_init(struct net __attribute__((unused)) *net)
 {
 	/* XXX: The usermode helper s not working in container yet. */
 	if (net != &init_net) {
-		WARN(1, KERN_ERR "NFSD: attempt to initialize umh client "
-			"tracking in a container!\n");
+		pr_warn("NFSD: attempt to initialize umh client tracking in a container ignored.\n");
 		return -EINVAL;
 	}
 	return nfsd4_umh_cltrack_upcall("init", NULL, NULL);

Signature · 1 line

2.1.0