ASoC: pxa-ssp: Convert to devm_snd_soc_register_component

PATCH In review Axel Lin 4 participants 8 messages Aug 28, 2015 – Aug 30, 2015

Subsystems (3)

Sound ASoC PXA2xx/PXA3xx support

lore

Share & tools

lore

Axel Lin

author

2015-08-28 02:48 UTC #0 lore raw

PATCH 1/3 ASoC: pxa-ssp: Convert to devm_snd_soc_register_component

Signed-off-by Axel Lin <[email protected]>

---
 sound/soc/pxa/pxa-ssp.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

sound/soc/pxa/pxa-ssp.c +2 -9

index fbe2e93..3da485e 100644
@@ -813,14 +813,8 @@ static const struct of_device_id pxa_ssp_of_ids[] = {
 
 static int asoc_ssp_probe(struct platform_device *pdev)
 {
-	return snd_soc_register_component(&pdev->dev, &pxa_ssp_component,
-					  &pxa_ssp_dai, 1);
-}
-
-static int asoc_ssp_remove(struct platform_device *pdev)
-{
-	snd_soc_unregister_component(&pdev->dev);
-	return 0;
+	return devm_snd_soc_register_component(&pdev->dev, &pxa_ssp_component,
+					       &pxa_ssp_dai, 1);
 }
 
 static struct platform_driver asoc_ssp_driver = {

@@ -830,7 +824,6 @@ static struct platform_driver asoc_ssp_driver = {
 	},
 
 	.probe = asoc_ssp_probe,
-	.remove = asoc_ssp_remove,
 };
 
 module_platform_driver(asoc_ssp_driver);

Signature · 1 line

2.1.0

Axel Lin

author

2015-08-28 02:49 UTC #1 lore raw

PATCH 2/3 ASoC: pxa2xx-i2s: Convert to devm_snd_soc_register_component

Signed-off-by Axel Lin <[email protected]>

---
 sound/soc/pxa/pxa2xx-i2s.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

sound/soc/pxa/pxa2xx-i2s.c +2 -9

index e68290c..6b4e400 100644
@@ -367,19 +367,12 @@ static const struct snd_soc_component_driver pxa_i2s_component = {
 
 static int pxa2xx_i2s_drv_probe(struct platform_device *pdev)
 {
-	return snd_soc_register_component(&pdev->dev, &pxa_i2s_component,
-					  &pxa_i2s_dai, 1);
-}
-
-static int pxa2xx_i2s_drv_remove(struct platform_device *pdev)
-{
-	snd_soc_unregister_component(&pdev->dev);
-	return 0;
+	return devm_snd_soc_register_component(&pdev->dev, &pxa_i2s_component,
+					       &pxa_i2s_dai, 1);
 }
 
 static struct platform_driver pxa2xx_i2s_driver = {
 	.probe = pxa2xx_i2s_drv_probe,
-	.remove = pxa2xx_i2s_drv_remove,
 
 	.driver = {
 		.name = "pxa2xx-i2s",

Signature · 1 line

2.1.0

Mark Brown

maintainer

2015-08-28 17:45 UTC #2 lore raw

Applied "ASoC: pxa2xx-i2s: Convert to devm_snd_soc_register_component" to the asoc tree

The patch

ASoC: pxa2xx-i2s: Convert to devm_snd_soc_register_component

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 2cf32b7b338086e9b85bb9fdd8aa398e89d83e9e Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Fri, 28 Aug 2015 10:49:44 +0800
Subject: [PATCH] ASoC: pxa2xx-i2s: Convert to devm_snd_soc_register_component

Signed-off-by Axel Lin <[email protected]>

Signed-off-by Mark Brown <[email protected]>

---
 sound/soc/pxa/pxa2xx-i2s.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

sound/soc/pxa/pxa2xx-i2s.c +2 -9

index e68290c..6b4e400 100644
@@ -367,19 +367,12 @@ static const struct snd_soc_component_driver pxa_i2s_component = {
 
 static int pxa2xx_i2s_drv_probe(struct platform_device *pdev)
 {
-	return snd_soc_register_component(&pdev->dev, &pxa_i2s_component,
-					  &pxa_i2s_dai, 1);
-}
-
-static int pxa2xx_i2s_drv_remove(struct platform_device *pdev)
-{
-	snd_soc_unregister_component(&pdev->dev);
-	return 0;
+	return devm_snd_soc_register_component(&pdev->dev, &pxa_i2s_component,
+					       &pxa_i2s_dai, 1);
 }
 
 static struct platform_driver pxa2xx_i2s_driver = {
 	.probe = pxa2xx_i2s_drv_probe,
-	.remove = pxa2xx_i2s_drv_remove,
 
 	.driver = {
 		.name = "pxa2xx-i2s",

Signature · 1 line

2.5.0

Axel Lin

author

2015-08-28 02:50 UTC #3 lore raw

PATCH 3/3 ASoC: sh: ssi: Convert to devm_snd_soc_register_component

In reply to Axel Lin

Signed-off-by Axel Lin <[email protected]>

---
 sound/soc/sh/ssi.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

sound/soc/sh/ssi.c +3 -9

index ab13146..89ed1b1 100644
@@ -385,14 +385,9 @@ static const struct snd_soc_component_driver sh4_ssi_component = {
 
 static int sh4_soc_dai_probe(struct platform_device *pdev)
 {
-	return snd_soc_register_component(&pdev->dev, &sh4_ssi_component,
-					  sh4_ssi_dai, ARRAY_SIZE(sh4_ssi_dai));
-}
-
-static int sh4_soc_dai_remove(struct platform_device *pdev)
-{
-	snd_soc_unregister_component(&pdev->dev);
-	return 0;
+	return devm_snd_soc_register_component(&pdev->dev, &sh4_ssi_component,
+					       sh4_ssi_dai,
+					       ARRAY_SIZE(sh4_ssi_dai));
 }
 
 static struct platform_driver sh4_ssi_driver = {

@@ -401,7 +396,6 @@ static struct platform_driver sh4_ssi_driver = {
 	},
 
 	.probe = sh4_soc_dai_probe,
-	.remove = sh4_soc_dai_remove,
 };
 
 module_platform_driver(sh4_ssi_driver);

Signature · 1 line

2.1.0

Mark Brown

maintainer

2015-08-28 17:45 UTC #4 lore raw

Applied "ASoC: sh: ssi: Convert to devm_snd_soc_register_component" to the asoc tree

The patch

ASoC: sh: ssi: Convert to devm_snd_soc_register_component

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 92eca20bbeaa4ec1908bad8aeefcaa2d98e302ff Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Fri, 28 Aug 2015 10:50:53 +0800
Subject: [PATCH] ASoC: sh: ssi: Convert to devm_snd_soc_register_component

Signed-off-by Axel Lin <[email protected]>

Signed-off-by Mark Brown <[email protected]>

---
 sound/soc/sh/ssi.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

sound/soc/sh/ssi.c +3 -9

index ab13146..89ed1b1 100644
@@ -385,14 +385,9 @@ static const struct snd_soc_component_driver sh4_ssi_component = {
 
 static int sh4_soc_dai_probe(struct platform_device *pdev)
 {
-	return snd_soc_register_component(&pdev->dev, &sh4_ssi_component,
-					  sh4_ssi_dai, ARRAY_SIZE(sh4_ssi_dai));
-}
-
-static int sh4_soc_dai_remove(struct platform_device *pdev)
-{
-	snd_soc_unregister_component(&pdev->dev);
-	return 0;
+	return devm_snd_soc_register_component(&pdev->dev, &sh4_ssi_component,
+					       sh4_ssi_dai,
+					       ARRAY_SIZE(sh4_ssi_dai));
 }
 
 static struct platform_driver sh4_ssi_driver = {

@@ -401,7 +396,6 @@ static struct platform_driver sh4_ssi_driver = {
 	},
 
 	.probe = sh4_soc_dai_probe,
-	.remove = sh4_soc_dai_remove,
 };
 
 module_platform_driver(sh4_ssi_driver);

Signature · 1 line

2.5.0

Manuel Lauss

Acked-by on v1 3/3

2015-08-30 06:25 UTC #5 lore raw

Re: [PATCH 3/3] ASoC: sh: ssi: Convert to devm_snd_soc_register_component

In reply to Axel Lin

Quoted 4 lines · Axel Lin

Signed-off-by Axel Lin <[email protected]>
---
 sound/soc/sh/ssi.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

Acked-by Manuel Lauss <[email protected]>

Robert Jarzmik

maintainer

2015-08-28 08:47 UTC #6 lore raw

In reply to Axel Lin

Quoted 1 line · Axel Lin

Signed-off-by Axel Lin <[email protected]>

Both patches look fine by me, except that the commit messages are empty, which is a bit a pity for me. That would for example tell me if this was tested on any platform, even if the patch looks trivial.

Cheers.

--
Robert

Mark Brown

maintainer

2015-08-28 17:45 UTC #7 lore raw

Applied "ASoC: pxa-ssp: Convert to devm_snd_soc_register_component" to the asoc tree

In reply to Axel Lin

The patch

ASoC: pxa-ssp: Convert to devm_snd_soc_register_component

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 637ce53a1b1c489ff0e92aa00b8376464f697dc5 Mon Sep 17 00:00:00 2001

From: Axel Lin <[email protected]>
Date: Fri, 28 Aug 2015 10:48:35 +0800
Subject: [PATCH] ASoC: pxa-ssp: Convert to devm_snd_soc_register_component

Signed-off-by Axel Lin <[email protected]>

Signed-off-by Mark Brown <[email protected]>

---
 sound/soc/pxa/pxa-ssp.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

sound/soc/pxa/pxa-ssp.c +2 -9

index fbe2e93..3da485e 100644
@@ -813,14 +813,8 @@ static const struct of_device_id pxa_ssp_of_ids[] = {
 
 static int asoc_ssp_probe(struct platform_device *pdev)
 {
-	return snd_soc_register_component(&pdev->dev, &pxa_ssp_component,
-					  &pxa_ssp_dai, 1);
-}
-
-static int asoc_ssp_remove(struct platform_device *pdev)
-{
-	snd_soc_unregister_component(&pdev->dev);
-	return 0;
+	return devm_snd_soc_register_component(&pdev->dev, &pxa_ssp_component,
+					       &pxa_ssp_dai, 1);
 }
 
 static struct platform_driver asoc_ssp_driver = {

@@ -830,7 +824,6 @@ static struct platform_driver asoc_ssp_driver = {
 	},
 
 	.probe = asoc_ssp_probe,
-	.remove = asoc_ssp_remove,
 };
 
 module_platform_driver(asoc_ssp_driver);

Signature · 1 line

2.5.0