Skip to contentSkip to conversation

imx: vf610 add function get_cpu_rev

PATCH Superseded Peng Fan 3 participants 4 messages Sep 1, 2015 Arm (32-bit)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Peng Fan

author
#0 lore raw

PATCH 1/1 imx: vf610 add function get_cpu_rev

Since we need to support runtime check for different drivers, we need to add get_cpu_rev for vf610.

This patch only introduce a empty implementation to avoid build errors, later more stuff can be added if need to check vf610 cpu types.

Cc Stefano Babic <[email protected]>
---
 arch/arm/cpu/armv7/vf610/generic.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/cpu/armv7/vf610/generic.c +11 -0
index 05c401d..bd948cb 100644
@@ -266,6 +266,17 @@ void imx_get_mac_from_fuse(int dev_id, unsigned char *mac)
 }
 #endif
 
+/*
+ * Empty function
+ * Several drivers use runtime check, which needs get_cpu_rev.
+ * If later we need to do runtime check for vf610, we can add
+ * more stuff here.
+ */
+u32 get_cpu_rev(void)
+{
+	return 0;
+}
+
 #if defined(CONFIG_DISPLAY_CPUINFO)
 static char *get_reset_cause(void)
 {
Signature · 1 line
1.8.4
#1 lore raw

PATCH 1/1 imx: vf610 add function get_cpu_rev

Hi Peng,

Quoted 25 lines · Peng Fan

Since we need to support runtime check for different drivers, we need to add get_cpu_rev for vf610.

This patch only introduce a empty implementation to avoid build errors, later more stuff can be added if need to check vf610 cpu types.

Cc Stefano Babic <[email protected]>
---
 arch/arm/cpu/armv7/vf610/generic.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/cpu/armv7/vf610/generic.c +4 -0
index 05c401d..bd948cb 100644
@@ -266,6 +266,17 @@ void imx_get_mac_from_fuse(int dev_id, unsigned char *mac)
 }
 #endif
 
+/*
+ * Empty function
+ * Several drivers use runtime check, which needs get_cpu_rev.
+ * If later we need to do runtime check for vf610, we can add

arch/arm/cpu/armv7/vf610/generic.c void imx_get_mac_from_fuse(int dev_id, unsigned char *mac) · line 282

Quoted 10 lines
arch/arm/cpu/armv7/vf610/generic.c +7 -0
+ * more stuff here.
+ */
+u32 get_cpu_rev(void)
+{
+	return 0;
+}
+
 #if defined(CONFIG_DISPLAY_CPUINFO)
 static char *get_reset_cause(void)
 {

If there is really no way to get the cpu revision from the SOC, I suggest we use the same approach of MXC_CPU_MX6SOLO with a "dummy" cpu. Something like :

#define MXC_CPU_VF610 0xF6 /* dummy CPU */

"F6" from vF610, of course, instead of returning 0.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#2 lore raw

PATCH 1/1 imx: vf610 add function get_cpu_rev

Hi Stefano,

Quoted 43 lines · Stefano Babic

Hi Peng,

Quoted 25 lines · Peng Fan

Since we need to support runtime check for different drivers, we need to add get_cpu_rev for vf610.

This patch only introduce a empty implementation to avoid build errors, later more stuff can be added if need to check vf610 cpu types.

Cc Stefano Babic <[email protected]>
---
 arch/arm/cpu/armv7/vf610/generic.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/cpu/armv7/vf610/generic.c +4 -0
index 05c401d..bd948cb 100644
@@ -266,6 +266,17 @@ void imx_get_mac_from_fuse(int dev_id, unsigned char *mac)
 }
 #endif
 
+/*
+ * Empty function
+ * Several drivers use runtime check, which needs get_cpu_rev.
+ * If later we need to do runtime check for vf610, we can add

arch/arm/cpu/armv7/vf610/generic.c void imx_get_mac_from_fuse(int dev_id, unsigned char *mac) · line 282

Quoted 10 lines
arch/arm/cpu/armv7/vf610/generic.c +7 -0
+ * more stuff here.
+ */
+u32 get_cpu_rev(void)
+{
+	return 0;
+}
+
 #if defined(CONFIG_DISPLAY_CPUINFO)
 static char *get_reset_cause(void)
 {

If there is really no way to get the cpu revision from the SOC, I suggest we use the same approach of MXC_CPU_MX6SOLO with a "dummy" cpu. Something like :

Quoted 3 lines

#define MXC_CPU_VF610 0xF6 /* dummy CPU */

"F6" from vF610, of course, instead of returning 0.

I not have vf610 board in hand and need to check with others about this. Not sure when I can get the result. So now for quick fix, using your way with your Suggested-by. Later, if I can get the results, can use another patch to fix the cpu type, because build errors should be at high priority to be fixed. What do you think?

Regards,
Peng.

Quoted 10 lines

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH 1/1 imx: vf610 add function get_cpu_rev

Hi Peng,

Quoted 2 lines · Peng Fan

I not have vf610 board in hand and need to check with others about this.

ok

Quoted 4 lines

Not sure when I can get the result. So now for quick fix, using your way with your Suggested-by. Later, if I can get the results, can use another patch to fix the cpu type, because build errors should be at high priority to be fixed. What do you think?

Agree - this is the best we can currently do.

Regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================