Skip to contentSkip to conversation

mxs: mxsboot: fix endianess for sd boot images

PATCH New Michael Heimpold 3 participants 3 messages Sep 1, 2015 – Sep 2, 2015 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mxs: mxsboot: fix endianess for sd boot images

Running mxsboot on a big-endian system produces a sd image which cannot be started by the i.MX28 ROM. It complains on the debug uart as following:
0x8020a009

          0x80502008
0x8020a009
          0x80502008

...

Enforcing all fields within the BCB to little-endian make the image bootable again.

---
 tools/mxsboot.c |   19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)
tools/mxsboot.c +10 -9
index 185b327..8284e95 100644
@@ -7,6 +7,7 @@
  * SPDX-License-Identifier:	GPL-2.0+
  */
 
+#include <endian.h>
 #include <fcntl.h>
 #include <sys/stat.h>
 #include <sys/types.h>
@@ -569,15 +570,15 @@ static int mx28_create_sd_image(int infd, int outfd)
 
 	cb = (struct mx28_sd_config_block *)buf;
 
-	cb->signature = 0x00112233;
-	cb->primary_boot_tag = 0x1;
-	cb->secondary_boot_tag = 0x1;
-	cb->num_copies = 1;
-	cb->drv_info[0].chip_num = 0x0;
-	cb->drv_info[0].drive_type = 0x0;
-	cb->drv_info[0].tag = 0x1;
-	cb->drv_info[0].first_sector_number = sd_sector + 4;
-	cb->drv_info[0].sector_count = (size - 4) / 512;
+	cb->signature = htole32(0x00112233);
+	cb->primary_boot_tag = htole32(0x1);
+	cb->secondary_boot_tag = htole32(0x1);
+	cb->num_copies = htole32(1);
+	cb->drv_info[0].chip_num = htole32(0x0);
+	cb->drv_info[0].drive_type = htole32(0x0);
+	cb->drv_info[0].tag = htole32(0x1);
+	cb->drv_info[0].first_sector_number = htole32(sd_sector + 4);
+	cb->drv_info[0].sector_count = htole32((size - 4) / 512);
 
 	wr_size = write(outfd, buf, size);
 	if (wr_size != size) {
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 mxs: mxsboot: fix endianess for sd boot images

Hi Michael,

Quoted 3 lines · Michael Heimpold

Running mxsboot on a big-endian system produces a sd image which cannot be started by the i.MX28 ROM. It complains on the debug uart as following:

I confess that I never tested mxsboot and/or mkimage on a big endian host. I am expecting there are similar issues with mkimage and imximage, too....

Quoted 42 lines

0x8020a009

          0x80502008
0x8020a009
          0x80502008

...

Enforcing all fields within the BCB to little-endian make the image bootable again.

---
 tools/mxsboot.c |   19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)
tools/mxsboot.c +3 -9
index 185b327..8284e95 100644
@@ -7,6 +7,7 @@
  * SPDX-License-Identifier:	GPL-2.0+
  */
 
+#include <endian.h>
 #include <fcntl.h>
 #include <sys/stat.h>
 #include <sys/types.h>
@@ -569,15 +570,15 @@ static int mx28_create_sd_image(int infd, int outfd)
 
 	cb = (struct mx28_sd_config_block *)buf;
 
-	cb->signature = 0x00112233;
-	cb->primary_boot_tag = 0x1;
-	cb->secondary_boot_tag = 0x1;
-	cb->num_copies = 1;
-	cb->drv_info[0].chip_num = 0x0;
-	cb->drv_info[0].drive_type = 0x0;
-	cb->drv_info[0].tag = 0x1;
-	cb->drv_info[0].first_sector_number = sd_sector + 4;
-	cb->drv_info[0].sector_count = (size - 4) / 512;
+	cb->signature = htole32(0x00112233);
+	cb->primary_boot_tag = htole32(0x1);

tools/mxsboot.c static int mx28_create_sd_image(int infd, int outfd) · line 584

Quoted 10 lines
tools/mxsboot.c +7 -0
+	cb->secondary_boot_tag = htole32(0x1);
+	cb->num_copies = htole32(1);
+	cb->drv_info[0].chip_num = htole32(0x0);
+	cb->drv_info[0].drive_type = htole32(0x0);
+	cb->drv_info[0].tag = htole32(0x1);
+	cb->drv_info[0].first_sector_number = htole32(sd_sector + 4);
+	cb->drv_info[0].sector_count = htole32((size - 4) / 512);
 
 	wr_size = write(outfd, buf, size);
 	if (wr_size != size) {

Looks ok to me !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#2 lore raw

PATCH 1/1 mxs: mxsboot: fix endianess for sd boot images

Quoted 8 lines · Stefano Babic

Hi Michael,

Quoted 4 lines · Michael Heimpold

Running mxsboot on a big-endian system produces a sd image which cannot be started by the i.MX28 ROM. It complains on the debug

uart as following:

I confess that I never tested mxsboot and/or mkimage on a big endian

Me neither.

Quoted 2 lines

host. I am expecting there are similar issues with mkimage and imximage, too....

Fix it and send patch :b

Best regards,
Marek Vasut