regmap: fix compilation warning
Subsystems (2)
PATCH 1/1 regmap: fix compilation warning
Explicitly initialize ret to -EINVAL in regmap_raw_read to fix the following compilation warning:
CC drivers/base/regmap/regmap.olinux/drivers/base/regmap/regmap.c: In function ‘regmap_raw_read’:linux/drivers/base/regmap/regmap.c:2174:6: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
int ret, i;
^Signed-off-by Mike Rapoport <[email protected]>
--- drivers/base/regmap/regmap.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/base/regmap/regmap.c +5 -4
@@ -2171,14 +2171,15 @@ int regmap_raw_read(struct regmap *map, unsigned int reg, void *val,size_t val_bytes = map->format.val_bytes;size_t val_count = val_len / val_bytes;unsigned int v; -int ret, i; +int i; +int ret = -EINVAL ;if (!map->bus) -return -EINVAL ; +return ret;if (val_len % map->format.val_bytes) -return -EINVAL ; +return ret;if (reg % map->reg_stride) -return -EINVAL ; +return ret; map->lock (map->lock_arg);
Signature · 1 line
1.8.3.1
Mark Brown
maintainerQuoted 2 lines · Mike Rapoport
Explicitly initialize ret to
-EINVALinregmap_raw_readto fix the following compilation warning:
This doesn't seem to apply any more, can you please check and resend if it's still needed (there were some changes went in near the merge window it collided with).