switchdev: fix return value of switchdev_port_fdb_dump in case of error
Subsystems (3)
Jiri Pirko
maintainerPATCH 1/1 switchdev: fix return value of switchdev_port_fdb_dump in case of error
From: Jiri Pirko <[email protected]>
switchdev_port_fdb_dump is used as .ndo_fdb_dump. Its return value is idx, so we cannot return errval.
Fixes 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.")
Signed-off-by Jiri Pirko <[email protected]>
--- net/switchdev/switchdev.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
net/switchdev/switchdev.c +1 -5
@@ -853,12 +853,8 @@ int switchdev_port_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb, .cb = cb, .idx = idx, }; -int err; - - err =switchdev_port_obj_dump (dev, &dump.obj); -if (err) -return err; +switchdev_port_obj_dump (dev, &dump.obj);return dump.idx; }EXPORT_SYMBOL_GPL (switchdev_port_fdb_dump);
Signature · 1 line
1.9.3
Quoted 7 lines · Jiri Pirko
From: Jiri Pirko <[email protected]>
switchdev_port_fdb_dumpis used as .ndo_fdb_dump. Its return value is idx, so we cannot return errval.Fixes 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.")Signed-off-by Jiri Pirko <[email protected]>
Quoted 22 lines
--- net/switchdev/switchdev.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)net/switchdev/switchdev.c +1
-5@@ -853,12 +853,8 @@ int switchdev_port_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb, .cb = cb, .idx = idx, }; -int err; - - err =switchdev_port_obj_dump (dev, &dump.obj); -if (err) -return err; +switchdev_port_obj_dump (dev, &dump.obj);return dump.idx; }EXPORT_SYMBOL_GPL (switchdev_port_fdb_dump);
Quoted 7 lines · Jiri Pirko
From: Jiri Pirko <[email protected]>
switchdev_port_fdb_dumpis used as .ndo_fdb_dump. Its return value is idx, so we cannot return errval.Fixes 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.")Signed-off-by Jiri Pirko <[email protected]>
Acked-by Scott Feldman<[email protected]>
From: Jiri Pirko <[email protected]>
Date: Thu, 3 Sep 2015 14:04:17 +0200
Quoted 7 lines
From: Jiri Pirko <[email protected]>
switchdev_port_fdb_dumpis used as .ndo_fdb_dump. Its return value is idx, so we cannot return errval.Fixes 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.")Signed-off-by Jiri Pirko <[email protected]>
Applied, thanks.