Skip to contentSkip to conversation

switchdev: fix return value of switchdev_port_fdb_dump in case of error

PATCH Applied Jiri Pirko 4 participants 4 messages Sep 3, 2015 – Sep 6, 2015

Subsystems (3)
lore
Share & tools
lore

Jiri Pirko

author maintainer
#0 lore raw

PATCH 1/1 switchdev: fix return value of switchdev_port_fdb_dump in case of error

From: Jiri Pirko <[email protected]>

switchdev_port_fdb_dump is used as .ndo_fdb_dump. Its return value is idx, so we cannot return errval.

Fixes 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.")
---
 net/switchdev/switchdev.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
net/switchdev/switchdev.c +1 -5
index 16c1c43..fda38f8 100644
@@ -853,12 +853,8 @@ int switchdev_port_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb,
 		.cb = cb,
 		.idx = idx,
 	};
-	int err;
-
-	err = switchdev_port_obj_dump(dev, &dump.obj);
-	if (err)
-		return err;
 
+	switchdev_port_obj_dump(dev, &dump.obj);
 	return dump.idx;
 }
 EXPORT_SYMBOL_GPL(switchdev_port_fdb_dump);
Signature · 1 line
1.9.3
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Jiri Pirko

From: Jiri Pirko <[email protected]>

switchdev_port_fdb_dump is used as .ndo_fdb_dump. Its return value is idx, so we cannot return errval.

Fixes 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.")
Quoted 22 lines
---
  net/switchdev/switchdev.c | 6 +-----
  1 file changed, 1 insertion(+), 5 deletions(-)
net/switchdev/switchdev.c +1 -5
index 16c1c43..fda38f8 100644
@@ -853,12 +853,8 @@ int switchdev_port_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb,
  		.cb = cb,
  		.idx = idx,
  	};
-	int err;
-
-	err = switchdev_port_obj_dump(dev, &dump.obj);
-	if (err)
-		return err;
 
+	switchdev_port_obj_dump(dev, &dump.obj);
  	return dump.idx;
  }
  EXPORT_SYMBOL_GPL(switchdev_port_fdb_dump);