Skip to contentSkip to conversation

ARM: dts: am57xx-beagle-x15: Update Phy supplies

PATCH In review Nishanth Menon 2 participants 3 messages Sep 3, 2015 – Sep 16, 2015 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: am57xx-beagle-x15: Update Phy supplies

Originally, all the SoC PHY rails were supplied by LDO3. However, as a result of characterization, it was determined that this posed a risk in extreme load conditions. Hence the PHY rails are split between two different LDOs. Update the related node as a result

LDO3/VDDA_1V8_PHYA supplies vdda_usb1, vdda_usb2, vdda_sata, vdda_usb3 LDO4/VDDA_1V8_PHYB supplies vdda_pcie1, vdda_pcie0, vdda_hdmi, vdda_pcie

NOTE: We break compatibility with pre-production boards with this change since, the PMIC LDO4 is disabled at OTP level.

The new configuration is the plan of record and all pre-production boards are supposed to be replaced with the latest boards matching the mentioned configuration.

---
 arch/arm/boot/dts/am57xx-beagle-x15.dts |   13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
arch/arm/boot/dts/am57xx-beagle-x15.dts +11 -2
index 3a05b94f59ed..ede7fb73c717 100644
@@ -432,7 +432,7 @@
 				};
 
 				ldo3_reg: ldo3 {
-					/* VDDA_1V8_PHY */
+					/* VDDA_1V8_PHYA */
 					regulator-name = "ldo3";
 					regulator-min-microvolt = <1800000>;
 					regulator-max-microvolt = <1800000>;
@@ -440,6 +440,15 @@
 					regulator-boot-on;
 				};
 
+				ldo4_reg: ldo4 {
+					/* VDDA_1V8_PHYB */
+					regulator-name = "ldo4";
+					regulator-min-microvolt = <1800000>;
+					regulator-max-microvolt = <1800000>;
+					regulator-always-on;
+					regulator-boot-on;
+				};
+
 				ldo9_reg: ldo9 {
 					/* VDD_RTC */
 					regulator-name = "ldo9";
@@ -681,7 +690,7 @@
 
 &hdmi {
 	status = "ok";
-	vdda-supply = <&ldo3_reg>;
+	vdda-supply = <&ldo4_reg>;
 
 	pinctrl-names = "default";
 	pinctrl-0 = <&hdmi_pins>;
Signature · 1 line
1.7.9.5
#1 lore raw

Hi Tony,

Quoted 11 lines · Nishanth Menon

Originally, all the SoC PHY rails were supplied by LDO3. However, as a result of characterization, it was determined that this posed a risk in extreme load conditions. Hence the PHY rails are split between two different LDOs. Update the related node as a result

LDO3/VDDA_1V8_PHYA supplies vdda_usb1, vdda_usb2, vdda_sata, vdda_usb3 LDO4/VDDA_1V8_PHYB supplies vdda_pcie1, vdda_pcie0, vdda_hdmi, vdda_pcie

NOTE: We break compatibility with pre-production boards with this change since, the PMIC LDO4 is disabled at OTP level.

Quoted 6 lines

The new configuration is the plan of record and all pre-production boards are supposed to be replaced with the latest boards matching the mentioned configuration.

---

Gentle ping. Some very few 10 something boards have been created and stopped production till the latest modifications were done (PMIC USB interrupt, LDO4 etc) - and all of those boards are now getting scrapped.. If there are any (as per tracking information, there should not be any), TI should be contacted to have them replaced.

Is it possible for us to consider this patch in 4.3 cycle - given that we are this close, might have been great to see 4.3 vanilla function on the production platform.

Quoted 42 lines
 arch/arm/boot/dts/am57xx-beagle-x15.dts |   13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
arch/arm/boot/dts/am57xx-beagle-x15.dts +11 -2
index 3a05b94f59ed..ede7fb73c717 100644
@@ -432,7 +432,7 @@
 				};
 
 				ldo3_reg: ldo3 {
-					/* VDDA_1V8_PHY */
+					/* VDDA_1V8_PHYA */
 					regulator-name = "ldo3";
 					regulator-min-microvolt = <1800000>;
 					regulator-max-microvolt = <1800000>;
@@ -440,6 +440,15 @@
 					regulator-boot-on;
 				};
 
+				ldo4_reg: ldo4 {
+					/* VDDA_1V8_PHYB */
+					regulator-name = "ldo4";
+					regulator-min-microvolt = <1800000>;
+					regulator-max-microvolt = <1800000>;
+					regulator-always-on;
+					regulator-boot-on;
+				};
+
 				ldo9_reg: ldo9 {
 					/* VDD_RTC */
 					regulator-name = "ldo9";
@@ -681,7 +690,7 @@
 
 &hdmi {
 	status = "ok";
-	vdda-supply = <&ldo3_reg>;
+	vdda-supply = <&ldo4_reg>;
 
 	pinctrl-names = "default";
 	pinctrl-0 = <&hdmi_pins>;
Signature · 2 lines
Regards,
Nishanth Menon
#2 lore raw
Quoted 18 lines · Nishanth Menon

Hi Tony,

Quoted 15 lines · Nishanth Menon

Originally, all the SoC PHY rails were supplied by LDO3. However, as a result of characterization, it was determined that this posed a risk in extreme load conditions. Hence the PHY rails are split between two different LDOs. Update the related node as a result

LDO3/VDDA_1V8_PHYA supplies vdda_usb1, vdda_usb2, vdda_sata, vdda_usb3 LDO4/VDDA_1V8_PHYB supplies vdda_pcie1, vdda_pcie0, vdda_hdmi, vdda_pcie

NOTE: We break compatibility with pre-production boards with this change since, the PMIC LDO4 is disabled at OTP level.

The new configuration is the plan of record and all pre-production boards are supposed to be replaced with the latest boards matching the mentioned configuration.

Quoted 8 lines
Quoted 2 lines

---

Gentle ping. Some very few 10 something boards have been created and stopped production till the latest modifications were done (PMIC USB interrupt, LDO4 etc) - and all of those boards are now getting scrapped.. If there are any (as per tracking information, there should not be any), TI should be contacted to have them replaced.

Sounds OK to me as they are TI internal protos.

Quoted 3 lines

Is it possible for us to consider this patch in 4.3 cycle - given that we are this close, might have been great to see 4.3 vanilla function on the production platform.

Applying into omap-for-v4.3/fixes thanks.

Tony