Skip to contentSkip to conversation

sf: params: Add IS25LP032 part support

PATCH New Jagan Teki 2 participants 8 messages Sep 4, 2015 – Sep 14, 2015

Subsystems (2)
lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

PATCH 1/4 sf: params: Add IS25LP032 part support

Added support for IS25LP032 flash part.

Cc Siva Durga Prasad Paladugu <[email protected]>
Cc Michal Simek <[email protected]>
---
 drivers/mtd/spi/sf_params.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi/sf_params.c +3 -0
index 4a4a3af..184ba9c 100644
@@ -34,6 +34,9 @@ const struct spi_flash_params spi_flash_params_table[] = {
 	{"GD25Q64B",	   0xc84017, 0x0,	64 * 1024,   128, RD_NORM,		    SECT_4K},
 	{"GD25LQ32",	   0xc86016, 0x0,	64 * 1024,    64, RD_NORM,		    SECT_4K},
 #endif
+#ifdef CONFIG_SPI_FLASH_ISSI		/* ISSI */
+	{"IS25LP032",	   0x9d6016, 0x0,	64 * 1024,    64, RD_NORM,			  0},
+#endif
 #ifdef CONFIG_SPI_FLASH_MACRONIX	/* MACRONIX */
 	{"MX25L2006E",	   0xc22012, 0x0,	64 * 1024,     4, RD_NORM,			  0},
 	{"MX25L4005",	   0xc22013, 0x0,	64 * 1024,     8, RD_NORM,			  0},
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/4 sf: params: Add IS25LP032 part support

Hi Siva,

Quoted 6 lines · Jagan Teki

Added support for IS25LP032 flash part.

Cc Siva Durga Prasad Paladugu <[email protected]>
Cc Michal Simek <[email protected]>

---

Can you test this parts?

Quoted 18 lines
 drivers/mtd/spi/sf_params.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi/sf_params.c +3 -1
index 4a4a3af..184ba9c 100644
@@ -34,6 +34,9 @@ const struct spi_flash_params spi_flash_params_table[] = {
        {"GD25Q64B",       0xc84017, 0x0,       64 * 1024,   128, RD_NORM,                  SECT_4K},
        {"GD25LQ32",       0xc86016, 0x0,       64 * 1024,    64, RD_NORM,                  SECT_4K},
 #endif
+#ifdef CONFIG_SPI_FLASH_ISSI           /* ISSI */
+       {"IS25LP032",      0x9d6016, 0x0,       64 * 1024,    64, RD_NORM,                        0},
+#endif
 #ifdef CONFIG_SPI_FLASH_MACRONIX       /* MACRONIX */
        {"MX25L2006E",     0xc22012, 0x0,       64 * 1024,     4, RD_NORM,                        0},
        {"MX25L4005",      0xc22013, 0x0,       64 * 1024,     8, RD_NORM,                        0},
--
Quoted 2 lines

1.9.1

thanks!

Signature · 1 line
Jagan | openedev.
#2 lore raw

PATCH 1/4 sf: params: Add IS25LP032 part support

Hi Jagan,

Quoted 10 lines

-----Original Message-----
From: Jagan Teki [mailto:jteki at openedev.com]
Sent: Tuesday, September 08, 2015 2:52 PM
To: u-boot at lists.denx.de
Cc: Jagan Teki; Siva Durga Prasad Paladugu; Michal Simek
Subject: Re: [PATCH 1/4] sf: params: Add IS25LP032 part support

Hi Siva,

On 4 September 2015 at 18:33, Jagan Teki <[email protected]> wrote:

Quoted 8 lines
Quoted 6 lines

Added support for IS25LP032 flash part.

Cc Siva Durga Prasad Paladugu <[email protected]>
Cc Michal Simek <[email protected]>

---

Can you test this parts?

I can't test this as these parts are not mounted on any of our boards now, but I can say that this won't work straight away and needs another patch I will be sending you soon.

Regards,
Siva

Quoted 31 lines

drivers/mtd/spi/sf_params.c const struct spi_flash_params

Quoted 9 lines
 drivers/mtd/spi/sf_params.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi/sf_params.c +0 -0
index 4a4a3af..184ba9c 100644
@@ -34,6 +34,9 @@ const struct spi_flash_params

spi_flash_params_table[] = {

drivers/mtd/spi/sf_params.c const struct spi_flash_params · line 34

Quoted 1 line
drivers/mtd/spi/sf_params.c +0 -0
        {"GD25Q64B",       0xc84017, 0x0,       64 * 1024,   128, RD_NORM,

SECT_4K},

drivers/mtd/spi/sf_params.c const struct spi_flash_params · line 35

Quoted 1 line
drivers/mtd/spi/sf_params.c +0 -0
        {"GD25LQ32",       0xc86016, 0x0,       64 * 1024,    64, RD_NORM,

SECT_4K},

drivers/mtd/spi/sf_params.c const struct spi_flash_params spi_flash_params_table[] = {

Quoted 3 lines
drivers/mtd/spi/sf_params.c +2 -0
 #endif
+#ifdef CONFIG_SPI_FLASH_ISSI           /* ISSI */
+       {"IS25LP032",      0x9d6016, 0x0,       64 * 1024,    64, RD_NORM,

0},

drivers/mtd/spi/sf_params.c const struct spi_flash_params spi_flash_params_table[] = {

Quoted 3 lines
drivers/mtd/spi/sf_params.c +1 -0
+#endif
 #ifdef CONFIG_SPI_FLASH_MACRONIX       /* MACRONIX */
        {"MX25L2006E",     0xc22012, 0x0,       64 * 1024,     4, RD_NORM,

0},

drivers/mtd/spi/sf_params.c const struct spi_flash_params · line 42

Quoted 1 line
drivers/mtd/spi/sf_params.c +0 -0
        {"MX25L4005",      0xc22013, 0x0,       64 * 1024,     8, RD_NORM,

0},

Quoted 3 lines

--
1.9.1

thanks!
--
Jagan | openedev.

author
#3 lore raw

PATCH 1/4 sf: params: Add IS25LP032 part support

Hi Siva,

Quoted 19 lines · Siva Durga Prasad Paladugu

Hi Jagan,

Quoted 17 lines

-----Original Message-----
From: Jagan Teki [mailto:jteki at openedev.com]
Sent: Tuesday, September 08, 2015 2:52 PM
To: u-boot at lists.denx.de
Cc: Jagan Teki; Siva Durga Prasad Paladugu; Michal Simek
Subject: Re: [PATCH 1/4] sf: params: Add IS25LP032 part support

Hi Siva,

Quoted 6 lines · Jagan Teki

Added support for IS25LP032 flash part.

Cc Siva Durga Prasad Paladugu <[email protected]>
Cc Michal Simek <[email protected]>

---

Quoted 4 lines
Quoted 1 line

Can you test this parts?

I can't test this as these parts are not mounted on any of our boards now, but I can say that this won't work straight away and needs another patch I will be sending you soon.

Does this means ISSI must require to set quad, bcz these patches I never enable quad on fast read and page program.

Quoted 32 lines
Quoted 32 lines

drivers/mtd/spi/sf_params.c const struct spi_flash_params

Quoted 10 lines

 drivers/mtd/spi/sf_params.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/mtd/spi/sf_params.c +0 -0
index 4a4a3af..184ba9c 100644
@@ -34,6 +34,9 @@ const struct spi_flash_params

spi_flash_params_table[] = {

drivers/mtd/spi/sf_params.c const struct spi_flash_params · line 34

Quoted 1 line
drivers/mtd/spi/sf_params.c +0 -0
        {"GD25Q64B",       0xc84017, 0x0,       64 * 1024,   128, RD_NORM,

SECT_4K},

drivers/mtd/spi/sf_params.c const struct spi_flash_params · line 35

Quoted 1 line
drivers/mtd/spi/sf_params.c +0 -0
        {"GD25LQ32",       0xc86016, 0x0,       64 * 1024,    64, RD_NORM,

SECT_4K},

drivers/mtd/spi/sf_params.c const struct spi_flash_params spi_flash_params_table[] = {

Quoted 3 lines
drivers/mtd/spi/sf_params.c +2 -0
 #endif
+#ifdef CONFIG_SPI_FLASH_ISSI           /* ISSI */
+       {"IS25LP032",      0x9d6016, 0x0,       64 * 1024,    64, RD_NORM,

0},

drivers/mtd/spi/sf_params.c const struct spi_flash_params spi_flash_params_table[] = {

Quoted 3 lines
drivers/mtd/spi/sf_params.c +1 -0
+#endif
 #ifdef CONFIG_SPI_FLASH_MACRONIX       /* MACRONIX */
        {"MX25L2006E",     0xc22012, 0x0,       64 * 1024,     4, RD_NORM,

0},

drivers/mtd/spi/sf_params.c const struct spi_flash_params · line 42

Quoted 1 line
drivers/mtd/spi/sf_params.c +0 -0
        {"MX25L4005",      0xc22013, 0x0,       64 * 1024,     8, RD_NORM,

0},

Quoted 3 lines

--
1.9.1

thanks!
--
Jagan | openedev.

Signature · 1 line
Jagan | openedev.
#4 lore raw

PATCH 1/4 sf: params: Add IS25LP032 part support

Hi Jagan,

Quoted 30 lines

-----Original Message-----
From: Jagan Teki [mailto:jteki at openedev.com]
Sent: Monday, September 14, 2015 12:11 PM
To: Siva Durga Prasad Paladugu
Cc: u-boot at lists.denx.de; Michal Simek
Subject: Re: [PATCH 1/4] sf: params: Add IS25LP032 part support

Hi Siva,

Quoted 19 lines · Siva Durga Prasad Paladugu

Hi Jagan,

Quoted 17 lines

-----Original Message-----
From: Jagan Teki [mailto:jteki at openedev.com]
Sent: Tuesday, September 08, 2015 2:52 PM
To: u-boot at lists.denx.de
Cc: Jagan Teki; Siva Durga Prasad Paladugu; Michal Simek
Subject: Re: [PATCH 1/4] sf: params: Add IS25LP032 part support

Hi Siva,

Quoted 6 lines · Jagan Teki

Added support for IS25LP032 flash part.

Cc Siva Durga Prasad Paladugu <[email protected]>
Cc Michal Simek <[email protected]>

---

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Can you test this parts?

I can't test this as these parts are not mounted on any of our boards now, but I can say that this won't work straight away and needs another

patch I will be sending you soon.

Does this means ISSI must require to set quad, bcz these patches I never enable quad on fast read and page program.

Yeah, I already sent patch to set qeb, this is just for the quad commands to work. Any way I just realized that in your patches , you didn?t enabled quad then its fine. If you enable quad then only the quad enable patch is required, otherwise its fine.

Regards,
Siva

Quoted 30 lines
Quoted 30 lines
Quoted 30 lines

drivers/mtd/spi/sf_params.c const struct spi_flash_params

Quoted 11 lines


 drivers/mtd/spi/sf_params.c | 3 +++
 1 file changed, 3 insertions(+)
(quoted diff) +0 -0

b/drivers/mtd/spi/sf_params.c index 4a4a3af..184ba9c 100644

drivers/mtd/spi/sf_params.c +0 -0
@@ -34,6 +34,9 @@ const struct spi_flash_params

spi_flash_params_table[] = {

drivers/mtd/spi/sf_params.c const struct spi_flash_params · line 34

Quoted 1 line
drivers/mtd/spi/sf_params.c +0 -0
        {"GD25Q64B",       0xc84017, 0x0,       64 * 1024,   128, RD_NORM,

SECT_4K},

drivers/mtd/spi/sf_params.c const struct spi_flash_params · line 35

Quoted 1 line
drivers/mtd/spi/sf_params.c +0 -0
        {"GD25LQ32",       0xc86016, 0x0,       64 * 1024,    64, RD_NORM,

SECT_4K},

drivers/mtd/spi/sf_params.c const struct spi_flash_params spi_flash_params_table[] = {

Quoted 3 lines
drivers/mtd/spi/sf_params.c +2 -0
 #endif
+#ifdef CONFIG_SPI_FLASH_ISSI           /* ISSI */
+       {"IS25LP032",      0x9d6016, 0x0,       64 * 1024,    64, RD_NORM,

0},

drivers/mtd/spi/sf_params.c const struct spi_flash_params spi_flash_params_table[] = {

Quoted 3 lines
drivers/mtd/spi/sf_params.c +1 -0
+#endif
 #ifdef CONFIG_SPI_FLASH_MACRONIX       /* MACRONIX */
        {"MX25L2006E",     0xc22012, 0x0,       64 * 1024,     4, RD_NORM,

0},

drivers/mtd/spi/sf_params.c const struct spi_flash_params · line 42

Quoted 1 line
drivers/mtd/spi/sf_params.c +0 -0
        {"MX25L4005",      0xc22013, 0x0,       64 * 1024,     8, RD_NORM,

0},

Quoted 3 lines

--
1.9.1

Quoted 8 lines
Quoted 3 lines
Quoted 3 lines

thanks!
--
Jagan | openedev.

--
Jagan | openedev.

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.

author
#5 lore raw

PATCH 2/4 sf: params: Add IS25LP064 part support

In reply to Jagan Teki

Added support for IS25LP064 flash part.

Cc Siva Durga Prasad Paladugu <[email protected]>
Cc Michal Simek <[email protected]>
---
 drivers/mtd/spi/sf_params.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/spi/sf_params.c +1 -0
index 184ba9c..c3c38ee 100644
@@ -36,6 +36,7 @@ const struct spi_flash_params spi_flash_params_table[] = {
 #endif
 #ifdef CONFIG_SPI_FLASH_ISSI		/* ISSI */
 	{"IS25LP032",	   0x9d6016, 0x0,	64 * 1024,    64, RD_NORM,			  0},
+	{"IS25LP064",	   0x9d6017, 0x0,	64 * 1024,   128, RD_NORM,			  0},
 #endif
 #ifdef CONFIG_SPI_FLASH_MACRONIX	/* MACRONIX */
 	{"MX25L2006E",	   0xc22012, 0x0,	64 * 1024,     4, RD_NORM,			  0},
Signature · 1 line
1.9.1
author
#6 lore raw

PATCH 3/4 sf: params: Add IS25LP128 part support

In reply to Jagan Teki

Added support for IS25LP128 flash part.

Cc Siva Durga Prasad Paladugu <[email protected]>
Cc Michal Simek <[email protected]>
---
 drivers/mtd/spi/sf_params.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/spi/sf_params.c +1 -0
index c3c38ee..bb731ea 100644
@@ -37,6 +37,7 @@ const struct spi_flash_params spi_flash_params_table[] = {
 #ifdef CONFIG_SPI_FLASH_ISSI		/* ISSI */
 	{"IS25LP032",	   0x9d6016, 0x0,	64 * 1024,    64, RD_NORM,			  0},
 	{"IS25LP064",	   0x9d6017, 0x0,	64 * 1024,   128, RD_NORM,			  0},
+	{"IS25LP128",	   0x9d6018, 0x0,	64 * 1024,   256, RD_NORM,			  0},
 #endif
 #ifdef CONFIG_SPI_FLASH_MACRONIX	/* MACRONIX */
 	{"MX25L2006E",	   0xc22012, 0x0,	64 * 1024,     4, RD_NORM,			  0},
Signature · 1 line
1.9.1
author
#7 lore raw

PATCH 4/4 zynq-common: Enable ISSI SPI-NOR flash support

In reply to Jagan Teki

This patch enabled CONFIG_SPI_FLASH_ISSI for qspi on zynq boards.

Cc Siva Durga Prasad Paladugu <[email protected]>
Cc Michal Simek <[email protected]>
---
 include/configs/zynq-common.h | 1 +
 1 file changed, 1 insertion(+)
include/configs/zynq-common.h +1 -0
index f6dd03b..35a3a0a 100644
@@ -75,6 +75,7 @@
 /* QSPI */
 #ifdef CONFIG_ZYNQ_QSPI
 # define CONFIG_SF_DEFAULT_SPEED	30000000
+# define CONFIG_SPI_FLASH_ISSI
 # define CONFIG_SPI_FLASH_SPANSION
 # define CONFIG_SPI_FLASH_STMICRO
 # define CONFIG_SPI_FLASH_WINBOND
Signature · 1 line
1.9.1