mkefidisk: Create interactive menu for the script
PATCH 1/1 mkefidisk: Create interactive menu for the script
Differences from v1:
- Now it will show only unmounted devices as Saul Wold has suggested
- Commit message changed as Saul Wold has suggested
Bruno Bottazzini (1):
mkefidisk: Create interactive menu for the script
scripts/contrib/mkefidisk.sh | 63 ++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 58 insertions(+), 5 deletions(-)
Signature · 1 line
2.5.0
PATCH 1/1 mkefidisk: Create interactive menu for the script
If it is passed only the image parameter, it will show some interactive options to help to conclude the script.
With this patch it will detect devices available in the machine, asking to choose what it is wanted to be flashed.
it will suggest the target device. If it is a SD card the suggestion is /dev/mmcblk0. If it is a pendrive it will suggest to use /dev/sda.
--- scripts/contrib/mkefidisk.sh | 63 ++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 58 insertions(+), 5 deletions(-)
scripts/contrib/mkefidisk.sh +58 -5
@@ -152,8 +152,55 @@ unmount() { # Parse and validate arguments # if [ $# -lt 3 ] || [ $# -gt 4 ]; then - usage - exit 1 + if [ $# -eq 1 ]; then + AVAILABLE_DISK=`lsblk | grep "disk" | cut -f 1 -d " "` + X=0 + for disk in `echo $AVAILABLE_DISK`; do + mounted=`blkid -o list | grep "/dev/$disk" | grep "not mounted"` + if [ -n "$mounted" ]; then + UNMOUNTED_AVAILABLES="$UNMOUNTED_AVAILABLES /dev/$disk\n" + info "$X - /dev/$disk" + X=`expr $X + 1` + fi + done + if [ $X -eq 0 ]; then + die "No unmounted device found." + fi + read -p "Choose unmounted device number: " DISK_NUMBER + X=0 + for line in `echo $UNMOUNTED_AVAILABLES`; do + if [ $DISK_NUMBER -eq $X ]; then + DISK_TO_BE_FLASHED=$line + break + else + X=`expr $X + 1` + fi + done + if [ -z "$DISK_TO_BE_FLASHED" ]; then + die "Option \"$DISK_NUMBER\" is invalid. Choose a valid option" + else + if [ -z `echo $DISK_TO_BE_FLASHED | grep "mmc"` ]; then + TARGET_TO_BE_BOOT="/dev/sda" + else + TARGET_TO_BE_BOOT="/dev/mmcblk0" + fi + fi + echo "" + echo "Choose a name of the device that will be boot from" + echo -n "Recommended name is: " + info "$TARGET_TO_BE_BOOT\n" + read -p "Is target device okay? [y/N]: " RESPONSE + if [ "$RESPONSE" != "y" ]; then + read -p "Choose target device name: " TARGET_TO_BE_BOOT + fi + echo "" + if [ -z "$TARGET_TO_BE_BOOT" ]; then + die "Error: choose a valid target name" + fi + else + usage + exit 1 + fi fi if [ "$1" = "-v" ]; then
@@ -162,9 +209,15 @@ if [ "$1" = "-v" ]; then shift fi -DEVICE=$1 -HDDIMG=$2 -TARGET_DEVICE=$3 +if [ -z "$AVAILABLE_DISK" ]; then + DEVICE=$1 + HDDIMG=$2 + TARGET_DEVICE=$3 +else + DEVICE=$DISK_TO_BE_FLASHED + HDDIMG=$1 + TARGET_DEVICE=$TARGET_TO_BE_BOOT +fi LINK=$(readlink $DEVICE) if [ $? -eq 0 ]; then
Signature · 1 line
2.5.0
Ping
Quoted 95 lines · Bruno Bottazzini
If it is passed only the image parameter, it will show some interactive options to help to conclude the script.
With this patch it will detect devices available in the machine, asking to choose what it is wanted to be flashed.
it will suggest the target device. If it is a SD card the suggestion is
/dev/mmcblk0. If it is a pendrive it will suggest to use/dev/sda.Signed-off-by Bruno Bottazzini <[email protected]>--- scripts/contrib/mkefidisk.sh | 63 ++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 58 insertions(+), 5 deletions(-)scripts/contrib/mkefidisk.sh +58
-5@@ -152,8 +152,55 @@ unmount() { # Parse and validate arguments # if [ $# -lt 3 ] || [ $# -gt 4 ]; then - usage - exit 1 + if [ $# -eq 1 ]; then + AVAILABLE_DISK=`lsblk | grep "disk" | cut -f 1 -d " "` + X=0 + for disk in `echo $AVAILABLE_DISK`; do + mounted=`blkid -o list | grep "/dev/$disk" | grep "not mounted"` + if [ -n "$mounted" ]; then + UNMOUNTED_AVAILABLES="$UNMOUNTED_AVAILABLES /dev/$disk\n" + info "$X - /dev/$disk" + X=`expr $X + 1` + fi + done + if [ $X -eq 0 ]; then + die "No unmounted device found." + fi + read -p "Choose unmounted device number: " DISK_NUMBER + X=0 + for line in `echo $UNMOUNTED_AVAILABLES`; do + if [ $DISK_NUMBER -eq $X ]; then + DISK_TO_BE_FLASHED=$line + break + else + X=`expr $X + 1` + fi + done + if [ -z "$DISK_TO_BE_FLASHED" ]; then + die "Option \"$DISK_NUMBER\" is invalid. Choose a valid option" + else + if [ -z `echo $DISK_TO_BE_FLASHED | grep "mmc"` ]; then + TARGET_TO_BE_BOOT="/dev/sda" + else + TARGET_TO_BE_BOOT="/dev/mmcblk0" + fi + fi + echo "" + echo "Choose a name of the device that will be boot from" + echo -n "Recommended name is: " + info "$TARGET_TO_BE_BOOT\n" + read -p "Is target device okay? [y/N]: " RESPONSE + if [ "$RESPONSE" != "y" ]; then + read -p "Choose target device name: " TARGET_TO_BE_BOOT + fi + echo "" + if [ -z "$TARGET_TO_BE_BOOT" ]; then + die "Error: choose a valid target name" + fi + else + usage + exit 1 + fi fi if [ "$1" = "-v" ]; then@@ -162,9 +209,15 @@ if [ "$1" = "-v" ]; then shift fi -DEVICE=$1 -HDDIMG=$2 -TARGET_DEVICE=$3 +if [ -z "$AVAILABLE_DISK" ]; then + DEVICE=$1 + HDDIMG=$2 + TARGET_DEVICE=$3 +else + DEVICE=$DISK_TO_BE_FLASHED + HDDIMG=$1 + TARGET_DEVICE=$TARGET_TO_BE_BOOT +fi LINK=$(readlink $DEVICE) if [ $? -eq 0 ]; then
Quoted 19 lines · Bruno Bottazzini
If it is passed only the image parameter, it will show some interactive options to help to conclude the script.
With this patch it will detect devices available in the machine, asking to choose what it is wanted to be flashed.
it will suggest the target device. If it is a SD card the suggestion is
/dev/mmcblk0. If it is a pendrive it will suggest to use/dev/sda.Signed-off-by Bruno Bottazzini <[email protected]>--- scripts/contrib/mkefidisk.sh | 63 ++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 58 insertions(+), 5 deletions(-)scripts/contrib/mkefidisk.sh +0
-0
scripts/contrib/mkefidisk.sh unmount() { · line 159
Quoted 10 lines
scripts/contrib/mkefidisk.sh +5
-2@@ -152,8 +152,55 @@ unmount() { # Parse and validate arguments # if [ $# -lt 3 ] || [ $# -gt 4 ]; then - usage - exit 1 + if [ $# -eq 1 ]; then + AVAILABLE_DISK=`lsblk | grep "disk" | cut -f 1 -d " "` + X=0 + for disk in `echo $AVAILABLE_DISK`; do + mounted=`blkid -o list | grep "/dev/$disk" | grep "not mounted"`
Is there any way to not call blkid multiple time (ie save the output and use it once?
Are the lsblk and blkid commands guaranteed to be installed on most machines?
Also this seems to have matched my root disk, which again concerns me, I am still not convinced that a selection system like this is safe.
scripts/contrib/mkefidisk.sh unmount() { · line 161
Quoted 2 lines
scripts/contrib/mkefidisk.sh +2
-0+ if [ -n "$mounted" ]; then + UNMOUNTED_AVAILABLES="$UNMOUNTED_AVAILABLES /dev/$disk\n"
I think the \n is not needed here, what shell are you using, with Bash I get the following output:
0 - /dev/sda
1 - /dev/sdb
2 - /dev/mmcblk0
Choose unmounted device number: 1
Choose a name of the device that will be boot from Recommended name is: /dev/sda\n
Is target device okay? [y/N]: y
Usage: mkefidisk.sh [-v] DEVICE HDDIMG TARGET_DEVICE
-v: Verbose debug
DEVICE: The device to write the image to, e.g. /dev/sdh
HDDIMG: The hddimg file to generate the efi disk from
TARGET_DEVICE: The device the target will boot from, e.g./dev/mmcblk0
Device /dev/sdb\n cannot be found
Note the \n above in the choose a name and then the trailing \n here with the device not being found.
Quoted 20 lines
scripts/contrib/mkefidisk.sh +20
-0+ info "$X - /dev/$disk" + X=`expr $X + 1` + fi + done + if [ $X -eq 0 ]; then + die "No unmounted device found." + fi + read -p "Choose unmounted device number: " DISK_NUMBER + X=0 + for line in `echo $UNMOUNTED_AVAILABLES`; do + if [ $DISK_NUMBER -eq $X ]; then + DISK_TO_BE_FLASHED=$line + break + else + X=`expr $X + 1` + fi + done + if [ -z "$DISK_TO_BE_FLASHED" ]; then + die "Option \"$DISK_NUMBER\" is invalid. Choose a valid option" + else
scripts/contrib/mkefidisk.sh unmount() { · line 191
Quoted 10 lines
scripts/contrib/mkefidisk.sh +10
-0+ if [ -z `echo $DISK_TO_BE_FLASHED | grep "mmc"` ]; then + TARGET_TO_BE_BOOT="/dev/sda" + else + TARGET_TO_BE_BOOT="/dev/mmcblk0" + fi + fi + echo "" + echo "Choose a name of the device that will be boot from" + echo -n "Recommended name is: " + info "$TARGET_TO_BE_BOOT\n"
You are still outputting the \n here
Quoted 22 lines
scripts/contrib/mkefidisk.sh +12
-3+ read -p "Is target device okay? [y/N]: " RESPONSE + if [ "$RESPONSE" != "y" ]; then + read -p "Choose target device name: " TARGET_TO_BE_BOOT + fi + echo "" + if [ -z "$TARGET_TO_BE_BOOT" ]; then + die "Error: choose a valid target name" + fi + else + usage + exit 1 + fi fi if [ "$1" = "-v" ]; then@@ -162,9 +209,15 @@ if [ "$1" = "-v" ]; then shift fi -DEVICE=$1 -HDDIMG=$2 -TARGET_DEVICE=$3
scripts/contrib/mkefidisk.sh if [ "$1" = "-v" ]; then · line 221
Quoted 10 lines
scripts/contrib/mkefidisk.sh +9
-0+if [ -z "$AVAILABLE_DISK" ]; then + DEVICE=$1 + HDDIMG=$2 + TARGET_DEVICE=$3 +else + DEVICE=$DISK_TO_BE_FLASHED + HDDIMG=$1 + TARGET_DEVICE=$TARGET_TO_BE_BOOT +fi
This change I like, if done with checking for 2 parameter (image and disk to flash, the 3 paramter can be determined as you have with best guess of /dev/sda if it's an sd and mmc if it's a /dev/mmc flash device.
Sau!
Quoted 3 lines
scripts/contrib/mkefidisk.sh +0
-0LINK=$(readlink $DEVICE) if [ $? -eq 0 ]; then
Quoted 24 lines · Saul Wold
Quoted 23 lines · Bruno Bottazzini
If it is passed only the image parameter, it will show some interactive options to help to conclude the script.
With this patch it will detect devices available in the machine, asking to choose what it is wanted to be flashed.
it will suggest the target device. If it is a SD card the suggestion is
/dev/mmcblk0. If it is a pendrive it will suggest to use/dev/sda.Signed-off-by Bruno Bottazzini <[email protected]>--- scripts/contrib/mkefidisk.sh | 63 ++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 58 insertions(+), 5 deletions(-)scripts/contrib/mkefidisk.sh +0
-1@@ -152,8 +152,55 @@ unmount() { # Parse and validate arguments # if [ $# -lt 3 ] || [ $# -gt 4 ]; then - usage
Quoted 8 lines
scripts/contrib/mkefidisk.sh unmount() { · line 159
Quoted 6 lines
scripts/contrib/mkefidisk.sh +5
-1- exit 1 + if [ $# -eq 1 ]; then + AVAILABLE_DISK=`lsblk | grep "disk" | cut -f 1 -d " "` + X=0 + for disk in `echo $AVAILABLE_DISK`; do + mounted=`blkid -o list | grep "/dev/$disk" | grep "not mounted"`Is there any way to not call blkid multiple time (ie save the output and use it once?
Unfortunately no, both outputs are different.
Quoted 4 lines
Are the lsblk and blkid commands guaranteed to be installed on most machines?
I double checked it before sending this patch and the answer was yes.
Quoted 3 lines
Also this seems to have matched my root disk, which again concerns me, I am still not convinced that a selection system like this is safe.
This is odd. My output shows only unmounted disks.
Quoted 11 lines
scripts/contrib/mkefidisk.sh unmount() { · line 161
Quoted 3 lines
scripts/contrib/mkefidisk.sh +2
-0+ if [ -n "$mounted" ]; then + UNMOUNTED_AVAILABLES="$UNMOUNTED_AVAILABLES /dev/$disk\n"I think the \n is not needed here, what shell are you using, with Bash I get the following output:
0 -
/dev/sda
1 -/dev/sdb
2 -/dev/mmcblk0
Choose unmounted device number: 1
This output is strange mine shows only (without sda and sdb which i do have them also, but mounted):
contrib > ./mkefidisk.sh image
0 - /dev/mmcblk0
Choose unmounted device number:
Are you sure you have updated the script with the changes? What distro are you using?
Quoted 13 lines
Choose a name of the device that will be boot from Recommended name is: /dev/sda\n
Is target device okay? [y/N]: yUsage:
mkefidisk.sh[-v] DEVICE HDDIMGTARGET_DEVICE
-v: Verbose debug
DEVICE: The device to write the image to, e.g./dev/sdh
HDDIMG: The hddimg file to generate the efi disk from
TARGET_DEVICE: The device the target will boot from, e.g./dev/mmcblk0
Device /dev/sdb\n cannot be found
Quoted 2 lines
Note the \n above in the choose a name and then the trailing \n here with the device not being found.
You are right I am removing \n. Strangely here it works perfectly:
0 - /dev/sdc
1 - /dev/mmcblk0
Choose unmounted device number: 1
Choose a name of the device that will be boot from Recommended name is: /dev/mmcblk0
Is target device okay? [y/N]: y
Quoted 34 lines
Quoted 23 lines
scripts/contrib/mkefidisk.sh +20
-0+ info "$X - /dev/$disk" + X=`expr $X + 1` + fi + done + if [ $X -eq 0 ]; then + die "No unmounted device found." + fi + read -p "Choose unmounted device number: " DISK_NUMBER + X=0 + for line in `echo $UNMOUNTED_AVAILABLES`; do + if [ $DISK_NUMBER -eq $X ]; then + DISK_TO_BE_FLASHED=$line + break + else + X=`expr $X + 1` + fi + done + if [ -z "$DISK_TO_BE_FLASHED" ]; then + die "Option \"$DISK_NUMBER\" is invalid. Choose a valid option" + elsescripts/contrib/mkefidisk.sh unmount() { · line 191
Quoted 10 lines
scripts/contrib/mkefidisk.sh +10
-0+ if [ -z `echo $DISK_TO_BE_FLASHED | grep "mmc"` ]; then + TARGET_TO_BE_BOOT="/dev/sda" + else + TARGET_TO_BE_BOOT="/dev/mmcblk0" + fi + fi + echo "" + echo "Choose a name of the device that will be boot from" + echo -n "Recommended name is: " + info "$TARGET_TO_BE_BOOT\n"
Quoted 1 line
You are still outputting the \n here
Removed too
Thank you a lot,
Bruno
Quoted 43 lines
Quoted 23 lines
scripts/contrib/mkefidisk.sh +12
-3+ read -p "Is target device okay? [y/N]: " RESPONSE + if [ "$RESPONSE" != "y" ]; then + read -p "Choose target device name: " TARGET_TO_BE_BOOT + fi + echo "" + if [ -z "$TARGET_TO_BE_BOOT" ]; then + die "Error: choose a valid target name" + fi + else + usage + exit 1 + fi fi if [ "$1" = "-v" ]; then@@ -162,9 +209,15 @@ if [ "$1" = "-v" ]; then shift fi -DEVICE=$1 -HDDIMG=$2 -TARGET_DEVICE=$3scripts/contrib/mkefidisk.sh if [ "$1" = "-v" ]; then · line 221
Quoted 10 lines
scripts/contrib/mkefidisk.sh +9
-0+if [ -z "$AVAILABLE_DISK" ]; then + DEVICE=$1 + HDDIMG=$2 + TARGET_DEVICE=$3 +else + DEVICE=$DISK_TO_BE_FLASHED + HDDIMG=$1 + TARGET_DEVICE=$TARGET_TO_BE_BOOT +fiThis change I like, if done with checking for 2 parameter (image and disk to flash, the 3 paramter can be determined as you have with best guess of
/dev/sdaif it's an sd and mmc if it's a/dev/mmcflash device.Sau!
Quoted 3 lines
scripts/contrib/mkefidisk.sh +0
-0LINK=$(readlink $DEVICE) if [ $? -eq 0 ]; then
Quoted 34 lines · Bruno
Quoted 24 lines · Saul Wold
Quoted 23 lines · Bruno Bottazzini
If it is passed only the image parameter, it will show some interactive options to help to conclude the script.
With this patch it will detect devices available in the machine, asking to choose what it is wanted to be flashed.
it will suggest the target device. If it is a SD card the suggestion is
/dev/mmcblk0. If it is a pendrive it will suggest to use/dev/sda.Signed-off-by Bruno Bottazzini <[email protected]>--- scripts/contrib/mkefidisk.sh | 63 ++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 58 insertions(+), 5 deletions(-)scripts/contrib/mkefidisk.sh +0
-1@@ -152,8 +152,55 @@ unmount() { # Parse and validate arguments # if [ $# -lt 3 ] || [ $# -gt 4 ]; then - usageQuoted 8 lines
scripts/contrib/mkefidisk.sh unmount() { · line 159
Quoted 6 lines
scripts/contrib/mkefidisk.sh +5
-1- exit 1 + if [ $# -eq 1 ]; then + AVAILABLE_DISK=`lsblk | grep "disk" | cut -f 1 -d " "` + X=0 + for disk in `echo $AVAILABLE_DISK`; do + mounted=`blkid -o list | grep "/dev/$disk" | grep "not mounted"`Is there any way to not call blkid multiple time (ie save the output and use it once?
Quoted 2 lines
Unfortunately no, both outputs are different.
not sure I follow the fact that blkid has different output formats when called multiple times inside the "for disk" loop. Are you saying the output of blkid changes each time the for loop is iterated?
Quoted 5 lines
Quoted 4 lines
Are the lsblk and blkid commands guaranteed to be installed on most machines?
Quoted 8 lines
I double checked it before sending this patch and the answer was yes.
Quoted 3 lines
Also this seems to have matched my root disk, which again concerns me, I am still not convinced that a selection system like this is safe.
This is odd. My output shows only unmounted disks.
Which shell are you using?
Quoted 12 lines
Quoted 11 lines
scripts/contrib/mkefidisk.sh unmount() { · line 161
Quoted 3 lines
scripts/contrib/mkefidisk.sh +2
-0+ if [ -n "$mounted" ]; then + UNMOUNTED_AVAILABLES="$UNMOUNTED_AVAILABLES /dev/$disk\n"I think the \n is not needed here, what shell are you using, with Bash I get the following output:
0 -
/dev/sda
1 -/dev/sdb
2 -/dev/mmcblk0
Choose unmounted device number: 1
Quoted 9 lines
This output is strange mine shows only (without sda and sdb which i do have them also, but mounted):
contrib > ./mkefidisk.sh image
0 -/dev/mmcblk0
Choose unmounted device number:Are you sure you have updated the script with the changes? What distro are you using?
I am running on Fedora and Ubuntu, both have this issue.
I am still concerned about the safety of offering up disks that might not be valid.
Since you have not changed this for V3, I don't think it's a good change at this point.
Sau!
Quoted 116 lines
Quoted 13 lines
Choose a name of the device that will be boot from Recommended name is: /dev/sda\n
Is target device okay? [y/N]: yUsage:
mkefidisk.sh[-v] DEVICE HDDIMGTARGET_DEVICE
-v: Verbose debug
DEVICE: The device to write the image to, e.g./dev/sdh
HDDIMG: The hddimg file to generate the efi disk from
TARGET_DEVICE: The device the target will boot from, e.g./dev/mmcblk0
Device /dev/sdb\n cannot be foundQuoted 2 lines
Note the \n above in the choose a name and then the trailing \n here with the device not being found.
You are right I am removing \n. Strangely here it works perfectly:
0 -/dev/sdc
1 -/dev/mmcblk0
Choose unmounted device number: 1Choose a name of the device that will be boot from Recommended name is:
/dev/mmcblk0
Is target device okay? [y/N]: yQuoted 34 lines
Quoted 23 lines
scripts/contrib/mkefidisk.sh +20
-0+ info "$X - /dev/$disk" + X=`expr $X + 1` + fi + done + if [ $X -eq 0 ]; then + die "No unmounted device found." + fi + read -p "Choose unmounted device number: " DISK_NUMBER + X=0 + for line in `echo $UNMOUNTED_AVAILABLES`; do + if [ $DISK_NUMBER -eq $X ]; then + DISK_TO_BE_FLASHED=$line + break + else + X=`expr $X + 1` + fi + done + if [ -z "$DISK_TO_BE_FLASHED" ]; then + die "Option \"$DISK_NUMBER\" is invalid. Choose a valid option" + elsescripts/contrib/mkefidisk.sh unmount() { · line 191
Quoted 10 lines
scripts/contrib/mkefidisk.sh +10
-0+ if [ -z `echo $DISK_TO_BE_FLASHED | grep "mmc"` ]; then + TARGET_TO_BE_BOOT="/dev/sda" + else + TARGET_TO_BE_BOOT="/dev/mmcblk0" + fi + fi + echo "" + echo "Choose a name of the device that will be boot from" + echo -n "Recommended name is: " + info "$TARGET_TO_BE_BOOT\n"Quoted 1 line
You are still outputting the \n here
Removed too
Thank you a lot,
Bruno
Quoted 43 lines
Quoted 23 lines
scripts/contrib/mkefidisk.sh +12
-3+ read -p "Is target device okay? [y/N]: " RESPONSE + if [ "$RESPONSE" != "y" ]; then + read -p "Choose target device name: " TARGET_TO_BE_BOOT + fi + echo "" + if [ -z "$TARGET_TO_BE_BOOT" ]; then + die "Error: choose a valid target name" + fi + else + usage + exit 1 + fi fi if [ "$1" = "-v" ]; then@@ -162,9 +209,15 @@ if [ "$1" = "-v" ]; then shift fi -DEVICE=$1 -HDDIMG=$2 -TARGET_DEVICE=$3scripts/contrib/mkefidisk.sh if [ "$1" = "-v" ]; then · line 221
Quoted 10 lines
scripts/contrib/mkefidisk.sh +9
-0+if [ -z "$AVAILABLE_DISK" ]; then + DEVICE=$1 + HDDIMG=$2 + TARGET_DEVICE=$3 +else + DEVICE=$DISK_TO_BE_FLASHED + HDDIMG=$1 + TARGET_DEVICE=$TARGET_TO_BE_BOOT +fiThis change I like, if done with checking for 2 parameter (image and disk to flash, the 3 paramter can be determined as you have with best guess of
/dev/sdaif it's an sd and mmc if it's a/dev/mmcflash device.Sau!
Quoted 3 lines
scripts/contrib/mkefidisk.sh +0
-0LINK=$(readlink $DEVICE) if [ $? -eq 0 ]; then