Skip to contentSkip to conversation

btrfs-progs: makefile: drop u option from ar invocation

PATCH Applied Arnd Hannemann 2 participants 2 messages Sep 4, 2015 – Sep 8, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 btrfs-progs: makefile: drop u option from ar invocation

In newer distros (ubuntu 15.10, fedora rawhide) the binutils ar uses the new D flag per default to build deterministic binaries.
Without this patch the following warning is issued, when building btrfs-progs:

[AR] libbtrfs.a
/usr/bin/ar: u' modifier ignored since D' is the default (see `U')

For libtrfs.a performance benefit of the u option can be neglected, so drop the u option and silence the warning.

In the future one might want to explicitly add the D option anyway.

---
 Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile.in +1 -1
index 665f83c..514a76f 100644
@@ -199,7 +199,7 @@ $(libs_shared): $(libbtrfs_objects) $(lib_links) send.h
 
 $(libs_static): $(libbtrfs_objects)
 	@echo "    [AR]     $@"
-	$(Q)$(AR) cru libbtrfs.a $(libbtrfs_objects)
+	$(Q)$(AR) cr libbtrfs.a $(libbtrfs_objects)
 
 $(lib_links):
 	@echo "    [LN]     $@"
Signature · 1 line
2.5.0
Applied
#1 lore raw
Quoted 9 lines · Arnd Hannemann

In newer distros (ubuntu 15.10, fedora rawhide) the binutils ar uses the new D flag per default to build deterministic binaries.
Without this patch the following warning is issued, when building btrfs-progs:

[AR] libbtrfs.a
/usr/bin/ar: u' modifier ignored since D' is the default (see `U')

Quoted 6 lines

For libtrfs.a performance benefit of the u option can be neglected, so drop the u option and silence the warning.

In the future one might want to explicitly add the D option anyway.

Applied, thanks.