Skip to contentSkip to conversation

twl4030_charger: fix another compile error

PATCH In review Grazvydas Ignotas 2 participants 2 messages Sep 4, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 twl4030_charger: fix another compile error

When CONFIG_CHARGER_TWL4030=y and CONFIG_TWL4030_MADC=m we get a compile error:

drivers/built-in.o: In function `twl4030_charger_update_current':
twl4030_charger.c:(.text+0x504681): undefined reference to `twl4030_get_madc_conversion'

Use IS_REACHABLE to fix it.

---
 drivers/power/twl4030_charger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/twl4030_charger.c +1 -1
index f4f2c1f..5bcc76f 100644
@@ -91,7 +91,7 @@
 #define TWL4030_MSTATEC_COMPLETE1	0x0b
 #define TWL4030_MSTATEC_COMPLETE4	0x0e
 
-#if IS_ENABLED(CONFIG_TWL4030_MADC)
+#if IS_REACHABLE(CONFIG_TWL4030_MADC)
 /*
  * If AC (Accessory Charger) voltage exceeds 4.5V (MADC 11)
  * then AC is available.
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Grazvydas Ignotas

When CONFIG_CHARGER_TWL4030=y and CONFIG_TWL4030_MADC=m we get a compile error:

drivers/built-in.o: In function `twl4030_charger_update_current':
twl4030_charger.c:(.text+0x504681): undefined reference to `twl4030_get_madc_conversion'

Quoted 5 lines

Use IS_REACHABLE to fix it.

Looks OK to me:

Acked-by Tony Lindgren <tony#atomide.com>
Quoted 24 lines
---
 drivers/power/twl4030_charger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/twl4030_charger.c +1 -1
index f4f2c1f..5bcc76f 100644
@@ -91,7 +91,7 @@
 #define TWL4030_MSTATEC_COMPLETE1	0x0b
 #define TWL4030_MSTATEC_COMPLETE4	0x0e
 
-#if IS_ENABLED(CONFIG_TWL4030_MADC)
+#if IS_REACHABLE(CONFIG_TWL4030_MADC)
 /*
  * If AC (Accessory Charger) voltage exceeds 4.5V (MADC 11)
  * then AC is available.
Signature · 6 lines
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html