Skip to contentSkip to conversation

doc/settings-storage: describe gatt attributes storage format

PATCH Applied Jakub Pawlowski 2 participants 4 messages Sep 5, 2015 – Sep 7, 2015 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH v5 1/2 doc/settings-storage: describe gatt attributes storage format

---
 doc/settings-storage.txt | 37 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 36 insertions(+), 1 deletion(-)
doc/settings-storage.txt +36 -1
index 6c9f058..aea50a6 100644
@@ -139,11 +139,15 @@ Cache directory file format
 ============================
 
 Each file, named by remote device address, may includes multiple groups
-(General and ServiceRecords).
+(General, ServiceRecords, Attributes).
 
 In ServiceRecords, SDP records are stored using their handle as key
 (hexadecimal format).
 
+In "Attributes" group GATT database is stored using attribute handle as key
+(hexadecimal format). Value associated with this handle is serialized form of
+all data required to re-create given attribute. ":" is used to separate fields.
+
 [General] group contains:
 
   Name		String		Remote device friendly name
@@ -155,6 +159,37 @@ In ServiceRecords, SDP records are stored using their handle as key
   <0x...>	String		SDP record as hexadecimal encoded
 				string
 
+In [Attributes] group value always starts with attribute type, that determines
+how to interpret rest of value:
+
+  Primary service:
+    2800:end_handle:uuid
+
+  Secondary service:
+    2801:end_handle:uuid
+
+  Included service:
+    2802:start_handle:end_handle:uuid
+
+  Characteristic:
+    2803:value_handle:properties:uuid
+
+  Descriptor:
+    uuid
+
+Sample Attributes section:
+  [Attributes]
+  0001=2800:0005:1801
+  0002=2803:0003:20:2a05
+  0014=2800:001c:1800
+  0015=2803:0016:02:2a00
+  0017=2803:0018:02:2a01
+  0019=2803:001a:02:2aa6
+  0028=2800:ffff:0000180d-0000-1000-8000-00805f9b34fb
+  0029=2803:002a:10:00002a37-0000-1000-8000-00805f9b34fb
+  002b=2803:002c:02:00002a38-0000-1000-8000-00805f9b34fb
+  002d=2803:002e:08:00002a39-0000-1000-8000-00805f9b34fb
+
 
 Info file format
 ================
Signature · 1 line
2.1.4
#1 lore raw

PATCH v5 2/2 src/device: gatt database persistence

This patch adds whole gatt database persistence for paired LE devices.

Storing whole database can have big impact on reconnection time for paired devices, because full discovery can take up to 10 seconds.

Sample how stored database looks in cache file:

[Attributes]
0001=2800:0005:1801
0002=2803:0003:20:2a05
0014=2800:001c:1800
0015=2803:0016:02:2a00
0017=2803:0018:02:2a01
0019=2803:001a:02:2aa6 0028=2800:ffff:0000180d-0000-1000-8000-00805f9b34fb 0029=2803:002a:10:00002a37-0000-1000-8000-00805f9b34fb 002b=2803:002c:02:00002a38-0000-1000-8000-00805f9b34fb 002d=2803:002e:08:00002a39-0000-1000-8000-00805f9b34fb

---
 src/device.c | 422 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 421 insertions(+), 1 deletion(-)
src/device.c +421 -1
index 999f09f..7fc57db 100644
@@ -87,6 +87,11 @@
 
 #define RSSI_THRESHOLD		8
 
+#define GATT_PRIM_SVC_UUID_STR "2800"
+#define GATT_SND_SVC_UUID_STR  "2801"
+#define GATT_INCLUDE_UUID_STR "2802"
+#define GATT_CHARAC_UUID_STR "2803"
+
 static DBusConnection *dbus_conn = NULL;
 static unsigned service_state_cb_id;
 
@@ -1962,6 +1967,153 @@ static void store_services(struct btd_device *device)
 	g_key_file_free(key_file);
 }
 
+struct gatt_saver {
+	struct btd_device *device;
+	GKeyFile *key_file;
+};
+
+static void store_desc(struct gatt_db_attribute *attr, void *user_data)
+{
+	struct gatt_saver *saver = user_data;
+	GKeyFile *key_file = saver->key_file;
+	char handle[6], value[100], uuid_str[MAX_LEN_UUID_STR];
+	const bt_uuid_t *uuid;
+	uint16_t handle_num;
+
+	handle_num = gatt_db_attribute_get_handle(attr);
+	sprintf(handle, "%04hx", handle_num);
+
+	uuid = gatt_db_attribute_get_type(attr);
+	bt_uuid_to_string(uuid, uuid_str, sizeof(uuid_str));
+	sprintf(value, "%s", uuid_str);
+	g_key_file_set_string(key_file, "Attributes", handle, value);
+}
+
+static void store_chrc(struct gatt_db_attribute *attr, void *user_data)
+{
+	struct gatt_saver *saver = user_data;
+	GKeyFile *key_file = saver->key_file;
+	char handle[6], value[100], uuid_str[MAX_LEN_UUID_STR];
+	uint16_t handle_num, value_handle;
+	uint8_t properties;
+	bt_uuid_t uuid;
+
+	if (!gatt_db_attribute_get_char_data(attr, &handle_num, &value_handle,
+							&properties, &uuid)) {
+		warn("Error storing characteristic - can't get data");
+		return;
+	}
+
+	sprintf(handle, "%04hx", handle_num);
+	bt_uuid_to_string(&uuid, uuid_str, sizeof(uuid_str));
+	sprintf(value, GATT_CHARAC_UUID_STR ":%04hx:%02hx:%s", value_handle,
+							properties, uuid_str);
+	g_key_file_set_string(key_file, "Attributes", handle, value);
+
+	gatt_db_service_foreach_desc(attr, store_desc, saver);
+}
+
+static void store_incl(struct gatt_db_attribute *attr, void *user_data)
+{
+	struct gatt_saver *saver = user_data;
+	GKeyFile *key_file = saver->key_file;
+	struct gatt_db_attribute *service;
+	char handle[6], value[100], uuid_str[MAX_LEN_UUID_STR];
+	uint16_t handle_num, start, end;
+	bt_uuid_t uuid;
+
+	if (!gatt_db_attribute_get_incl_data(attr, &handle_num, &start, &end)) {
+		warn("Error storing included service - can't get data");
+		return;
+	}
+
+	service = gatt_db_get_attribute(saver->device->db, start);
+	if (!service) {
+		warn("Error storing included service - can't find it");
+		return;
+	}
+
+	sprintf(handle, "%04hx", handle_num);
+
+	bt_uuid_to_string(&uuid, uuid_str, sizeof(uuid_str));
+	sprintf(value, GATT_INCLUDE_UUID_STR ":%04hx:%04hx:%s", start,
+								end, uuid_str);
+
+	g_key_file_set_string(key_file, "Attributes", handle, value);
+}
+
+static void store_service(struct gatt_db_attribute *attr, void *user_data)
+{
+	struct gatt_saver *saver = user_data;
+	GKeyFile *key_file = saver->key_file;
+	char uuid_str[MAX_LEN_UUID_STR], handle[6], value[256];
+	uint16_t start, end;
+	bt_uuid_t uuid;
+	bool primary;
+	char *type;
+
+	if (!gatt_db_attribute_get_service_data(attr, &start, &end, &primary,
+								&uuid)) {
+		warn("Error storing service - can't get data");
+		return;
+	}
+
+	sprintf(handle, "%04hx", start);
+
+	bt_uuid_to_string(&uuid, uuid_str, sizeof(uuid_str));
+
+	if (primary)
+		type = GATT_PRIM_SVC_UUID_STR;
+	else
+		type = GATT_SND_SVC_UUID_STR;
+
+	sprintf(value, "%s:%04hx:%s", type, end, uuid_str);
+
+	g_key_file_set_string(key_file, "Attributes", handle, value);
+
+	gatt_db_service_foreach_incl(attr, store_incl, saver);
+	gatt_db_service_foreach_char(attr, store_chrc, saver);
+}
+
+static void store_gatt_db(struct btd_device *device)
+{
+	struct btd_adapter *adapter = device->adapter;
+	char filename[PATH_MAX];
+	char src_addr[18], dst_addr[18];
+	GKeyFile *key_file;
+	char *data;
+	gsize length = 0;
+	struct gatt_saver saver;
+
+	if (device_address_is_private(device)) {
+		warn("Can't store GATT db for private addressed device %s",
+								device->path);
+		return;
+	}
+
+	ba2str(btd_adapter_get_address(adapter), src_addr);
+	ba2str(&device->bdaddr, dst_addr);
+
+	snprintf(filename, PATH_MAX, STORAGEDIR "/%s/cache/%s", src_addr,
+								dst_addr);
+	create_file(filename, S_IRUSR | S_IWUSR);
+
+	key_file = g_key_file_new();
+	g_key_file_load_from_file(key_file, filename, 0, NULL);
+
+	saver.key_file = key_file;
+	saver.device = device;
+
+	gatt_db_foreach_service(device->db, NULL, store_service, &saver);
+
+	data = g_key_file_to_data(key_file, &length, NULL);
+	g_file_set_contents(filename, data, length, NULL);
+
+	g_free(data);
+	g_key_file_free(key_file);
+}
+
+
 static void browse_request_complete(struct browse_req *req, uint8_t bdaddr_type,
 									int err)
 {
@@ -2050,8 +2202,10 @@ static void device_svc_resolved(struct btd_device *dev, uint8_t bdaddr_type,
 	if (!dev->temporary)
 		store_device_info(dev);
 
-	if (bdaddr_type != BDADDR_BREDR && err == 0)
+	if (bdaddr_type != BDADDR_BREDR && err == 0) {
 		store_services(dev);
+		store_gatt_db(dev);
+	}
 
 	if (!req)
 		return;
@@ -2792,6 +2946,262 @@ static void add_primary(struct gatt_db_attribute *attr, void *user_data)
 	*new_services = g_slist_append(*new_services, prim);
 }
 
+static int load_desc(char *handle, char *value,
+					struct gatt_db_attribute *service)
+{
+	char uuid_str[MAX_LEN_UUID_STR];
+	struct gatt_db_attribute *att;
+	uint16_t handle_int;
+	bt_uuid_t uuid, uuid128;
+
+	if (sscanf(handle, "%04hx", &handle_int) != 1)
+		return -EIO;
+
+	if (sscanf(value, "%s", uuid_str) != 1)
+		return -EIO;
+
+	bt_string_to_uuid(&uuid, uuid_str);
+	bt_uuid_to_uuid128(&uuid, &uuid128);
+
+	DBG("loading descriptor handle: 0x%04x, uuid: %s", handle_int,
+								uuid_str);
+
+	att = gatt_db_service_insert_descriptor(service, handle_int, &uuid128,
+							0, NULL, NULL, NULL);
+
+	if (!att || gatt_db_attribute_get_handle(att) != handle_int) {
+		warn("loading descriptor to db failed");
+		return -EIO;
+	}
+
+	return 0;
+}
+
+static int load_chrc(char *handle, char *value,
+					struct gatt_db_attribute *service)
+{
+	uint16_t properties, value_handle, handle_int;
+	char uuid_str[MAX_LEN_UUID_STR];
+	struct gatt_db_attribute *att;
+	bt_uuid_t uuid, uuid128;
+
+	if (sscanf(handle, "%04hx", &handle_int) != 1)
+		return -EIO;
+
+	if (sscanf(value, GATT_CHARAC_UUID_STR ":%04hx:%02hx:%s", &value_handle,
+						&properties, uuid_str) != 3)
+		return -EIO;
+
+	bt_string_to_uuid(&uuid, uuid_str);
+	bt_uuid_to_uuid128(&uuid, &uuid128);
+
+	/* Log debug message. */
+	DBG("loading characteristic handle: 0x%04x, value handle: 0x%04x,"
+				" properties 0x%04x uuid: %s", handle_int,
+				value_handle, properties, uuid_str);
+
+	att = gatt_db_service_insert_characteristic(service, value_handle,
+							&uuid128, 0, properties,
+							NULL, NULL, NULL);
+
+	if (!att || gatt_db_attribute_get_handle(att) != value_handle) {
+		warn("saving characteristic to db failed");
+		return -EIO;
+	}
+
+	return 0;
+}
+
+static int load_incl(struct gatt_db *db, char *handle, char *value,
+					struct gatt_db_attribute *service)
+{
+	char uuid_str[MAX_LEN_UUID_STR];
+	struct gatt_db_attribute *att;
+	uint16_t start, end;
+
+	if (sscanf(handle, "%04hx", &start) != 1)
+		return -EIO;
+
+	if (sscanf(value, GATT_INCLUDE_UUID_STR ":%04hx:%04hx:%s", &start, &end,
+								uuid_str) != 3)
+		return -EIO;
+
+	/* Log debug message. */
+	DBG("loading included service: 0x%04x, end: 0x%04x, uuid: %s", start,
+								end, uuid_str);
+
+	att = gatt_db_get_attribute(db, start);
+	if (!att) {
+		warn("saving included service to db failed - no such service");
+		return -EIO;
+	}
+
+	att = gatt_db_service_add_included(service, att);
+	if (!att) {
+		warn("saving included service to db failed");
+		return -EIO;
+	}
+
+	return 0;
+}
+
+static int load_service(struct gatt_db *db, char *handle, char *value)
+{
+	struct gatt_db_attribute *att;
+	uint16_t start, end;
+	char type[MAX_LEN_UUID_STR], uuid_str[MAX_LEN_UUID_STR];
+	bt_uuid_t uuid, uuid128;
+	bool primary;
+
+	if (sscanf(handle, "%04hx", &start) != 1)
+		return -EIO;
+
+	if (sscanf(value, "%[^:]:%04hx:%s", type, &end, uuid_str) != 3)
+		return -EIO;
+
+	if (g_str_equal(type, GATT_PRIM_SVC_UUID_STR))
+		primary = true;
+	else if (g_str_equal(type, GATT_SND_SVC_UUID_STR))
+		primary = false;
+	else
+		return -EIO;
+
+	bt_string_to_uuid(&uuid, uuid_str);
+	bt_uuid_to_uuid128(&uuid, &uuid128);
+
+	/* Log debug message. */
+	DBG("loading service: 0x%04x, end: 0x%04x, uuid: %s",
+							start, end, uuid_str);
+
+	att = gatt_db_insert_service(db, start, &uuid128, primary,
+						end - start + 1);
+
+	if (!att) {
+		DBG("ERROR saving service to db!");
+		return -EIO;
+	}
+
+	return 0;
+}
+
+static int load_gatt_db_impl(GKeyFile *key_file, char **keys,
+							struct gatt_db *db)
+{
+	struct gatt_db_attribute *current_service;
+	char **handle, *value, type[MAX_LEN_UUID_STR];
+	int ret;
+
+	/* first load service definitions */
+	for (handle = keys; *handle; handle++) {
+		value = g_key_file_get_string(key_file, "Attributes", *handle,
+									NULL);
+
+		if (sscanf(value, "%[^:]:", type) != 1) {
+			warn("Missing Type in attribute definition");
+			g_free(value);
+			return -EIO;
+		}
+
+		if (g_str_equal(type, GATT_PRIM_SVC_UUID_STR) ||
+				g_str_equal(type, GATT_SND_SVC_UUID_STR)) {
+			ret = load_service(db, *handle, value);
+			if (ret) {
+				g_free(value);
+				return ret;
+			}
+		}
+
+		g_free(value);
+	}
+
+	current_service = NULL;
+	/* then fill them with data*/
+	for (handle = keys; *handle; handle++) {
+		value = g_key_file_get_string(key_file, "Attributes", *handle,
+									NULL);
+
+		if (sscanf(value, "%[^:]:", type) != 1) {
+			warn("Missing Type in attribute definition");
+			g_free(value);
+			return -EIO;
+		}
+
+		if (g_str_equal(type, GATT_PRIM_SVC_UUID_STR) ||
+				g_str_equal(type, GATT_SND_SVC_UUID_STR)) {
+			uint16_t tmp;
+			uint16_t start, end;
+			bool primary;
+			bt_uuid_t uuid;
+			char uuid_str[MAX_LEN_UUID_STR];
+
+			if (sscanf(*handle, "%04hx", &tmp) != 1) {
+				warn("Unable to parse attribute handle");
+				g_free(value);
+				return -EIO;
+			}
+
+			if (current_service)
+				gatt_db_service_set_active(current_service,
+									true);
+
+			current_service = gatt_db_get_attribute(db, tmp);
+
+			gatt_db_attribute_get_service_data(current_service,
+							&start, &end,
+							&primary, &uuid);
+
+			bt_uuid_to_string(&uuid, uuid_str, sizeof(uuid_str));
+		} else if (g_str_equal(type, GATT_INCLUDE_UUID_STR)) {
+			ret = load_incl(db, *handle, value, current_service);
+		} else if (g_str_equal(type, GATT_CHARAC_UUID_STR)) {
+			ret = load_chrc(*handle, value, current_service);
+		} else {
+			ret = load_desc(*handle, value, current_service);
+		}
+
+		g_free(value);
+		if (ret)
+			return ret;
+	}
+
+	if (current_service)
+		gatt_db_service_set_active(current_service, true);
+
+	return 0;
+}
+
+static void load_gatt_db(struct btd_device *device, const char *local,
+							const char *peer)
+{
+	char **keys, filename[PATH_MAX];
+	GKeyFile *key_file;
+
+	DBG("Restoring %s gatt database from file", peer);
+
+	snprintf(filename, PATH_MAX, STORAGEDIR "/%s/cache/%s", local, peer);
+
+	key_file = g_key_file_new();
+	g_key_file_load_from_file(key_file, filename, 0, NULL);
+	keys = g_key_file_get_keys(key_file, "Attributes", NULL, NULL);
+
+	if (!keys) {
+		warn("No cache for %s", peer);
+		g_key_file_free(key_file);
+		return;
+	}
+
+	if (load_gatt_db_impl(key_file, keys, device->db))
+		warn("Unable to load gatt db from file for %s", peer);
+
+	g_strfreev(keys);
+	g_key_file_free(key_file);
+
+	g_slist_free_full(device->primaries, g_free);
+	device->primaries = NULL;
+	gatt_db_foreach_service(device->db, NULL, add_primary,
+							&device->primaries);
+}
+
 static void device_add_uuids(struct btd_device *device, GSList *uuids)
 {
 	GSList *l;
@@ -4252,6 +4662,8 @@ bool device_attach_att(struct btd_device *dev, GIOChannel *io)
 	uint16_t mtu;
 	uint16_t cid;
 	struct btd_gatt_database *database;
+	const bdaddr_t *src, *dst;
+	char srcaddr[18], dstaddr[18];
 
 	bt_io_get(io, &gerr, BT_IO_OPT_SEC_LEVEL, &sec_level,
 						BT_IO_OPT_IMTU, &mtu,
@@ -4303,6 +4715,14 @@ bool device_attach_att(struct btd_device *dev, GIOChannel *io)
 
 	database = btd_adapter_get_database(dev->adapter);
 
+	src = btd_adapter_get_address(dev->adapter);
+	ba2str(src, srcaddr);
+
+	dst = device_get_address(dev);
+	ba2str(dst, dstaddr);
+
+	load_gatt_db(dev, srcaddr, dstaddr);
+
 	gatt_client_init(dev);
 	gatt_server_init(dev, btd_gatt_database_get_db(database));
 
Signature · 1 line
2.1.4
#2 lore raw

Re: [BlueZ v5 2/2] src/device: gatt database persistence

Hi Jakub,

Quoted 214 lines · Jakub Pawlowski

This patch adds whole gatt database persistence for paired LE devices.

Storing whole database can have big impact on reconnection time for paired devices, because full discovery can take up to 10 seconds.

Sample how stored database looks in cache file:

[Attributes]
0001=2800:0005:1801
0002=2803:0003:20:2a05
0014=2800:001c:1800
0015=2803:0016:02:2a00
0017=2803:0018:02:2a01
0019=2803:001a:02:2aa6 0028=2800:ffff:0000180d-0000-1000-8000-00805f9b34fb 0029=2803:002a:10:00002a37-0000-1000-8000-00805f9b34fb 002b=2803:002c:02:00002a38-0000-1000-8000-00805f9b34fb 002d=2803:002e:08:00002a39-0000-1000-8000-00805f9b34fb

---
 src/device.c | 422 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 421 insertions(+), 1 deletion(-)
src/device.c +161 -1
index 999f09f..7fc57db 100644
@@ -87,6 +87,11 @@
 
 #define RSSI_THRESHOLD         8
 
+#define GATT_PRIM_SVC_UUID_STR "2800"
+#define GATT_SND_SVC_UUID_STR  "2801"
+#define GATT_INCLUDE_UUID_STR "2802"
+#define GATT_CHARAC_UUID_STR "2803"
+
 static DBusConnection *dbus_conn = NULL;
 static unsigned service_state_cb_id;
 
@@ -1962,6 +1967,153 @@ static void store_services(struct btd_device *device)
        g_key_file_free(key_file);
 }
 
+struct gatt_saver {
+       struct btd_device *device;
+       GKeyFile *key_file;
+};
+
+static void store_desc(struct gatt_db_attribute *attr, void *user_data)
+{
+       struct gatt_saver *saver = user_data;
+       GKeyFile *key_file = saver->key_file;
+       char handle[6], value[100], uuid_str[MAX_LEN_UUID_STR];
+       const bt_uuid_t *uuid;
+       uint16_t handle_num;
+
+       handle_num = gatt_db_attribute_get_handle(attr);
+       sprintf(handle, "%04hx", handle_num);
+
+       uuid = gatt_db_attribute_get_type(attr);
+       bt_uuid_to_string(uuid, uuid_str, sizeof(uuid_str));
+       sprintf(value, "%s", uuid_str);
+       g_key_file_set_string(key_file, "Attributes", handle, value);
+}
+
+static void store_chrc(struct gatt_db_attribute *attr, void *user_data)
+{
+       struct gatt_saver *saver = user_data;
+       GKeyFile *key_file = saver->key_file;
+       char handle[6], value[100], uuid_str[MAX_LEN_UUID_STR];
+       uint16_t handle_num, value_handle;
+       uint8_t properties;
+       bt_uuid_t uuid;
+
+       if (!gatt_db_attribute_get_char_data(attr, &handle_num, &value_handle,
+                                                       &properties, &uuid)) {
+               warn("Error storing characteristic - can't get data");
+               return;
+       }
+
+       sprintf(handle, "%04hx", handle_num);
+       bt_uuid_to_string(&uuid, uuid_str, sizeof(uuid_str));
+       sprintf(value, GATT_CHARAC_UUID_STR ":%04hx:%02hx:%s", value_handle,
+                                                       properties, uuid_str);
+       g_key_file_set_string(key_file, "Attributes", handle, value);
+
+       gatt_db_service_foreach_desc(attr, store_desc, saver);
+}
+
+static void store_incl(struct gatt_db_attribute *attr, void *user_data)
+{
+       struct gatt_saver *saver = user_data;
+       GKeyFile *key_file = saver->key_file;
+       struct gatt_db_attribute *service;
+       char handle[6], value[100], uuid_str[MAX_LEN_UUID_STR];
+       uint16_t handle_num, start, end;
+       bt_uuid_t uuid;
+
+       if (!gatt_db_attribute_get_incl_data(attr, &handle_num, &start, &end)) {
+               warn("Error storing included service - can't get data");
+               return;
+       }
+
+       service = gatt_db_get_attribute(saver->device->db, start);
+       if (!service) {
+               warn("Error storing included service - can't find it");
+               return;
+       }
+
+       sprintf(handle, "%04hx", handle_num);
+
+       bt_uuid_to_string(&uuid, uuid_str, sizeof(uuid_str));
+       sprintf(value, GATT_INCLUDE_UUID_STR ":%04hx:%04hx:%s", start,
+                                                               end, uuid_str);
+
+       g_key_file_set_string(key_file, "Attributes", handle, value);
+}
+
+static void store_service(struct gatt_db_attribute *attr, void *user_data)
+{
+       struct gatt_saver *saver = user_data;
+       GKeyFile *key_file = saver->key_file;
+       char uuid_str[MAX_LEN_UUID_STR], handle[6], value[256];
+       uint16_t start, end;
+       bt_uuid_t uuid;
+       bool primary;
+       char *type;
+
+       if (!gatt_db_attribute_get_service_data(attr, &start, &end, &primary,
+                                                               &uuid)) {
+               warn("Error storing service - can't get data");
+               return;
+       }
+
+       sprintf(handle, "%04hx", start);
+
+       bt_uuid_to_string(&uuid, uuid_str, sizeof(uuid_str));
+
+       if (primary)
+               type = GATT_PRIM_SVC_UUID_STR;
+       else
+               type = GATT_SND_SVC_UUID_STR;
+
+       sprintf(value, "%s:%04hx:%s", type, end, uuid_str);
+
+       g_key_file_set_string(key_file, "Attributes", handle, value);
+
+       gatt_db_service_foreach_incl(attr, store_incl, saver);
+       gatt_db_service_foreach_char(attr, store_chrc, saver);
+}
+
+static void store_gatt_db(struct btd_device *device)
+{
+       struct btd_adapter *adapter = device->adapter;
+       char filename[PATH_MAX];
+       char src_addr[18], dst_addr[18];
+       GKeyFile *key_file;
+       char *data;
+       gsize length = 0;
+       struct gatt_saver saver;
+
+       if (device_address_is_private(device)) {
+               warn("Can't store GATT db for private addressed device %s",
+                                                               device->path);
+               return;
+       }
+
+       ba2str(btd_adapter_get_address(adapter), src_addr);
+       ba2str(&device->bdaddr, dst_addr);
+
+       snprintf(filename, PATH_MAX, STORAGEDIR "/%s/cache/%s", src_addr,
+                                                               dst_addr);
+       create_file(filename, S_IRUSR | S_IWUSR);
+
+       key_file = g_key_file_new();
+       g_key_file_load_from_file(key_file, filename, 0, NULL);
+
+       saver.key_file = key_file;
+       saver.device = device;
+
+       gatt_db_foreach_service(device->db, NULL, store_service, &saver);
+
+       data = g_key_file_to_data(key_file, &length, NULL);
+       g_file_set_contents(filename, data, length, NULL);
+
+       g_free(data);
+       g_key_file_free(key_file);
+}
+
+
 static void browse_request_complete(struct browse_req *req, uint8_t bdaddr_type,
                                                                        int err)
 {
@@ -2050,8 +2202,10 @@ static void device_svc_resolved(struct btd_device *dev, uint8_t bdaddr_type,
        if (!dev->temporary)
                store_device_info(dev);
 
-       if (bdaddr_type != BDADDR_BREDR && err == 0)
+       if (bdaddr_type != BDADDR_BREDR && err == 0) {
                store_services(dev);
+               store_gatt_db(dev);
+       }
 
        if (!req)
                return;
@@ -2792,6 +2946,262 @@ static void add_primary(struct gatt_db_attribute *attr, void *user_data)
        *new_services = g_slist_append(*new_services, prim);
 }
 
+static int load_desc(char *handle, char *value,
+                                       struct gatt_db_attribute *service)
+{
+       char uuid_str[MAX_LEN_UUID_STR];
+       struct gatt_db_attribute *att;
+       uint16_t handle_int;

src/device.c static void add_primary(struct gatt_db_attribute *attr, void *user_data) · line 2964

Quoted 10 lines
src/device.c +10 -0
+       bt_uuid_t uuid, uuid128;
+
+       if (sscanf(handle, "%04hx", &handle_int) != 1)
+               return -EIO;
+
+       if (sscanf(value, "%s", uuid_str) != 1)
+               return -EIO;
+
+       bt_string_to_uuid(&uuid, uuid_str);
+       bt_uuid_to_uuid128(&uuid, &uuid128);

Actually this is not a problem anymore since I fixed bt_uuid_strcmp.

Quoted 22 lines
src/device.c +22 -0
+
+       DBG("loading descriptor handle: 0x%04x, uuid: %s", handle_int,
+                                                               uuid_str);
+
+       att = gatt_db_service_insert_descriptor(service, handle_int, &uuid128,
+                                                       0, NULL, NULL, NULL);
+
+       if (!att || gatt_db_attribute_get_handle(att) != handle_int) {
+               warn("loading descriptor to db failed");
+               return -EIO;
+       }
+
+       return 0;
+}
+
+static int load_chrc(char *handle, char *value,
+                                       struct gatt_db_attribute *service)
+{
+       uint16_t properties, value_handle, handle_int;
+       char uuid_str[MAX_LEN_UUID_STR];
+       struct gatt_db_attribute *att;
+       bt_uuid_t uuid, uuid128;

src/device.c static void add_primary(struct gatt_db_attribute *attr, void *user_data) · line 2996

Quoted 10 lines
src/device.c +10 -0
+
+       if (sscanf(handle, "%04hx", &handle_int) != 1)
+               return -EIO;
+
+       if (sscanf(value, GATT_CHARAC_UUID_STR ":%04hx:%02hx:%s", &value_handle,
+                                               &properties, uuid_str) != 3)
+               return -EIO;
+
+       bt_string_to_uuid(&uuid, uuid_str);
+       bt_uuid_to_uuid128(&uuid, &uuid128);

Ditto.

Quoted 63 lines
src/device.c +63 -0
+       /* Log debug message. */
+       DBG("loading characteristic handle: 0x%04x, value handle: 0x%04x,"
+                               " properties 0x%04x uuid: %s", handle_int,
+                               value_handle, properties, uuid_str);
+
+       att = gatt_db_service_insert_characteristic(service, value_handle,
+                                                       &uuid128, 0, properties,
+                                                       NULL, NULL, NULL);
+
+       if (!att || gatt_db_attribute_get_handle(att) != value_handle) {
+               warn("saving characteristic to db failed");
+               return -EIO;
+       }
+
+       return 0;
+}
+
+static int load_incl(struct gatt_db *db, char *handle, char *value,
+                                       struct gatt_db_attribute *service)
+{
+       char uuid_str[MAX_LEN_UUID_STR];
+       struct gatt_db_attribute *att;
+       uint16_t start, end;
+
+       if (sscanf(handle, "%04hx", &start) != 1)
+               return -EIO;
+
+       if (sscanf(value, GATT_INCLUDE_UUID_STR ":%04hx:%04hx:%s", &start, &end,
+                                                               uuid_str) != 3)
+               return -EIO;
+
+       /* Log debug message. */
+       DBG("loading included service: 0x%04x, end: 0x%04x, uuid: %s", start,
+                                                               end, uuid_str);
+
+       att = gatt_db_get_attribute(db, start);
+       if (!att) {
+               warn("saving included service to db failed - no such service");
+               return -EIO;
+       }
+
+       att = gatt_db_service_add_included(service, att);
+       if (!att) {
+               warn("saving included service to db failed");
+               return -EIO;
+       }
+
+       return 0;
+}
+
+static int load_service(struct gatt_db *db, char *handle, char *value)
+{
+       struct gatt_db_attribute *att;
+       uint16_t start, end;
+       char type[MAX_LEN_UUID_STR], uuid_str[MAX_LEN_UUID_STR];
+       bt_uuid_t uuid, uuid128;
+       bool primary;
+
+       if (sscanf(handle, "%04hx", &start) != 1)
+               return -EIO;
+
+       if (sscanf(value, "%[^:]:%04hx:%s", type, &end, uuid_str) != 3)
+               return -EIO;

src/device.c static void add_primary(struct gatt_db_attribute *attr, void *user_data) · line 3070

Quoted 10 lines
src/device.c +10 -0
+
+       if (g_str_equal(type, GATT_PRIM_SVC_UUID_STR))
+               primary = true;
+       else if (g_str_equal(type, GATT_SND_SVC_UUID_STR))
+               primary = false;
+       else
+               return -EIO;
+
+       bt_string_to_uuid(&uuid, uuid_str);
+       bt_uuid_to_uuid128(&uuid, &uuid128);

Ditto.

Quoted 168 lines
src/device.c +144 -1
+
+       /* Log debug message. */
+       DBG("loading service: 0x%04x, end: 0x%04x, uuid: %s",
+                                                       start, end, uuid_str);
+
+       att = gatt_db_insert_service(db, start, &uuid128, primary,
+                                               end - start + 1);
+
+       if (!att) {
+               DBG("ERROR saving service to db!");
+               return -EIO;
+       }
+
+       return 0;
+}
+
+static int load_gatt_db_impl(GKeyFile *key_file, char **keys,
+                                                       struct gatt_db *db)
+{
+       struct gatt_db_attribute *current_service;
+       char **handle, *value, type[MAX_LEN_UUID_STR];
+       int ret;
+
+       /* first load service definitions */
+       for (handle = keys; *handle; handle++) {
+               value = g_key_file_get_string(key_file, "Attributes", *handle,
+                                                                       NULL);
+
+               if (sscanf(value, "%[^:]:", type) != 1) {
+                       warn("Missing Type in attribute definition");
+                       g_free(value);
+                       return -EIO;
+               }
+
+               if (g_str_equal(type, GATT_PRIM_SVC_UUID_STR) ||
+                               g_str_equal(type, GATT_SND_SVC_UUID_STR)) {
+                       ret = load_service(db, *handle, value);
+                       if (ret) {
+                               g_free(value);
+                               return ret;
+                       }
+               }
+
+               g_free(value);
+       }
+
+       current_service = NULL;
+       /* then fill them with data*/
+       for (handle = keys; *handle; handle++) {
+               value = g_key_file_get_string(key_file, "Attributes", *handle,
+                                                                       NULL);
+
+               if (sscanf(value, "%[^:]:", type) != 1) {
+                       warn("Missing Type in attribute definition");
+                       g_free(value);
+                       return -EIO;
+               }
+
+               if (g_str_equal(type, GATT_PRIM_SVC_UUID_STR) ||
+                               g_str_equal(type, GATT_SND_SVC_UUID_STR)) {
+                       uint16_t tmp;
+                       uint16_t start, end;
+                       bool primary;
+                       bt_uuid_t uuid;
+                       char uuid_str[MAX_LEN_UUID_STR];
+
+                       if (sscanf(*handle, "%04hx", &tmp) != 1) {
+                               warn("Unable to parse attribute handle");
+                               g_free(value);
+                               return -EIO;
+                       }
+
+                       if (current_service)
+                               gatt_db_service_set_active(current_service,
+                                                                       true);
+
+                       current_service = gatt_db_get_attribute(db, tmp);
+
+                       gatt_db_attribute_get_service_data(current_service,
+                                                       &start, &end,
+                                                       &primary, &uuid);
+
+                       bt_uuid_to_string(&uuid, uuid_str, sizeof(uuid_str));
+               } else if (g_str_equal(type, GATT_INCLUDE_UUID_STR)) {
+                       ret = load_incl(db, *handle, value, current_service);
+               } else if (g_str_equal(type, GATT_CHARAC_UUID_STR)) {
+                       ret = load_chrc(*handle, value, current_service);
+               } else {
+                       ret = load_desc(*handle, value, current_service);
+               }
+
+               g_free(value);
+               if (ret)
+                       return ret;
+       }
+
+       if (current_service)
+               gatt_db_service_set_active(current_service, true);
+
+       return 0;
+}
+
+static void load_gatt_db(struct btd_device *device, const char *local,
+                                                       const char *peer)
+{
+       char **keys, filename[PATH_MAX];
+       GKeyFile *key_file;
+
+       DBG("Restoring %s gatt database from file", peer);
+
+       snprintf(filename, PATH_MAX, STORAGEDIR "/%s/cache/%s", local, peer);
+
+       key_file = g_key_file_new();
+       g_key_file_load_from_file(key_file, filename, 0, NULL);
+       keys = g_key_file_get_keys(key_file, "Attributes", NULL, NULL);
+
+       if (!keys) {
+               warn("No cache for %s", peer);
+               g_key_file_free(key_file);
+               return;
+       }
+
+       if (load_gatt_db_impl(key_file, keys, device->db))
+               warn("Unable to load gatt db from file for %s", peer);
+
+       g_strfreev(keys);
+       g_key_file_free(key_file);
+
+       g_slist_free_full(device->primaries, g_free);
+       device->primaries = NULL;
+       gatt_db_foreach_service(device->db, NULL, add_primary,
+                                                       &device->primaries);
+}
+
 static void device_add_uuids(struct btd_device *device, GSList *uuids)
 {
        GSList *l;
@@ -4252,6 +4662,8 @@ bool device_attach_att(struct btd_device *dev, GIOChannel *io)
        uint16_t mtu;
        uint16_t cid;
        struct btd_gatt_database *database;
+       const bdaddr_t *src, *dst;
+       char srcaddr[18], dstaddr[18];
 
        bt_io_get(io, &gerr, BT_IO_OPT_SEC_LEVEL, &sec_level,
                                                BT_IO_OPT_IMTU, &mtu,
@@ -4303,6 +4715,14 @@ bool device_attach_att(struct btd_device *dev, GIOChannel *io)
 
        database = btd_adapter_get_database(dev->adapter);
 
+       src = btd_adapter_get_address(dev->adapter);
+       ba2str(src, srcaddr);
+
+       dst = device_get_address(dev);
+       ba2str(dst, dstaddr);
+
+       load_gatt_db(dev, srcaddr, dstaddr);
+
        gatt_client_init(dev);
        gatt_server_init(dev, btd_gatt_database_get_db(database));
 
--

2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 1 line
Luiz Augusto von Dentz
maintainer Applied
#3 lore raw
In reply to Jakub Pawlowski

Hi Jakub,

Quoted 64 lines · Jakub Pawlowski
---
 doc/settings-storage.txt | 37 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 36 insertions(+), 1 deletion(-)
doc/settings-storage.txt +36 -2
index 6c9f058..aea50a6 100644
@@ -139,11 +139,15 @@ Cache directory file format
 ============================
 
 Each file, named by remote device address, may includes multiple groups
-(General and ServiceRecords).
+(General, ServiceRecords, Attributes).
 
 In ServiceRecords, SDP records are stored using their handle as key
 (hexadecimal format).
 
+In "Attributes" group GATT database is stored using attribute handle as key
+(hexadecimal format). Value associated with this handle is serialized form of
+all data required to re-create given attribute. ":" is used to separate fields.
+
 [General] group contains:
 
   Name         String          Remote device friendly name
@@ -155,6 +159,37 @@ In ServiceRecords, SDP records are stored using their handle as key
   <0x...>      String          SDP record as hexadecimal encoded
                                string
 
+In [Attributes] group value always starts with attribute type, that determines
+how to interpret rest of value:
+
+  Primary service:
+    2800:end_handle:uuid
+
+  Secondary service:
+    2801:end_handle:uuid
+
+  Included service:
+    2802:start_handle:end_handle:uuid
+
+  Characteristic:
+    2803:value_handle:properties:uuid
+
+  Descriptor:
+    uuid
+
+Sample Attributes section:
+  [Attributes]
+  0001=2800:0005:1801
+  0002=2803:0003:20:2a05
+  0014=2800:001c:1800
+  0015=2803:0016:02:2a00
+  0017=2803:0018:02:2a01
+  0019=2803:001a:02:2aa6
+  0028=2800:ffff:0000180d-0000-1000-8000-00805f9b34fb
+  0029=2803:002a:10:00002a37-0000-1000-8000-00805f9b34fb
+  002b=2803:002c:02:00002a38-0000-1000-8000-00805f9b34fb
+  002d=2803:002e:08:00002a39-0000-1000-8000-00805f9b34fb
+
 
 Info file format
 ================
--
Quoted 1 line

2.1.4

Applied, thanks. Note that I did remove the conversion to UUID 128.

Signature · 1 line
Luiz Augusto von Dentz