Skip to contentSkip to conversation

Documentation: add Device tree bindings for hwmon/nct7802

PATCH Superseded Constantine Shulyupin 2 participants 2 messages Sep 6, 2015 – Sep 7, 2015

Subsystems (2)
Device tree bindings Hardware monitoring

v2 of 9 Superseded Latest is v9 →

lore
Share & tools
lore

Constantine Shulyupin

author
#0 lore raw

PATCH v2 1/1 Documentation: add Device tree bindings for hwmon/nct7802

Changed in v2:
- Removed nct7802,reg-init
- Added registers initialization by names

Introduced in v1:
- nct7802,reg-init

Signed-off-by Constantine Shulyupin <[email protected]>

---

---
 .../devicetree/bindings/hwmon/nct7802.txt          | 24 ++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/nct7802.txt
Documentation/devicetree/bindings/hwmon/nct7802.txt new file +24 -0
new file mode 100644
index 0000000..56214bf
@@ -0,0 +1,24 @@
+Nuvoton NCT7802Y Hardware Monitoring IC
+
+Required node properties:
+
+ - "compatible": must be "nuvoton,nct7802"
+ - "reg": I2C bus address of the device
+
+Optional properties:
+
+One byte registers:
+ - nct7802,Start
+ - nct7802,Mode
+ - nct7802,EnPECI
+ - nct7802,EnFan
+ - nct7802,EnV
+
+Example nct7802 node:
+
+nct7802 {
+	compatible = "nuvoton,nct7802";
+	reg = <0x2a>;
+	nct7802,Start = <0x01>;
+	nct7802,Mode = <0x7E>; // RTD1_MD = 2
+};
Signature · 1 line
1.9.1
#1 lore raw
Quoted 25 lines · Constantine Shulyupin

Changed in v2:
- Removed nct7802,reg-init
- Added registers initialization by names

Introduced in v1:
- nct7802,reg-init

Signed-off-by Constantine Shulyupin <[email protected]>

---

---
 .../devicetree/bindings/hwmon/nct7802.txt          | 24 ++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/nct7802.txt
Documentation/devicetree/bindings/hwmon/nct7802.txt new file +5 -0
new file mode 100644
index 0000000..56214bf
@@ -0,0 +1,24 @@
+Nuvoton NCT7802Y Hardware Monitoring IC
+
+Required node properties:
+
+ - "compatible": must be "nuvoton,nct7802"

Documentation/devicetree/bindings/hwmon/nct7802.txt line 15

Quoted 10 lines
Documentation/devicetree/bindings/hwmon/nct7802.txt new file +10 -0
+ - "reg": I2C bus address of the device
+
+Optional properties:
+
+One byte registers:
+ - nct7802,Start
+ - nct7802,Mode
+ - nct7802,EnPECI
+ - nct7802,EnFan
+ - nct7802,EnV

The binding doesn't describe what these actually represent, what type they are, etc.

Also, "nct7802" is not a vendor prefix, and the camelcase naming is unusual.

Why do you think you need these? Why must raw valeus be used rather than giving the kernel the information it needs to derive these for itself?

Mark.

Quoted 12 lines
Documentation/devicetree/bindings/hwmon/nct7802.txt new file +9 -0
+
+Example nct7802 node:
+
+nct7802 {
+	compatible = "nuvoton,nct7802";
+	reg = <0x2a>;
+	nct7802,Start = <0x01>;
+	nct7802,Mode = <0x7E>; // RTD1_MD = 2
+};
Signature · 1 line
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html