virtio-gpu: fix compilation warnings
Subsystems (4)
PATCH 1/1 virtio-gpu: fix compilation warnings
Update snprintf format in virtgpu_fence.c and virtgpu_debugfs.c to fix the following compilation warnings:
C [M] drivers/gpu/drm/virtio/virtgpu_fence.odrivers/gpu/drm/virtio/virtgpu_fence.c: In function ‘virtio_timeline_value_str’ :drivers/gpu/drm/virtio/virtgpu_fence.c:64:2: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘long long int’ [-Wformat=]
snprintf(str, size, "%lu", atomic64_read(&fence->drv->last_seq));
^
CC [M] drivers/gpu/drm/virtio/virtgpu_debugfs.odrivers/gpu/drm/virtio/virtgpu_debugfs.c: In function ‘virtio_gpu_debugfs_irq_info’:drivers/gpu/drm/virtio/virtgpu_debugfs.c:39:6: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘long long int’ [-Wformat=]
vgdev->fence_drv.sync_seq);
^--- drivers/gpu/drm/virtio/virtgpu_debugfs.c | 2 +- drivers/gpu/drm/virtio/virtgpu_fence.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/virtio/virtgpu_debugfs.c +1 -1
@@ -34,7 +34,7 @@ virtio_gpu_debugfs_irq_info(struct seq_file *m, void *data)struct drm_info_node *node = (struct drm_info_node *) m->private;struct virtio_gpu_device *vgdev = node->minor->dev->dev_private; -seq_printf (m,"fence %ld %lld\n" , +seq_printf (m,"fence %lld %lld\n" ,atomic64_read (&vgdev->fence_drv.last_seq), vgdev->fence_drv.sync_seq);return 0 ;
drivers/gpu/drm/virtio/virtgpu_fence.c +1 -1
@@ -61,7 +61,7 @@ static void virtio_timeline_value_str(struct fence *f, char *str, int size) {struct virtio_gpu_fence *fence =to_virtio_fence (f); -snprintf (str, size,"%lu" ,atomic64_read (&fence->drv->last_seq)); +snprintf (str, size,"%llu" ,atomic64_read (&fence->drv->last_seq)); }static const struct fence_ops virtio_fence_ops = {
Signature · 1 line
1.8.3.1
Gerd Hoffmann
maintainerQuoted 11 lines · Mike Rapoport
Update snprintf format in
virtgpu_fence.candvirtgpu_debugfs.cto fix the following compilation warnings:C [M]
drivers/gpu/drm/virtio/virtgpu_fence.odrivers/gpu/drm/virtio/virtgpu_fence.c: In function ‘virtio_timeline_value_str’ :drivers/gpu/drm/virtio/virtgpu_fence.c:64:2: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘long long int’ [-Wformat=]
snprintf(str, size, "%lu", atomic64_read(&fence->drv->last_seq));
^
CC [M]drivers/gpu/drm/virtio/virtgpu_debugfs.odrivers/gpu/drm/virtio/virtgpu_debugfs.c: In function ‘virtio_gpu_debugfs_irq_info’:drivers/gpu/drm/virtio/virtgpu_debugfs.c:39:6: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘long long int’ [-Wformat=]
Quoted 1 line
vgdev->fence_drv.sync_seq);
Doesn't fly. I assume this removes the warnings for 32bit builds, but with the patch applied I get warnings on 64bit builds ...
cheers,
Gerd
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
Gerd Hoffmann
maintainerQuoted 11 lines · Mike Rapoport
Update snprintf format in
virtgpu_fence.candvirtgpu_debugfs.cto fix the following compilation warnings:C [M]
drivers/gpu/drm/virtio/virtgpu_fence.odrivers/gpu/drm/virtio/virtgpu_fence.c: In function ‘virtio_timeline_value_str’ :drivers/gpu/drm/virtio/virtgpu_fence.c:64:2: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘long long int’ [-Wformat=]
snprintf(str, size, "%lu", atomic64_read(&fence->drv->last_seq));
^
CC [M]drivers/gpu/drm/virtio/virtgpu_debugfs.odrivers/gpu/drm/virtio/virtgpu_debugfs.c: In function ‘virtio_gpu_debugfs_irq_info’:drivers/gpu/drm/virtio/virtgpu_debugfs.c:39:6: warning: format ‘%ld’ expects argument of type ‘long int’, but argument 3 has type ‘long long int’ [-Wformat=]
Quoted 1 line
vgdev->fence_drv.sync_seq);
Doesn't fly. I assume this removes the warnings for 32bit builds, but with the patch applied I get warnings on 64bit builds ...
cheers,
Gerd
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel