Skip to contentSkip to conversation

usb: core: driver: Use kmalloc_array

PATCH New Muhammad Falak R Wani 1 participant 1 message Sep 7, 2015 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: core: driver: Use kmalloc_array

Use kmalloc_array instead of kmalloc to allocate memory for an array. Also, remove the dev_warn for a memory leak, making the if check more sleek.

---
On suggestion by Joe Perches <[email protected]>

Changes since v0
-remove dev_warn for memory leak
-remove unnecessary parens for if

---
 drivers/usb/core/driver.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/usb/core/driver.c +2 -4
index 818369a..e0636c1 100644
@@ -416,12 +416,10 @@ static int usb_unbind_interface(struct device *dev)
 		if (ep->streams == 0)
 			continue;
 		if (j == 0) {
-			eps = kmalloc(USB_MAXENDPOINTS * sizeof(void *),
+			eps = kmalloc_array(USB_MAXENDPOINTS, sizeof(void *),
 				      GFP_KERNEL);
-			if (!eps) {
-				dev_warn(dev, "oom, leaking streams\n");
+			if (!eps)
 				break;
-			}
 		}
 		eps[j++] = ep;
 	}
Signature · 1 line
1.9.1